]> sourceware.org Git - lvm2.git/log
lvm2.git
6 years agolvmlockd: avoid blocking in sanlock_convert
David Teigland [Wed, 29 Nov 2017 20:59:11 +0000 (14:59 -0600)]
lvmlockd: avoid blocking in sanlock_convert

Use the same flag as sanlock_acquire() for the
same purpose.  sanlock_convert can block like
acquire when doing a sh to ex conversion.

6 years agodeactivate_lvs: deactivate any missing RaidLV legs
Heinz Mauelshagen [Tue, 5 Dec 2017 17:48:06 +0000 (18:48 +0100)]
deactivate_lvs: deactivate any missing RaidLV legs

In case of failed legs, raid replaces those with
e.g. "vg-lv_rimage_0-missing_0_0" mapped to an error target.

Those errouneously remain on deactivation.

Fix by removing them on deactivation/removal of the RaidLV.

6 years agodevice: Skip read-modify-write if replacing whole block.
Alasdair G Kergon [Tue, 5 Dec 2017 01:00:38 +0000 (01:00 +0000)]
device: Skip read-modify-write if replacing whole block.

6 years agodevice: categorise block i/o
Alasdair G Kergon [Mon, 4 Dec 2017 23:18:56 +0000 (23:18 +0000)]
device: categorise block i/o

Introduce enum dev_io_reason to categorise block device I/O
in debug messages so it's obvious what it is for.

DEV_IO_SIGNATURES   /* Scanning device signatures */
DEV_IO_LABEL        /* LVM PV disk label */
DEV_IO_MDA_HEADER   /* Text format metadata area header */
DEV_IO_MDA_CONTENT  /* Text format metadata area content */
DEV_IO_FMT1         /* Original LVM1 metadata format */
DEV_IO_POOL         /* Pool metadata format */
DEV_IO_LV           /* Content written to an LV */
DEV_IO_LOG          /* Logging messages */

6 years agoactivation: also lock memory for clustered locking
Zdenek Kabelac [Mon, 4 Dec 2017 17:40:37 +0000 (18:40 +0100)]
activation: also lock memory for clustered locking

Commit  c086dfadc389551b9a2d7b4c26931e5e74ada8d6 missed to lock memory
for clustering suspend part since it's using differnt locking reason.

6 years agocleanup: drop unneeded check
Zdenek Kabelac [Mon, 4 Dec 2017 14:45:49 +0000 (15:45 +0100)]
cleanup: drop unneeded check

Code already has dereferenced UUID before this point,
and its already given we require name & uuid when ading new node
(although uuid could be empty string).

6 years agocleanup: messsage cleanup
Zdenek Kabelac [Mon, 4 Dec 2017 13:37:01 +0000 (14:37 +0100)]
cleanup: messsage cleanup

6 years agocleanup: drop unused define
Zdenek Kabelac [Mon, 4 Dec 2017 13:26:56 +0000 (14:26 +0100)]
cleanup: drop unused define

6 years agocleanup: use existing define with prefix
Zdenek Kabelac [Mon, 4 Dec 2017 13:26:37 +0000 (14:26 +0100)]
cleanup: use existing define with prefix

6 years agocleanup: use log_warn
Zdenek Kabelac [Mon, 4 Dec 2017 14:16:08 +0000 (15:16 +0100)]
cleanup: use log_warn

Fucntion is not failing execution -> log_warn.

6 years agoclenaup: use log_warn
Zdenek Kabelac [Mon, 4 Dec 2017 12:34:10 +0000 (13:34 +0100)]
clenaup: use log_warn

Avoid logging error when function is not failing.
Technically can't really happen ATM anyway.

6 years agocleanup: use _node_name
Zdenek Kabelac [Mon, 4 Dec 2017 12:33:05 +0000 (13:33 +0100)]
cleanup: use _node_name

Use existing internal method for create 'name (major:minor)' string
for debug messages and reduce some messages.

6 years agocleanup: stack tracing
Zdenek Kabelac [Mon, 4 Dec 2017 12:31:40 +0000 (13:31 +0100)]
cleanup: stack tracing

6 years agocleanup: mark success at the end
Zdenek Kabelac [Mon, 4 Dec 2017 11:49:57 +0000 (12:49 +0100)]
cleanup: mark success at the end

Simplify setting 'success' return value and use common use-pattern
for handling return code.

6 years agocleanup: drop impossible test case
Zdenek Kabelac [Mon, 4 Dec 2017 10:28:31 +0000 (11:28 +0100)]
cleanup: drop impossible test case

This test can never be true since info is embeded struct.

6 years agocleanup: simplier error message
Zdenek Kabelac [Mon, 4 Dec 2017 10:25:01 +0000 (11:25 +0100)]
cleanup: simplier error message

Use single 'error' message just with different reason.

6 years agocleanup: futher code reduction
Zdenek Kabelac [Mon, 4 Dec 2017 09:38:39 +0000 (10:38 +0100)]
cleanup: futher code reduction

Just like everywhere else - use single if() for major:minor setup
(it basically can't fail as of today anyway)

Always leave funtion with correctly set pointers even on error path.

6 years agocleanup: drop unused header
Zdenek Kabelac [Fri, 1 Dec 2017 21:58:47 +0000 (22:58 +0100)]
cleanup: drop unused header

DM_UUID_LEN is no longer needed.

6 years agolibdm: support for replicator target is dropped
Zdenek Kabelac [Mon, 4 Dec 2017 14:27:05 +0000 (15:27 +0100)]
libdm: support for replicator target is dropped

Replicator never really existed in upstream kernel and its support
got deprecated.

Also its support never got finished so no code is supposed to be
using it anyway.

Libdm symbols are remaining, just the implementation will always
return failure - so any user of:

dm_tree_node_add_replicator_dev_target()
dm_tree_node_add_replicator_target().

will now always recieve error message.

6 years agolibdm: watch for failing _info_by_dev
Zdenek Kabelac [Mon, 4 Dec 2017 14:05:44 +0000 (15:05 +0100)]
libdm: watch for failing _info_by_dev

Separate handling of error code from _info_by_dev.
This error can only happeng when we are running out of memory.
In such case there is urgent need to stop any futher proceeding
of command and run to error ASAP.

6 years agotest: allow to succeed in the cluster
Heinz Mauelshagen [Fri, 1 Dec 2017 17:59:55 +0000 (18:59 +0100)]
test: allow to succeed in the cluster

Avoiding "$(get first_extent_sector "$d")" in the loop
allows the test to succeed in the cluster.  Further cluster
analysis needed to get to the core reason.

6 years agotest: add large tests skip option
Heinz Mauelshagen [Fri, 1 Dec 2017 17:50:55 +0000 (18:50 +0100)]
test: add large tests skip option

The lvm2 test suite aims at small test resource footprints
(few PVs, small PV sizes) to run on tmpfs backed loop device.

OTOH, lvconvert-reshape-raid.sh aims to test the maxima of
supported total stripes of 64.  This patch adds a prerequisite
conditional to skip tests using more than 14 stripes.

It requires the target version 1.13.1 to avoid deadlocks.

6 years agotest: reduce pv sizes, fix comment and stripe size
Heinz Mauelshagen [Fri, 1 Dec 2017 17:42:37 +0000 (18:42 +0100)]
test: reduce pv sizes, fix comment and stripe size

6 years agotest: cleanup command
Heinz Mauelshagen [Fri, 1 Dec 2017 17:39:38 +0000 (18:39 +0100)]
test: cleanup command

6 years agolv_manip: allow extension on --nosync raid lv
Heinz Mauelshagen [Fri, 1 Dec 2017 17:38:18 +0000 (18:38 +0100)]
lv_manip: allow extension on --nosync raid lv

If the recovery of the repleced leg(s) of a RaidLV created without
initial resynchronization (i.e. "lvcreate --nosync ...") got
interrupted, it can't be extended because of the < 100% sync rate.

6 years agotest: disable new reshape test until target version 1.13.1
Heinz Mauelshagen [Fri, 1 Dec 2017 17:33:11 +0000 (18:33 +0100)]
test: disable new reshape test until target version 1.13.1

6 years agotest: new reshape test under io load
Heinz Mauelshagen [Fri, 1 Dec 2017 17:31:12 +0000 (18:31 +0100)]
test: new reshape test under io load

6 years agoraid: ignore --stripesize on raid4/5 conversion to 1 stripe
Heinz Mauelshagen [Fri, 1 Dec 2017 14:00:09 +0000 (15:00 +0100)]
raid: ignore --stripesize on raid4/5 conversion to 1 stripe

In case caller passes in changed stripe size when reshaping raid4/5
to 1 stripe aiming to convert to raid1 and optionally to linear,
ignore it to prevent data corruption.

6 years agocleanup: remove debug code
Zdenek Kabelac [Mon, 27 Nov 2017 15:52:38 +0000 (16:52 +0100)]
cleanup: remove debug code

6 years agocleanup: simplify _deps code
Zdenek Kabelac [Thu, 30 Nov 2017 11:53:34 +0000 (12:53 +0100)]
cleanup: simplify _deps code

Make _deps to always return name & uuid,
and postpone duplication of name and uuid into _create_dm_tree_node().
Saves some duplicated code.

6 years agosuspend: optimize generated list
Zdenek Kabelac [Thu, 30 Nov 2017 12:24:41 +0000 (13:24 +0100)]
suspend: optimize generated list

Avoid adding same LV multiple times into the list.
Just saves couple extra calls and ioctls and makes log shorter.

6 years agoactivation: avoid rechecking pvmove node
Zdenek Kabelac [Thu, 30 Nov 2017 12:26:44 +0000 (13:26 +0100)]
activation: avoid rechecking pvmove node

Use new 3rd. state of trace_pvmove_deps == 2.
In this state we know, we have already seen the node and can skip futher
testing.   Remainging value 1 signals we want to track, and value 0
is for ignoring tracking, but node is still checking in this case.

Reduces large amount of duplicate ioctl queries.

6 years agoactivation: extend resume validation
Zdenek Kabelac [Tue, 28 Nov 2017 22:11:20 +0000 (23:11 +0100)]
activation: extend resume validation

Check also all snapshosts when resume is requested,
the origin volume is already resume, but possibly
some subLV or snapshot LV could be suspended if
we are still in critical_section.

6 years agoactivation: split priority from memory locking
Zdenek Kabelac [Fri, 1 Dec 2017 10:50:14 +0000 (11:50 +0100)]
activation: split priority from memory locking

When entering any critical section, lvm2 used to lock process memory
and raised task priority to avoid problem with page swapping and minimize
time of having non-resumed devices in table.

With this patch, memory locking which which is expensive is only used when
entering  'suspending' section as only in this section there is risk
lvm could be suspending a device which later can be needed for paging.

Raised priority is still kept for all section entrances as this is
low-cost operation and may accelerate table resumes - although the real
impact can be still considered later.

6 years agopvmove: add missing segment merging
Zdenek Kabelac [Wed, 29 Nov 2017 21:19:46 +0000 (22:19 +0100)]
pvmove: add missing segment merging

When pvmove is finished and metadata are updated, the code missed
to merge possible mergable segments - so add explicit merging
call after pvmoved volumes are unlocked.

This avoids weird results where i.e. lvs could have been reporting
non-matching segments as lvs upon metadata read is doing silent segment
merging while dm table left after pvmove was still preserving
non-merged segments.

6 years agopvmove: move code from tools to lib
Zdenek Kabelac [Wed, 29 Nov 2017 21:19:05 +0000 (22:19 +0100)]
pvmove: move code from tools to lib

Move code manipulating with locking flags into /lib part of lvm.

6 years agoUpdate WHATS_NEW
Marian Csontos [Thu, 30 Nov 2017 12:30:28 +0000 (13:30 +0100)]
Update WHATS_NEW

6 years agotests: Fix common_dev_ argument handling
Marian Csontos [Tue, 28 Nov 2017 11:03:35 +0000 (12:03 +0100)]
tests: Fix common_dev_ argument handling

from[:[len]] arguments with missing colon assigned from to len, instead
of till_the_end_of_device.

6 years agolabel: Remove unused verify functions.
Alasdair G Kergon [Tue, 28 Nov 2017 01:36:55 +0000 (01:36 +0000)]
label: Remove unused verify functions.

label_verify has never been used so remove it.

6 years agocleanup: reuse existing macro
Zdenek Kabelac [Mon, 27 Nov 2017 09:20:24 +0000 (10:20 +0100)]
cleanup: reuse existing macro

Use existing macro to detect striped raid segment.

6 years agocmdline: avoid overrun on very large numbers.
Zdenek Kabelac [Mon, 27 Nov 2017 09:21:21 +0000 (10:21 +0100)]
cmdline: avoid overrun on very large numbers.

When large size number (>2^31) is given on command line it could be
misdetected and in certain cases lead to wrongly casted number.

So make sure all cases always do set _MAX number in case the value would
not fit within the supported range instead of getting some random value
within the range.

In most cases this was not a problem to detect, but i.e. stripesize
parameter might have been fooled by certain large numbers.

6 years agotoollib: improve stripes args reading
Zdenek Kabelac [Mon, 27 Nov 2017 09:26:35 +0000 (10:26 +0100)]
toollib: improve stripes args reading

Rewrite validation of stripes and stripe_size args into more readable
sequential code.

Extend reading of stripes & stripes_size args so it better knows
defaults for types like striped raid.

TODO: this should really be a value obtained for segtype structure and
all the weird conditions and modification of stripes and stripe_size
around lvm2 code should be dropped.

6 years agopvmove: enhance delayed_resume logic
Zdenek Kabelac [Sat, 25 Nov 2017 23:28:33 +0000 (00:28 +0100)]
pvmove: enhance delayed_resume logic

ATM we want to support delayed resume purely in pvmove case.
So have libdm logic internal to recognize difference beween
pvmove and other targets that do use delayed resume.

This fixes problem introduced with commit aa68b898ff9c51dcb
for mirror-on-mirror or snapshot-on-mirror problem.

TODO: likely added new API call and let libdm user select
delayed nodes explicitely.

6 years agoactivation: enhance holders detection
Zdenek Kabelac [Fri, 24 Nov 2017 19:59:38 +0000 (20:59 +0100)]
activation: enhance holders detection

Use code which detectes handlers in a way, which is more
backward-compatible friendly.

Replace read of 'sysfs' uuid entry with dm ioctl call.

Use /sys/block/dm-X/holders path instead of
new path  /sys/dev/block/major:minor/holders.

TODO:
There are few more occurencies of this logic around the code
so some abstract interface should be considered.

6 years agotests: more places where missing should not appear
Zdenek Kabelac [Tue, 21 Nov 2017 16:34:41 +0000 (17:34 +0100)]
tests: more places where missing should not appear

6 years agotests: typo
Zdenek Kabelac [Tue, 21 Nov 2017 14:34:02 +0000 (15:34 +0100)]
tests: typo

6 years agocleanup: update error messages
Zdenek Kabelac [Tue, 21 Nov 2017 14:33:29 +0000 (15:33 +0100)]
cleanup: update error messages

Correct printed lv names in error messages
and add missing trace for return.

6 years agocleanup: using max args consistently
Zdenek Kabelac [Tue, 21 Nov 2017 16:36:09 +0000 (17:36 +0100)]
cleanup: using max args consistently

Define and use MAX_PDATA_ARGS for thin_repair and cache_repair consistently.

6 years agocleanup: reduce couple debug lines
Zdenek Kabelac [Thu, 16 Nov 2017 23:01:45 +0000 (00:01 +0100)]
cleanup: reduce couple debug lines

6 years agocache: use conditional in warning message
Zdenek Kabelac [Mon, 20 Nov 2017 15:33:43 +0000 (16:33 +0100)]
cache: use conditional in warning message

In some cases the message could be slightly misleading so use
here rather conditional.

TODO:

In future we may possibly further tune the message in case we are
certain the level of redundancy protection has not been reduced.

6 years agotoollib: avoid printing default stripe size
Zdenek Kabelac [Fri, 17 Nov 2017 22:02:44 +0000 (23:02 +0100)]
toollib: avoid printing default stripe size

When user is not creating striped LV, do not print
rather confusing info about default stripe size.

6 years agopvmove: finish no longer needs explicit resumed
Zdenek Kabelac [Fri, 24 Nov 2017 13:00:22 +0000 (14:00 +0100)]
pvmove: finish no longer needs explicit resumed

Activation code can see from holders needed LVs for resume.

6 years agoactivation: automaticaly discover pvmove holders
Zdenek Kabelac [Fri, 24 Nov 2017 12:55:42 +0000 (13:55 +0100)]
activation: automaticaly discover pvmove holders

When pvmove is finished and does 'suspend/resume' on PVMOVE LV,
on resume path committed metadata are already showing 'standalone'
pvmove LV prepared just for removal.

However code should be able to 'resume' preloaded LV there were
participating in pvmove operation.

Previously this was all done in the 'tools' part of lvm2 code.
So the lvconvert upon pvmove finish had to explicitely call 'resume' on every such LV.
Now 'smarted' activation code is able to deduce and combine all information from
the active dm table and committed metadata so single  call resolves
it all in one go.

Internally holders are detected by reading sysfs directory to capture
all needed UUID which are then looked in lvm2 metadata and all such
LVs are automatically collected into dmtree.

6 years agomirror: use lv_update_and_reload_origin
Zdenek Kabelac [Fri, 24 Nov 2017 12:58:23 +0000 (13:58 +0100)]
mirror: use lv_update_and_reload_origin

Replace complex code with standard lv_update_and_reload_origin().
Extra suspend should not be necessary.
(If they would be - dependency tree would have bug for fixing).

6 years agolibdm: preload propagates delayed resume
Zdenek Kabelac [Fri, 24 Nov 2017 12:57:22 +0000 (13:57 +0100)]
libdm: preload propagates delayed resume

Propagate delayed resume at least for preload case in a simple way.
Currently  PVMOVE depends on internal logic where 'mirror' with
corelog is 'possible' PVMOVE. In such case resume of 'created'
node is 'delayed'.

This is mostly an ugly internal hack - but for the moment being when we
add propagation for preload - it does work reasonable.

TODO: provide standard API and avoid this internal 'guessing'.

6 years agolocking: pvmove is locking holding LV
Zdenek Kabelac [Fri, 24 Nov 2017 12:55:57 +0000 (13:55 +0100)]
locking: pvmove is locking holding LV

As we do get lock for pvmove LV - it's lockholder ATM.

6 years agoresume: secure critical section
Zdenek Kabelac [Fri, 24 Nov 2017 12:53:02 +0000 (13:53 +0100)]
resume: secure critical section

Only  thin-pool with origin_only suspend is allowed to be not suspending anything.
In such case pairing resume will 'decrement' critical section counter.

6 years agosuspend: handle start of pvmove
Zdenek Kabelac [Fri, 24 Nov 2017 12:51:17 +0000 (13:51 +0100)]
suspend: handle start of pvmove

Just like suspend handles preload for pvmove finish,
in similar way handle suspend of starting pvmove.

In this case the  precommited metadata are checked for list of PVMOVEed
LVs and those are suspended in with committed metadata.

6 years agolvconvert: prevent combining split snapshots in shared vg
David Teigland [Tue, 21 Nov 2017 17:45:49 +0000 (11:45 -0600)]
lvconvert: prevent combining split snapshots in shared vg

splitting snapshots was already prevented.

6 years agoman: lvmlockd steps for changing lock type
David Teigland [Tue, 21 Nov 2017 16:37:00 +0000 (10:37 -0600)]
man: lvmlockd steps for changing lock type

were not quite correct

7 years agolvmlockd: override unknown lock manager error numbers
David Teigland [Wed, 15 Nov 2017 22:00:41 +0000 (16:00 -0600)]
lvmlockd: override unknown lock manager error numbers

When sanlock or dlm lock managers return an error number
that we don't recognize, replace it with a generic -ELMERR
which is defined in the set of special lvmlockd error
numbers.  Otherwise, an unknown lock manager error number
could be misinterpreted for something else if it happened
to overlap another set of error numbers (which they have
not thus far.)

7 years agolvmlockd: retry on other sanlock errors
David Teigland [Wed, 15 Nov 2017 21:34:42 +0000 (15:34 -0600)]
lvmlockd: retry on other sanlock errors

These less common errors returned from sanlock should
also cause sanlock to retry the lock acquire:

- i/o timeout occurs during sanlock_acquire().
  other i/o on the same disk as the leases can cause
  sanlock i/o timeouts.

- low level disk paxos contention between hosts naturally
  causes one host to not acquire the lease.  There are a
  couple special error numbers associated with these cases
  that should just be recognized as a normal failure to
  acquire the lease.

7 years agodevice: log debug when I/O bounce buffer used
Alasdair G Kergon [Thu, 16 Nov 2017 19:16:10 +0000 (19:16 +0000)]
device: log debug when I/O bounce buffer used

7 years agolvmdiskscan: Remove unnecessary read.
Alasdair G Kergon [Thu, 16 Nov 2017 19:13:03 +0000 (19:13 +0000)]
lvmdiskscan: Remove unnecessary read.

dev_get_size will open the device itself.

7 years agoraid: add validation checks for reshape flags
Heinz Mauelshagen [Wed, 15 Nov 2017 20:24:44 +0000 (21:24 +0100)]
raid: add validation checks for reshape flags

Enhance vg_validate() raid checking functions to check for
flags  LV_RESHAPE and LV_RESHAPE_DELTA_DISKS_(MINUS|PLUS).

7 years agotests: pvmove supports more cases
Zdenek Kabelac [Fri, 10 Nov 2017 23:15:15 +0000 (00:15 +0100)]
tests: pvmove supports more cases

pvmove handles cached LVs as well as snapshots now.

7 years agopvmove: remove unusued code
Zdenek Kabelac [Fri, 10 Nov 2017 20:48:33 +0000 (21:48 +0100)]
pvmove: remove unusued code

Support for snapshot and cache LVs should now work.
Remove protection rejecting pvmove for them.

7 years agopvmove: activation changes
Zdenek Kabelac [Wed, 15 Nov 2017 13:26:10 +0000 (14:26 +0100)]
pvmove: activation changes

Do not use precommitted LV for suspend of pvmoving LVs.

7 years agopvmove: change locking on finish
Zdenek Kabelac [Tue, 14 Nov 2017 19:53:55 +0000 (20:53 +0100)]
pvmove: change locking on finish

7 years agocleanup: update log messages
Zdenek Kabelac [Tue, 14 Nov 2017 10:35:25 +0000 (11:35 +0100)]
cleanup: update log messages

7 years agoactivate_lvs: use exclusive activation
Zdenek Kabelac [Tue, 14 Nov 2017 10:46:43 +0000 (11:46 +0100)]
activate_lvs: use exclusive activation

There is no need to differentiation between clustered VG and normal VG.
As the activation depends on locking type.

Use unconditionally locally exclusive activation for pvmove.

7 years agopvmove: always flush when working with pvmove tree
Zdenek Kabelac [Wed, 15 Nov 2017 11:07:47 +0000 (12:07 +0100)]
pvmove: always flush when working with pvmove tree

7 years agoactivation: suspend pvmove using lv.
Zdenek Kabelac [Wed, 15 Nov 2017 11:08:33 +0000 (12:08 +0100)]
activation: suspend pvmove using lv.

Whenever pvmove tree is going to be generated for suspend
and such LV has a user - use this 'using LV' to generate
correct dm tree  holding all components.

7 years agoactivation: check subLV before skipping resume
Zdenek Kabelac [Fri, 10 Nov 2017 20:15:50 +0000 (21:15 +0100)]
activation: check subLV before skipping resume

LV is asked for resume, and its already resume and tool
is inside 'critical_section()' check if there is any suspended sub LV.
In that case 'resume' operation will not be skipped.

7 years agoactivate_lvs: deactivate on uniterate
Zdenek Kabelac [Tue, 14 Nov 2017 10:35:50 +0000 (11:35 +0100)]
activate_lvs: deactivate on uniterate

When activation of LVs fails prior pvmove start, try to deactivate
already activated LVs.

TODO: possibly remember which LVs where already activate and only those
take down - devices which are already in-use will stay active.

7 years agolayers: collect only lock holding LVs
Zdenek Kabelac [Thu, 9 Nov 2017 10:41:16 +0000 (11:41 +0100)]
layers: collect only lock holding LVs

7 years agopvmove: return pvmove itself
Zdenek Kabelac [Tue, 14 Nov 2017 19:44:32 +0000 (20:44 +0100)]
pvmove: return pvmove itself

When find_pvmove_lv_in_lv() get already a 'pvmoving' LV - return it.

7 years agopvmove: snapshots need to go with origin device
Zdenek Kabelac [Fri, 10 Nov 2017 20:18:55 +0000 (21:18 +0100)]
pvmove: snapshots need to go with origin device

Enable future support for pvmove for COW LVs.

7 years agoUpdate WHATS_NEW
Marian Csontos [Wed, 15 Nov 2017 09:01:50 +0000 (10:01 +0100)]
Update WHATS_NEW

7 years agoregenerate man and conf
Alasdair G Kergon [Wed, 15 Nov 2017 01:05:07 +0000 (01:05 +0000)]
regenerate man and conf

7 years agolog: Add io debug class
Alasdair G Kergon [Wed, 15 Nov 2017 00:59:30 +0000 (00:59 +0000)]
log: Add io debug class

7 years agometadata: Eliminate redundant nested VG metadata
Alasdair G Kergon [Tue, 14 Nov 2017 15:38:55 +0000 (15:38 +0000)]
metadata: Eliminate redundant nested VG metadata

Only lv_committed() now uses vg->vg_committed and it appears redundant
if its contents match the enclosing VG so don't waste cycles creating it
when that's known to be true when no write lock is held so the struct
won't get modified.

7 years agotest: additional avoid have_raid overhead
Heinz Mauelshagen [Tue, 14 Nov 2017 13:17:54 +0000 (14:17 +0100)]
test: additional avoid have_raid overhead

7 years agotest: avoid have_raid overhead
Heinz Mauelshagen [Tue, 14 Nov 2017 13:15:09 +0000 (14:15 +0100)]
test: avoid have_raid overhead

7 years agoraid: correct raid6_n_6 -> raid5 convenience type
Heinz Mauelshagen [Mon, 13 Nov 2017 17:03:50 +0000 (18:03 +0100)]
raid: correct raid6_n_6 -> raid5 convenience type

Fix "lvconvert --type raid5 RaidLV" on a "raid6_n_6" LV offering
false "raid6_ls_6" instead of "raid5_n".

7 years agometadata: Remove unused vg.cft_precommitted
Alasdair G Kergon [Tue, 14 Nov 2017 01:09:58 +0000 (01:09 +0000)]
metadata: Remove unused vg.cft_precommitted

The precommitted metadata config_tree is now only referenced from a
single function so just use a local variable instead.

7 years agolog: Improve various device-related messages
Alasdair G Kergon [Mon, 13 Nov 2017 14:43:32 +0000 (14:43 +0000)]
log: Improve various device-related messages

- Use 'lvmcache' consistently instead of 'metadata cache'
- Always use 5 characters for source line number
- Remember to convert uuids into printable form
- Use <no name> rather than (null) when VG has no name.

7 years agopersistent filter: Skip import before rescan
Alasdair G Kergon [Mon, 13 Nov 2017 19:45:16 +0000 (19:45 +0000)]
persistent filter: Skip import before rescan

The persistent filter should not be imported by any command that doesn't
use it so take addtional note of REQUIRES_FULL_LABEL_SCAN (for vgrename)
and introduce IGNORE_PERSISTENT_FILTER for vgscan and pvscan.

7 years agotests: use nonflusing status
Zdenek Kabelac [Fri, 10 Nov 2017 15:18:41 +0000 (16:18 +0100)]
tests: use nonflusing status

Avoid being blocked when reporting status with flushing on some stacked
device tree.

7 years agolv_lock_holder: unused cache-pool is not lock holder
Zdenek Kabelac [Fri, 10 Nov 2017 23:18:22 +0000 (00:18 +0100)]
lv_lock_holder: unused cache-pool is not lock holder

Unused cache-pool is only a constainer for data and metadata,
and does not present localble entity.

7 years agolvremove: for unused cache deactive sublv
Zdenek Kabelac [Fri, 10 Nov 2017 23:19:04 +0000 (00:19 +0100)]
lvremove: for unused cache deactive sublv

7 years agoreload: do not take backup with suspended devices
Zdenek Kabelac [Fri, 10 Nov 2017 12:28:33 +0000 (13:28 +0100)]
reload: do not take backup with suspended devices

If the suspend/resume sequence would leave some device in suspend
for possible later resume, backup cannot be takes (fs holding backups
could be still frozen in critical section())

7 years agocleanup: remove stack tracing for ok path
Zdenek Kabelac [Fri, 10 Nov 2017 12:41:45 +0000 (13:41 +0100)]
cleanup: remove stack tracing for ok path

7 years agocleanup: constify lv parameter
Zdenek Kabelac [Wed, 8 Nov 2017 13:24:09 +0000 (14:24 +0100)]
cleanup: constify lv parameter

7 years agoraid: protect raid4 activation
Zdenek Kabelac [Thu, 9 Nov 2017 12:00:28 +0000 (13:00 +0100)]
raid: protect raid4 activation

Move check for presence of raid4 into the right place
so there is no way how to hit activation of any LV
with raid4 on kernel which does not support it.

7 years agotest: check dmsetup hides integrity encryption keys
Ondrej Kozina [Fri, 10 Nov 2017 14:15:43 +0000 (15:15 +0100)]
test: check dmsetup hides integrity encryption keys

7 years agodmsetup: hide integrity encryption keys on table output
Ondrej Kozina [Fri, 10 Nov 2017 12:55:04 +0000 (13:55 +0100)]
dmsetup: hide integrity encryption keys on table output

7 years agotest: D-Bus test_nesting requires filter
Marian Csontos [Thu, 9 Nov 2017 09:56:15 +0000 (10:56 +0100)]
test: D-Bus test_nesting requires filter

7 years agotest: Rename test nothing methods
Marian Csontos [Thu, 9 Nov 2017 08:52:36 +0000 (09:52 +0100)]
test: Rename test nothing methods

These two methods might be useful for debugging, but are not testing
anything.

7 years agoraid: reject message for 2-legged raid4/5 -> striped
Heinz Mauelshagen [Wed, 8 Nov 2017 17:17:26 +0000 (18:17 +0100)]
raid: reject message for 2-legged raid4/5 -> striped

Commit 763db8aab02d7df551a3e8500d261ef6c9651bdb rejects 2-legged
conversions to striped/raid0 but different messages are displayed
for raid0 or striped. This commit provides the same rejection messages.

This page took 0.071051 seconds and 5 git commands to generate.