]> sourceware.org Git - lvm2.git/log
lvm2.git
16 years agoFix vgcfgbackup to properly check filename if template is used.
Milan Broz [Wed, 13 Aug 2008 12:44:24 +0000 (12:44 +0000)]
Fix vgcfgbackup to properly check filename if template is used.

16 years agoadd tests for pvchange and vgreduce usage (Jaroslav Stava)
Milan Broz [Tue, 12 Aug 2008 10:04:31 +0000 (10:04 +0000)]
add tests for pvchange and vgreduce usage (Jaroslav Stava)

16 years agotest vgsplit: reject to give away pv with the last mda copy (Jaroslav Stava)
Milan Broz [Tue, 12 Aug 2008 10:01:56 +0000 (10:01 +0000)]
test vgsplit: reject to give away pv with the last mda copy (Jaroslav Stava)

16 years ago* more strict const
Zdenek Kabelac [Thu, 7 Aug 2008 14:02:32 +0000 (14:02 +0000)]
* more strict const

16 years agoadded const modifiers
Zdenek Kabelac [Thu, 7 Aug 2008 14:01:17 +0000 (14:01 +0000)]
added const modifiers
switched const char* to  const char[] elements to save few relocation entries

16 years agoadded const and saved relocation entry
Zdenek Kabelac [Thu, 7 Aug 2008 13:59:49 +0000 (13:59 +0000)]
added const and saved relocation entry

16 years ago configure aborts if lcov or genhtml are missing with --enable-profiling
Zdenek Kabelac [Tue, 5 Aug 2008 14:29:38 +0000 (14:29 +0000)]
  configure aborts if lcov or genhtml are missing with --enable-profiling

16 years ago add test for pool labels gfs
Zdenek Kabelac [Tue, 5 Aug 2008 12:33:41 +0000 (12:33 +0000)]
 add test for pool labels gfs
 add test for metadatacopies0 and snapshot manipulation

16 years ago put dmeventd into the LD_LIBRARY_PATH for lvm-wrapper
Zdenek Kabelac [Tue, 5 Aug 2008 12:32:08 +0000 (12:32 +0000)]
 put dmeventd into the LD_LIBRARY_PATH for lvm-wrapper

16 years ago vgremove tries to remove lv snapshot first.
Zdenek Kabelac [Tue, 5 Aug 2008 12:05:26 +0000 (12:05 +0000)]
 vgremove tries to remove lv snapshot first.
 Added function lv_remove_with_dependencies().

16 years agoavoid endless option parsing loop
Zdenek Kabelac [Tue, 5 Aug 2008 11:39:54 +0000 (11:39 +0000)]
avoid endless option parsing loop
add support for lvm verbose operation -vvvv
add dlsym path to the test config file

16 years ago* parse error output for 'auto' keyword
Zdenek Kabelac [Mon, 4 Aug 2008 09:15:15 +0000 (09:15 +0000)]
* parse error output for 'auto' keyword

16 years agoImprove file descriptor leak detection to display likely culprit and filename.
Alasdair Kergon [Fri, 1 Aug 2008 19:51:27 +0000 (19:51 +0000)]
Improve file descriptor leak detection to display likely culprit and filename.

16 years ago disable mdadm test-case until a better solution is found
Zdenek Kabelac [Fri, 1 Aug 2008 15:44:53 +0000 (15:44 +0000)]
 disable mdadm test-case until a better solution is found

16 years agoremove now-redundant slash-stripping
Alasdair Kergon [Thu, 31 Jul 2008 15:38:52 +0000 (15:38 +0000)]
remove now-redundant slash-stripping

16 years agoChange clustered mirror kernel module name from cmirror to dm-log-clustered.
Alasdair Kergon [Thu, 31 Jul 2008 14:43:39 +0000 (14:43 +0000)]
Change clustered mirror kernel module name from cmirror to dm-log-clustered.

16 years agoAvoid looping forever in _pv_analyze_mda_raw used by pvck.
Alasdair Kergon [Thu, 31 Jul 2008 13:07:01 +0000 (13:07 +0000)]
Avoid looping forever in _pv_analyze_mda_raw used by pvck.

16 years agoChange lvchange exit status to indicate if any part of the operation failed.
Alasdair Kergon [Thu, 31 Jul 2008 13:03:01 +0000 (13:03 +0000)]
Change lvchange exit status to indicate if any part of the operation failed.

16 years agoremove unused mdas variable
Alasdair Kergon [Thu, 31 Jul 2008 12:40:52 +0000 (12:40 +0000)]
remove unused mdas variable

16 years agofix pvremove for pvs without mdas
Alasdair Kergon [Thu, 31 Jul 2008 12:38:31 +0000 (12:38 +0000)]
fix pvremove for pvs without mdas

16 years agoFix pvchange to handle PVs without mdas.
Alasdair Kergon [Thu, 31 Jul 2008 12:28:51 +0000 (12:28 +0000)]
Fix pvchange to handle PVs without mdas.

16 years agoRefactor _text_pv_read and always return mda list if requested.
Alasdair Kergon [Thu, 31 Jul 2008 10:50:18 +0000 (10:50 +0000)]
Refactor _text_pv_read and always return mda list if requested.

16 years agoAdd pvcreate tests to verify failure on md array detection.
Dave Wysochanski [Tue, 29 Jul 2008 21:05:20 +0000 (21:05 +0000)]
Add pvcreate tests to verify failure on md array detection.

16 years agoFix trivial typo in pvcreate man page.
Dave Wysochanski [Tue, 29 Jul 2008 18:35:00 +0000 (18:35 +0000)]
Fix trivial typo in pvcreate man page.

16 years agoRefactor pvcreate - simplify return codes.
Dave Wysochanski [Fri, 25 Jul 2008 14:59:51 +0000 (14:59 +0000)]
Refactor pvcreate - simplify return codes.

16 years agoRefactor pvcreate - --yes argument
Dave Wysochanski [Fri, 25 Jul 2008 14:45:24 +0000 (14:45 +0000)]
Refactor pvcreate - --yes argument

16 years agoRefactor pvcreate - --force parameter.
Dave Wysochanski [Fri, 25 Jul 2008 14:36:55 +0000 (14:36 +0000)]
Refactor pvcreate - --force parameter.

16 years agoRefactor pvcreate - use '0' for no --uuid or --restorefile options.
Dave Wysochanski [Fri, 25 Jul 2008 14:12:29 +0000 (14:12 +0000)]
Refactor pvcreate - use '0' for no --uuid or --restorefile options.

16 years agoconfigure: regenerate
Jim Meyering [Fri, 25 Jul 2008 08:00:40 +0000 (08:00 +0000)]
configure: regenerate

16 years agoAvoid compiler warnings (provoked by new configure.in bug) on RHEL5.
Jim Meyering [Fri, 25 Jul 2008 08:00:18 +0000 (08:00 +0000)]
Avoid compiler warnings (provoked by new configure.in bug) on RHEL5.

Do not override the default action of AC_CHECK_LIB([readline],...
(i.e., leave the ACTION-IF-FOUND parameter blank) so that the
subsequent check for rl_completion_matches can use -lreadline.

Also, replace AC_CHECK_FUNC+AC_DEFINE with an equivalent AC_CHECK_FUNCS call.

16 years agoRefactor pvcreate - move uuid and restorefile options.
Dave Wysochanski [Fri, 25 Jul 2008 00:30:57 +0000 (00:30 +0000)]
Refactor pvcreate - move uuid and restorefile options.

16 years agoAdd pvcreate tests for uuid and restorefile.
Dave Wysochanski [Thu, 24 Jul 2008 17:33:40 +0000 (17:33 +0000)]
Add pvcreate tests for uuid and restorefile.

16 years ago.
Alasdair Kergon [Thu, 24 Jul 2008 15:39:47 +0000 (15:39 +0000)]
.

16 years agoreinstate lost FIXME
Alasdair Kergon [Thu, 24 Jul 2008 15:25:09 +0000 (15:25 +0000)]
reinstate lost FIXME
- only if kernel gives the info, not to be worked out in userspace
- with lvm.conf option to enable/disable the check

16 years agoconfigure: regenerate
Jim Meyering [Thu, 24 Jul 2008 14:54:26 +0000 (14:54 +0000)]
configure: regenerate

16 years agoDon't make configure fail when readline library is not available.
Jim Meyering [Thu, 24 Jul 2008 14:54:06 +0000 (14:54 +0000)]
Don't make configure fail when readline library is not available.

16 years agoRemove dead code, is_lvm_partition() - no functional change.
Dave Wysochanski [Wed, 23 Jul 2008 19:46:33 +0000 (19:46 +0000)]
Remove dead code, is_lvm_partition() - no functional change.

This code does nothing.  The function is #defined to 1 which ensures the only
two if statements referencing it will never be true.

16 years agoRefactor pvcreate - move labelsector parameter parsing & validation.
Dave Wysochanski [Wed, 23 Jul 2008 19:29:58 +0000 (19:29 +0000)]
Refactor pvcreate - move labelsector parameter parsing & validation.

16 years agoRefactor pvcreate - divide parameter parsing & validation from create logic.
Dave Wysochanski [Mon, 21 Jul 2008 19:27:22 +0000 (19:27 +0000)]
Refactor pvcreate - divide parameter parsing & validation from create logic.

Move size (setphysicalvolumesize option), metadatacopies and metadatasize
validation.

16 years agoRefactor pvcreate to divide parameter parsing & validation from create logic.
Dave Wysochanski [Mon, 21 Jul 2008 19:26:33 +0000 (19:26 +0000)]
Refactor pvcreate to divide parameter parsing & validation from create logic.

16 years agoAdd more pvcreate tests to validate writing lvm2 label using --labelsector.
Dave Wysochanski [Mon, 21 Jul 2008 18:50:10 +0000 (18:50 +0000)]
Add more pvcreate tests to validate writing lvm2 label using --labelsector.

16 years agoRefactor _lvcreate() - no functional change.
Dave Wysochanski [Thu, 17 Jul 2008 15:19:42 +0000 (15:19 +0000)]
Refactor _lvcreate() - no functional change.

16 years agoOnly use lvm2 metadata for now.
Dave Wysochanski [Thu, 17 Jul 2008 04:03:04 +0000 (04:03 +0000)]
Only use lvm2 metadata for now.

16 years agoUpdate pvcreate and vgsplit tests.
Dave Wysochanski [Thu, 17 Jul 2008 03:17:01 +0000 (03:17 +0000)]
Update pvcreate and vgsplit tests.

Add more pvcreate tests.
Start handling lvm1 and lvm2 metadata and metadatacopies=0,1.

16 years agoAdd pvcreate sanity tests, check for label_write() failure in _text_pv_write().
Dave Wysochanski [Wed, 16 Jul 2008 21:32:38 +0000 (21:32 +0000)]
Add pvcreate sanity tests, check for label_write() failure in _text_pv_write().

Failure to check for label_write() return code caused the following test
to indicate it passed when it really failed:
pvcreate rejects labelsector > 1000000000000

16 years agoFix pvchange -M1 -u to preserve existing extent locations when there's a VG.
Alasdair Kergon [Wed, 16 Jul 2008 10:46:12 +0000 (10:46 +0000)]
Fix pvchange -M1 -u to preserve existing extent locations when there's a VG.

16 years agoCease recognising snapshot-in-use percentages returned by early development kernels.
Alasdair Kergon [Tue, 15 Jul 2008 00:25:52 +0000 (00:25 +0000)]
Cease recognising snapshot-in-use percentages returned by early development kernels.

16 years agoFix gcc warnings.
Petr Rockai [Fri, 11 Jul 2008 09:19:54 +0000 (09:19 +0000)]
Fix gcc warnings.

16 years agoAdd "flags" metadata field (akin to "status") for backward-compatible flags.
Petr Rockai [Thu, 10 Jul 2008 11:30:57 +0000 (11:30 +0000)]
Add "flags" metadata field (akin to "status") for backward-compatible flags.

The "status" field is treated as it ever has been, unknown flags there are
treated as fatal metadata errors. However, in the "flags" field, any unknown
flags will be ignored and silently dropped. This improves
backward-compatibility possibilities. (Any versions without support for this
new "flag" field will drop the field altogether, which is same as ignoring all
the flags there.)

16 years ago.
Alasdair Kergon [Thu, 10 Jul 2008 09:50:23 +0000 (09:50 +0000)]
.

16 years agoAdd #include <signal.h> to dmeventd.c, fixes compilation on NetBSD.
Petr Rockai [Wed, 9 Jul 2008 13:26:07 +0000 (13:26 +0000)]
Add #include <signal.h> to dmeventd.c, fixes compilation on NetBSD.

16 years agoFix dmeventd regression where mirror and snapshot monitoring libraries
Petr Rockai [Wed, 9 Jul 2008 09:59:42 +0000 (09:59 +0000)]
Fix dmeventd regression where mirror and snapshot monitoring libraries
failed to link against liblvm2cmd.

Dmeventd DSOs *require* lvm2cmd to be linked in.

For the future:
1) AC_SUBST does not create Makefile variables, only @foo@-style substitutions
2) When using `test', whitespace around `=' is essential:
    test a=b is true, as is test a=a

16 years agopost-release
Alasdair Kergon [Fri, 27 Jun 2008 22:35:22 +0000 (22:35 +0000)]
post-release

16 years agopre-release
Alasdair Kergon [Fri, 27 Jun 2008 21:56:35 +0000 (21:56 +0000)]
pre-release

16 years agoEnable readline by default if available.
Alasdair Kergon [Fri, 27 Jun 2008 19:57:27 +0000 (19:57 +0000)]
Enable readline by default if available.

16 years agotweak lcov configuration/makefiles
Alasdair Kergon [Fri, 27 Jun 2008 19:24:17 +0000 (19:24 +0000)]
tweak lcov configuration/makefiles

16 years agoAdded generation of the versioned libdevmapper-event.so for LVM's test
Zdenek Kabelac [Fri, 27 Jun 2008 15:36:51 +0000 (15:36 +0000)]
Added generation of the versioned libdevmapper-event.so for LVM's test

16 years agoextended configure with --enable-profiling for compiling code with gcov info
Zdenek Kabelac [Fri, 27 Jun 2008 15:35:09 +0000 (15:35 +0000)]
extended configure with --enable-profiling for compiling code with gcov info
extended Makefile with targets:
  cov-reset - reset counters
  cov       - generete report to covhtml subdirectory
  covd      - generate report to covhtml-DATE-TIME subdirectory

16 years agoFix up cache for PVs without mdas after consistent VG metadata is processed.
Alasdair Kergon [Fri, 27 Jun 2008 15:18:31 +0000 (15:18 +0000)]
Fix up cache for PVs without mdas after consistent VG metadata is processed.

16 years agoUpdate validation of safe mirror log type conversions in lvconvert. (brassow)
Alasdair Kergon [Thu, 26 Jun 2008 23:05:11 +0000 (23:05 +0000)]
Update validation of safe mirror log type conversions in lvconvert. (brassow)

16 years agoFix lvconvert to disallow snapshot and mirror combinations. (mpatocka)
Alasdair Kergon [Thu, 26 Jun 2008 21:38:58 +0000 (21:38 +0000)]
Fix lvconvert to disallow snapshot and mirror combinations. (mpatocka)

16 years agoUnderline longer report help text headings.
Alasdair Kergon [Wed, 25 Jun 2008 19:52:52 +0000 (19:52 +0000)]
Underline longer report help text headings.

16 years agoFix reporting of LV fields alongside unallocated PV segments.
Alasdair Kergon [Wed, 25 Jun 2008 16:52:27 +0000 (16:52 +0000)]
Fix reporting of LV fields alongside unallocated PV segments.

16 years agoTest script cleanup.
Dave Wysochanski [Wed, 25 Jun 2008 16:51:26 +0000 (16:51 +0000)]
Test script cleanup.

16 years agopost-release
Alasdair Kergon [Wed, 25 Jun 2008 14:44:00 +0000 (14:44 +0000)]
post-release

16 years agopre-commit
Alasdair Kergon [Wed, 25 Jun 2008 14:24:17 +0000 (14:24 +0000)]
pre-commit

16 years agoAlign struct memblock in dbg_malloc for sparc.
Alasdair Kergon [Wed, 25 Jun 2008 14:10:33 +0000 (14:10 +0000)]
Align struct memblock in dbg_malloc for sparc.

16 years agoCope with missing field values.
Alasdair Kergon [Wed, 25 Jun 2008 00:10:36 +0000 (00:10 +0000)]
Cope with missing field values.

16 years agoAdd --rows to dmsetup.
Alasdair Kergon [Tue, 24 Jun 2008 22:53:48 +0000 (22:53 +0000)]
Add --rows to dmsetup.

16 years agoAdd --rows to reports.
Alasdair Kergon [Tue, 24 Jun 2008 22:48:53 +0000 (22:48 +0000)]
Add --rows to reports.

16 years agoAdd --unquoted to reporting tools.
Alasdair Kergon [Tue, 24 Jun 2008 21:21:04 +0000 (21:21 +0000)]
Add --unquoted to reporting tools.

16 years agodmsetup --unquoted
Alasdair Kergon [Tue, 24 Jun 2008 20:16:47 +0000 (20:16 +0000)]
dmsetup --unquoted

16 years agoRefactor pv_create() to take cmd_context - no functional change.
Dave Wysochanski [Tue, 24 Jun 2008 20:10:32 +0000 (20:10 +0000)]
Refactor pv_create() to take cmd_context - no functional change.

16 years agoSuppress invalid 'sb_offset' compiler warning (FC8) with uninitialized_var().
Dave Wysochanski [Mon, 23 Jun 2008 19:26:21 +0000 (19:26 +0000)]
Suppress invalid 'sb_offset' compiler warning (FC8) with uninitialized_var().

device/dev-md.c:61: warning: ‘sb_offset’ may be used uninitialized in this function

16 years agoAdd uninitialized_var macro to suppress invalid compiler warnings.
Dave Wysochanski [Mon, 23 Jun 2008 19:04:34 +0000 (19:04 +0000)]
Add uninitialized_var macro to suppress invalid compiler warnings.

One such warning is seen on fedora9 gcc compiler:
/metadata.c:1923: warning: 'results' may be used uninitialized in this function

16 years agoSuppress 'sb_offset' compiler warning by using enum for md superblock versions.
Dave Wysochanski [Mon, 23 Jun 2008 14:54:50 +0000 (14:54 +0000)]
Suppress 'sb_offset' compiler warning by using enum for md superblock versions.

The warning is bogus and is only seen on certain versions of gcc.
However using the enum does seem to clarify the intent of the code - only
3 possible md minor superblock versions.

Related compiler warning:
device/dev-md.c:53: warning: 'sb_offset' may be used uninitialized in this function

16 years agolvm2_run: don't return uninitialized for _memlock_inc or _memlock_dec
Jim Meyering [Mon, 23 Jun 2008 09:27:45 +0000 (09:27 +0000)]
lvm2_run: don't return uninitialized for _memlock_inc or _memlock_dec

* tools/lvmcmdlib.c: Initialize "ret".  Also avoid useless string
comparison.

16 years agoconfigure: regenerate
Jim Meyering [Mon, 23 Jun 2008 09:25:57 +0000 (09:25 +0000)]
configure: regenerate

16 years agoavoid link failure when configuring without --enable-cmdlib
Jim Meyering [Mon, 23 Jun 2008 09:25:08 +0000 (09:25 +0000)]
avoid link failure when configuring without --enable-cmdlib

* configure.in (LVM2CMD_LIB): Define if --enable-cmdlib.
* dmeventd/mirror/Makefile.in (CLDFLAGS): Use $(LVM2CMD_LIB) rather
than hard-coding -llvm2cmd.
* dmeventd/snapshot/Makefile.in (CLDFLAGS): Likewise.

16 years agoavoid link failure when configuring without --enable-readline
Jim Meyering [Mon, 23 Jun 2008 09:23:48 +0000 (09:23 +0000)]
avoid link failure when configuring without --enable-readline

* configure.in: Define READLINE_SUPPORT not when processing
--enable-readline or --disable-readline, but rather only after
determining that readline support is desired and the readline
library is available/usable.

16 years agoMake clvmd return immediately if other nodes are down in an openais cluster.
Christine Caulfield [Fri, 20 Jun 2008 12:46:21 +0000 (12:46 +0000)]
Make clvmd return immediately if other nodes are down in an openais cluster.

16 years agoMake clvmd return immediately if other nodes are down in a gulm cluster.
Christine Caulfield [Fri, 20 Jun 2008 10:58:28 +0000 (10:58 +0000)]
Make clvmd return immediately if other nodes are down in a gulm cluster.
bz#447799

16 years agoImprove/Fix read ahead 'auto' calculation for stripe_size
Zdenek Kabelac [Wed, 18 Jun 2008 11:32:14 +0000 (11:32 +0000)]
Improve/Fix read ahead 'auto' calculation for stripe_size
Fix lvchange output for -r auto setting if auto is already set
Add testcase for read ahead

16 years agoavoid compiler warning about cast in OFFSET_OF macro
Jim Meyering [Wed, 18 Jun 2008 10:19:25 +0000 (10:19 +0000)]
avoid compiler warning about cast in OFFSET_OF macro

* dmsetup/dmsetup.c (OFFSET_OF): Use an equivalent definition
that does not cast a pointer value to a narrower type.

16 years agoFix identifier 'error_message_produced' used ambiguously.
Dave Wysochanski [Tue, 17 Jun 2008 14:14:00 +0000 (14:14 +0000)]
Fix identifier 'error_message_produced' used ambiguously.

Related compiler warning:
log/log.c:242: warning: declaration of 'error_message_produced' shadows a global declaration
../include/log.h:98: warning: shadowed declaration is here

16 years agoTrivial fix to lvcreate man page for --mirrorlog option.
Dave Wysochanski [Mon, 16 Jun 2008 14:16:02 +0000 (14:16 +0000)]
Trivial fix to lvcreate man page for --mirrorlog option.

16 years agoBegin syncing configure.in for merge/unification with device-mapper.
Jim Meyering [Fri, 13 Jun 2008 14:37:18 +0000 (14:37 +0000)]
Begin syncing configure.in for merge/unification with device-mapper.

16 years agoDon't deref uninitialized log_lv upon failed mirror addition.
Jim Meyering [Fri, 13 Jun 2008 12:15:55 +0000 (12:15 +0000)]
Don't deref uninitialized log_lv upon failed mirror addition.

* mirror.c (add_mirror_images): Ensure that log_lv is initialized.

16 years agoDon't call openlog for every invocation of debuglog.
Christine Caulfield [Fri, 13 Jun 2008 07:44:14 +0000 (07:44 +0000)]
Don't call openlog for every invocation of debuglog.
Patch from Masatake YAMATO

16 years agoAdd --force to lvextend and lvresize.
Alasdair Kergon [Thu, 12 Jun 2008 13:24:02 +0000 (13:24 +0000)]
Add --force to lvextend and lvresize.

16 years agoFix vgchange to not activate mirror leg and log volumes directly.
Milan Broz [Thu, 12 Jun 2008 11:49:46 +0000 (11:49 +0000)]
Fix vgchange to not activate mirror leg and log volumes directly.

16 years agoMakefile.in: correct distclean rule
Jim Meyering [Thu, 12 Jun 2008 09:48:45 +0000 (09:48 +0000)]
Makefile.in: correct distclean rule

* Makefile.in (SUBDIRS): Remove long-unused test/* names.
(SUBDIRS) [distclean]: Append "test".
Discovered with Zdeněk Kabeláč.

16 years agobreak (rather than return) so we have only one point of return
Jim Meyering [Wed, 11 Jun 2008 15:02:52 +0000 (15:02 +0000)]
break (rather than return) so we have only one point of return

* tools/toollib.c (process_each_segment_in_lv): Upon sigint_caught,
break rather than returning ret_max.  No semantic change.

16 years agocopy vgid only when volume group is present in import_pool_pv
Zdenek Kabelac [Wed, 11 Jun 2008 13:14:41 +0000 (13:14 +0000)]
copy vgid only when volume group is present in import_pool_pv

16 years agopost-release
Alasdair Kergon [Wed, 11 Jun 2008 12:14:41 +0000 (12:14 +0000)]
post-release

16 years agopre-release
Alasdair Kergon [Wed, 11 Jun 2008 12:08:19 +0000 (12:08 +0000)]
pre-release

16 years agoFix tracking of validity of PVs with no mdas in lvmcache.
Alasdair Kergon [Wed, 11 Jun 2008 11:02:05 +0000 (11:02 +0000)]
Fix tracking of validity of PVs with no mdas in lvmcache.

16 years agoFix return values for reporting commands when run with no PVs, LVs, or VGs.
Dave Wysochanski [Tue, 10 Jun 2008 20:07:04 +0000 (20:07 +0000)]
Fix return values for reporting commands when run with no PVs, LVs, or VGs.
The new error checking code caught some commands that were returning '0' as
an exit status for success.  This is incorrect and resulted in a benign error
message displayed (see below).  As of today, all commands should return a
value defined in lib/commands/errors.h (1-5).  This results in an exit code of
0 on success, or > 0 on failure (as stated in the lvm.8 man page).

Before change:
1. Make sure no PVs are on the system
2. Run 'pvs'
  Command failed with status code 0.

After change:
<no output>

16 years agoAdd ommitted unlock_vg() call when sigint_caught() during vg processing.
Dave Wysochanski [Tue, 10 Jun 2008 15:25:38 +0000 (15:25 +0000)]
Add ommitted unlock_vg() call when sigint_caught() during vg processing.

Specific test case:
1. pvcreate /dev/loop1; vgcreate vg1 /dev/loop1; lvcreate -L 64M -n lv1 vg1
2. vgremove vg1 (will prompt user)
3. CTRL-C
Code will exit with:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
  Volume group "vg2" not removed
  Command failed with status code 5.
  Internal error: Volume Group vg2 was not unlocked
  Device '/dev/loop1' has been left open.

After change:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
  Volume group "vg2" not removed
  Command failed with status code 5.

16 years agoFix wrong free_count on imported volume group from pool device
Zdenek Kabelac [Tue, 10 Jun 2008 14:55:14 +0000 (14:55 +0000)]
Fix wrong free_count on imported volume group from pool device
Fix segfault when calling pvcreate on the pool device

This page took 0.068974 seconds and 5 git commands to generate.