Dave Brolley [Fri, 20 Feb 2009 21:58:57 +0000 (16:58 -0500)]
Check for required resources and tools before attempting tests using the client/server.
Ensure that tests run with/without the server have unique names.
Mark Wielaard [Fri, 20 Feb 2009 13:12:19 +0000 (14:12 +0100)]
Ignore kernel functions with "absolute" addresses.
translate.cxx (dump_unwindsyms): Augment the test for creating the
stap-symbols to be STT_FUNC && !(SHN_UNDEF || SHN_ABS). The combination
STT_FUNC && SHN_ABS only seems to occur on older i386 kernels and covers
the vDSO "functions" we were seeing.
Josh Stone [Fri, 20 Feb 2009 04:00:31 +0000 (20:00 -0800)]
Update guidelines for the ChangeLog-less world
Getting rid of ChangeLogs doesn't mean that we get a free ticket -- we
now need to be more diligent about providing meaningful commit messages.
I've updated the HACKING file with a first draft of new guidelines, but
we may still revise what we feel is appropriate detail in the logs.
I removed the ChangeLog section from the tapset/DEVGIDE entirely, and
also fixed the path where examples are stored.
Josh Stone [Fri, 20 Feb 2009 03:06:43 +0000 (19:06 -0800)]
Kill all ChangeLogs
Mark Wielaard, a dear friend of the departed, will be performing a song
and dance at the funeral services to commemorate the joyous times that
they had together.
Josh Stone [Fri, 20 Feb 2009 02:26:47 +0000 (18:26 -0800)]
Clean up extraneous build warnings
The testsuite Makefile doesn't have any useful targets except check and
installcheck, and those two are invoked directly by the top-level
Makefile. So, I'm removing testsuite from automake's SUBDIRS, but
keeping it in DIST_SUBDIRS for cleanup.
I also renamed our top-level check target to check-local, so it
cooperates with automake's check instead of overriding it.
Josh Stone [Wed, 18 Feb 2009 02:15:06 +0000 (18:15 -0800)]
Enable dwarf expansion of @casts
This will iterate over the module and its CUs looking for the type
definition, and then work with loc2c to dereference the pointer.
* loc2c.c (c_translate_argument): Create a dummy location to start
the address computation from a function parameter.
* translate.cxx (base_query, dwarf_query): Move some members from
base_query to dwarf_query, so the former can be more generic. Also
add a constructor using a module string instead of probe parameters.
(dwflpp::query_modules, dwflpp::iterate_over_modules): Use a generic
base_query instead of a dwarf_query.
(dwarf_cast_query): New query to scan the modules and CUs for a
matching type definition, and then produce a code fragment to deref
each component.
(dwarf_cast_expanding_visitor): Tries to replace @casts with a function
call to the result of a dwarf_cast_query.
(dwflpp::declaration_resolve): Search by name instead of by die.
(dwflpp::translate_components): Use the incoming vardie as the first
type die, so we don't assume that attr_mem has a DW_AT_type already.
(dwflpp::literal_stmt_for_pointer): Construct a C fragment that starts
with a pointer argument (THIS->pointer) and dereferences each member
component from there.
(*_derived_probe::register_patterns): Take a session parameter instead
of a match_node, so we can manipulate session-wide data.
(dwarf_derived_probe::register_patterns): Add a session code filter to
expand @casts with a dwarf_cast_expanding_visitor.
Josh Stone [Wed, 11 Feb 2009 23:28:41 +0000 (15:28 -0800)]
Enable session-wide code filtering
This will be used to hook to dwarf_builder to all functions and probes
so it can attempt @cast expansion.
* session.h (systemtap_session): Add a vector of update_visitors
that will act as filters for all probes and functions.
* elaborate.cxx (semantic_pass_symbols): Run probes and functions
through each registered code filter.
Josh Stone [Wed, 11 Feb 2009 22:43:24 +0000 (14:43 -0800)]
Provide dwarf module names as defaults in @cast()s
* tapsets.cxx (dwarf_var_expanding_visitor::visit_cast_op): While
expanding dwarf probes, provide the current module as a default to
@casts without a module name.
Josh Stone [Wed, 11 Feb 2009 22:34:32 +0000 (14:34 -0800)]
Add high-level support for @cast()ing
This handles all of the parsing, traversal, and optimization. It
doesn't actually resolve the cast yet though.
* staptree.h (struct cast_op, visitor::visit_cast_op): New.
* staptree.cxx (cast_op::print/visit, various visitor::visit_cast_op's):
Incorporate cast_op into the basic tree operations.
* parse.cxx (parser::parse_symbol): Parse @cast operator with an
expression operand, type string, and optional module string.
* translate.cxx (c_unparser::visit_cast_op): Error out if a @cast
survives to translation.
* elaborate.cxx (typeresolution_info::visit_cast_op): Error out if a
@cast survives to type resolution.
(symbol_fetcher::visit_cast_op): treat @casts as a symbol target
(void_statement_reducer::visit_cast_op): unused @casts can be discarded,
but the operand should still be evaluated.
David Smith [Tue, 17 Feb 2009 14:32:43 +0000 (08:32 -0600)]
Reduced control channel code duplication.
2009-02-17 David Smith <dsmith@redhat.com>
* control.c: Contains generic control channel functions.
* procfs.c: Specific procfs control channel functions. All generic
control channel functions moved to control.c.
* debugfs.c: New file containing debugfs specific control channel
functions.
* control.h: New file.
* transport.c: Updated file inclusion.
David Smith [Thu, 12 Feb 2009 20:52:40 +0000 (14:52 -0600)]
Cleanup. Renamed _stp_{un}lock_debugfs() to _stp_{un}lock_transport_dir().
2009-02-12 David Smith <dsmith@redhat.com>
* transport.c (_stp_lock_transport_dir): Renamed from
_stp_lock_debugfs(), since on older kernels this actually uses
procfs.
(_stp_unlock_transport_dir): Renamed from _stp_unlock_debugfs(),
since on older kernels this actually uses procfs.
(_stp_lock_transport_dir): Changed
_stp_lock_debugfs()/_stp_unlock_debugfs() to
_stp_lock_transport_dir()/_stp_unlock_transport_dir().
* transport.h: Ditto. Also added _stp_transport_init()
prototype.
* utt.c (utt_remove_root): Changed
_stp_lock_debugfs()/_stp_unlock_debugfs() to
_stp_lock_transport_dir()/_stp_unlock_transport_dir().
* relayfs.c (_stp_remove_relay_root): Ditto.
2009-02-12 David Smith <dsmith@redhat.com>
* procfs.c (_stp_rmdir_proc_module): Changed
_stp_lock_debugfs()/_stp_unlock_debugfs() to
_stp_lock_transport_dir()/_stp_unlock_transport_dir().
(_stp_mkdir_proc_module): Ditto.
Josh Stone [Wed, 11 Feb 2009 04:10:33 +0000 (20:10 -0800)]
Merge branch 'update_visitor'
This brings a new update_visitor that makes it easier to traverse the
parse tree and modify parts of it as necessary. I wrote this as part of
my in-progress work to allow @cast() expansion, but I was able to apply
it to the dwarf/etc. target variable expanders and to the optimization
stages. I think the resulting code is more predictable and easier to
follow...
Conflicts:
ChangeLog (bumped my commit dates to push dates...)
Josh Stone [Wed, 11 Feb 2009 02:29:55 +0000 (18:29 -0800)]
Simplify dead_stmtexpr_remover
* staptree.h (update_visitor::require): Add a clearok parameter for
optimizing traversers to signal that they're ready for NULL back.
* elaborate.cxx (dead_stmtexpr_remover): Convert to an update_visitor.
Josh Stone [Fri, 6 Feb 2009 04:04:56 +0000 (20:04 -0800)]
Expand probe variables without a deep copy
* tapsets.cxx (var_expanding_copy_visitor): This struct becomes
var_expanding_visitor and inherits from update_visitor instead of
deep_copy_visitor. Each of the probe-type variants of this are also no
longer copiers.
Josh Stone [Fri, 6 Feb 2009 04:02:35 +0000 (20:02 -0800)]
Create update_visitor for modifying trees
* staptree.h (update_visitor): A new visitor to make it easier to
rewrite parts of a probe or function without making a full copy.
* staptree.cxx (update_visitor::*): Each child is recursed with a
require() call, and then the parent returns itself with provide().
* staptree.h (deep_copy_visitor): Inherit from update_visitor to get
the recursive descent while updating nodes.
* staptree.cxx (deep_copy_visitor::*): Use the implicit copy
constructors to copy all fields, then defer to update_visitor for the
recursion. Referents are still cleared from the copies of symbols and
function calls.
Josh Stone [Sat, 7 Feb 2009 23:42:56 +0000 (15:42 -0800)]
Clean up the autoconf caching
This makes the stapconf caching process quite a bit more transparent.
The options are now cached in a header file as #defines, and this header
file is a normal build dependency instead of calling so many make
$(shell ...) commands.
* buildrun.cxx (compile_pass): Pull in autoconf options in a header
of #defines rather than -DXXX, and make that header a build dependency.
* buildrun.cxx (output_autoconf): New function to consolidate the
computation of each autoconf test.
* cache.cxx (add_to_cache, get_from_cache, clean_cache): Start treating
the stapconf header as a first-class cached item.
* cache.h: Move definitions of things only needed in cache.cxx
* hash.cxx (find_stapconf_hash): Generate stapconf_name as a .h now.
* main.cxx (main): Default the stapconf_name based on getpid().
Josh Stone [Fri, 6 Feb 2009 22:13:51 +0000 (14:13 -0800)]
Save kernel autoconf options in a cache file
We're getting enough autoconf tests now that it's a significant chunk of
the build time. Adding this cache shaves several seconds off for me.
* hash.cxx (find_hash): Compute a separate script-independent hash
for caching autoconf values, saved in session.stapconf_path.
* buildrun.cxx (compile_pass): Tweak the Makefile to read/save
the autoconf values in the cache directory
git://sourceware.org / systemtap.git / log