Jonathan Lebon [Wed, 23 Apr 2014 15:45:12 +0000 (11:45 -0400)]
setup_note_probe_entry(): strengthen note checks
In dwflpp::iterate_over_notes(), we call back to
sdt_query::setup_note_probe_entry() for every note entry found,
regardless of section name or note name, which is fine.
However, on the callback side in setup_note_probe_entry(), we never
actually check that the section name or note name is correct; we only
check that the note entry type was what we expected.
This means that it could have been possible for setup_note_probe_entry()
to try to blindly parse data from a note entry which was not even a
stapsdt note, which could be dangerous.
This patch adds explicit checks that the section name and the note name
are what we expect.
Jonathan Lebon [Thu, 8 May 2014 19:16:36 +0000 (15:16 -0400)]
callee.exp: simplify shlib testing by using -rpath
We previously started stap separately from the target process because we
needed to set the LD_LIBRARY_PATH variable for it to run properly.
However, if we use the linker option -rpath to add the current directory
to the library path (as is done also in unprivileged_myproc.exp), this
is no longer necessary, thus greatly simplifying the testcase.
William Cohen [Tue, 6 May 2014 20:01:54 +0000 (16:01 -0400)]
Flip condition so proper default picked for STAP_NOP in testsuite/sys/sdt.h
A number of the uprobes code failed to build on aarch64 because the
define for STAP_NOP would default to the unusual "nop 0". The test
has been flipped around so the default is usual "nop" if there is
not something explict.
David Smith [Mon, 5 May 2014 21:25:25 +0000 (16:25 -0500)]
Fix more compile error when we don't have a dwarf unwinder.
* runtime/linux/runtime.h: Fix compilation on systems without
STP_USE_DWARF_UNWINDER defined.
* runtime/unwind/unwind.h: For systems without STP_USE_DWARF_UNWINDER
defined, just define a dummy unwind_context structure along with the
real unwind_cache structure.
David Smith [Mon, 5 May 2014 20:46:40 +0000 (15:46 -0500)]
Fix compile error when we don't have a dwarf unwinder in _stp_tack_kernel_print
* runtime/stack.c (_stp_stack_kernel_print): Use 'c->kregs' instead of
nonexistent 'regs' variable. This code is only compiled when
STP_USE_DWARF_UNWINDER isn't defined.
beginnner's guide configury: compatibility with older publican
Older publican doesn't support the --pdftool=fop option. It's too
much hassle to autoautoconf this (considering the existing fop-related
conditionals at the top level configure.ac), so instead here we try
publican with and then without the --pdftool=fop option.
Stan Cox [Mon, 5 May 2014 14:24:20 +0000 (10:24 -0400)]
Add pyparsing to dtrace
* dtrace.in: pylint cleanups.
(_HeaderCreator): Moved from _provider.
(_PypProvider): New. The pyparsing parser.
(_ReProvider): Moved from _provider. The regexp parser.
(main): Add pyparsing awareness.
Jonathan Lebon [Fri, 2 May 2014 14:19:06 +0000 (10:19 -0400)]
PR16894: new wordexp.exp to check -c COMMAND handling
This simple testcase checks that invalid -c COMMANDs for unspecified
process probes are properly handled (e.g. prior to commit eb94071, we
segfaulted).
Jonathan Lebon [Fri, 2 May 2014 13:43:07 +0000 (09:43 -0400)]
PR16894: give better errors re. -c commands
This patch allows SystemTap to make the distinction when reporting an
error between no -c command given, and a given but invalid -c command.
- man/stapprobes.3stap: introduce 'unspecified' verbiage and clear up
restrictions on unspecified process probes
- session.cxx: cmd_file() now throws errors upon wordexp() failures
- tapsets.cxx: (1) handle possibility of error from cmd_file() and chain
with own error if it occurs
(2) separately handle no -c command / empty file
(3) introduce 'unspecified' verbiage in error messages
and point to [man stapprobes]
- tapset-perfmon.cxx: ditto
Jonathan Lebon [Tue, 29 Apr 2014 18:32:48 +0000 (14:32 -0400)]
pyexample.stp: split into py2example.stp and py3example.stp
In order to be compatible on systems with only python2 installed (or
only python3 installed), we split the pyexample.stp script into two
versions.
We also add a test_support line in the meta files so that check.exp
marks them as untested if either/both python versions are not present.
In the tapsets, we make py2/3 aliases that the scripts then use, but
also create general ones that refer to both the 2 and 3 variants.
The python3 version requires -g --suppress-time-limits, otherwise it's
very likely that a 'overhead exceeded' ERROR.
- py2example.stp: python 2 version of the script
- py2example.meta: meta file for python 2 version, with test_support
check for python 2 specific SDT markers
- py3example.stp: python 3 version of the script
- py3example.meta: meta file for python 3 version, with test_support
check for python 3 specific SDT markers
- tapset/python2.stp: make python2 specific aliases and alias the
general ones to that
- tapset/python3.stp: make python3 specific aliases and alias the
general ones to that
Lukas Berk [Tue, 29 Apr 2014 20:17:36 +0000 (16:17 -0400)]
Fix typo for suppress-time-limits in runtime headers
*man/stap.1 - update man page to properly list macro's
and polarity of statement
*runtime/common_probe_context.h - fix STAP_SUPPRESS_TIME_LIMITS_ENABLE typo
*runtime/runtime_defines.h - ditto
David Smith [Tue, 29 Apr 2014 15:54:27 +0000 (10:54 -0500)]
PR16716 partial fix: Fix types in syscall.{dup,dup2,dup3}.
* tapset/linux/syscalls.stp: Fixed types in syscall.{dup,dup2,dup3}.
* tapset/linux/aux_syscalls.stp (_dup3_flag_str): Just use the open mode
flags list.
* testsuite/systemtap.syscall/dup.c: Add more tests.
Jonathan Lebon [Thu, 24 Apr 2014 16:53:06 +0000 (12:53 -0400)]
new helper script scripts/update-copyrights
This script looks at all the tracked files in the tree that are
copyrighted by <company> and updates the copyright year if they've been
modified this year by a user at <domain>.
PR16406: fix build-id false mismatch for userspace-program vs. kernel-module
The translate.cxx-emitted _stp_module array has two name fields, .name
and .path, which were ambiguous as to whether each was a kernel module
or a userspace executable. The .name string was just the basename,
and it was used in the near-startup-time _stp_module_check(). If the
userspace program matched a kernel module, bangorama (a false build-id
mismatch error at startup) .. unless --all-modules was given, in
which case the kernel modules won the duplication race.
The correction has a couple of parts. First, the _stp_module .name is
made the same as the fully-/-qualified .path for userspace programs.
Second, _stp_module_check checks all kernel+module bits it knows
about, not just the first one. Hand-tested with a variety of runs,
and with the *myproc.exp test, which is now forced to try to conflict.
* translate.cxx (dump_unwindsym_ctx): Make userspace _stp_module->name's
fully-/-qualified.
* runtime/sym.c (_stp_module_check): Check all and only kernel-space
build-ids. Filter by _stp_module->name.
(stp_kmodule_check, stp_usermodule_check): WARN_ON wrong-polarity
incoming module/path name.
* testsuite/.../unprivileged_myproc.exp: Run 'modprobe loop'
Jonathan Lebon [Mon, 28 Apr 2014 21:00:39 +0000 (17:00 -0400)]
unprivileged_myproc.exp: only KFAIL .callee(string)
This is a followup to the followup commit 9d4241d. The .callees and
.callees(number) probes will always work because they will match ibar().
Only the .callee(string), which is turned to .callee("tbar"), should be
KFAILed, since it will definitely fail for GCC < 4.7.
Jonathan Lebon [Mon, 28 Apr 2014 20:24:32 +0000 (16:24 -0400)]
unprivileged_myproc.exp: adjust loop.c
The process("./loop").function("ibar").inline probe was failing in this
test because of a bug in GCC (RHBZ1092144). In a nutshell, GCC unrolls
the loop once, resulting in ibar() being called twice: once outside the
loop and once inside. However, only the former gets a corresponding
inlined_subroutine DIE. As a result, the SystemTap probe only fires once
at startup rather than at every iteration.
This patch takes out the if-expression in the loop so that GCC doesn't
need to do any unrolling and we end up with two inlined_subroutine DIEs.
syscall testsuite test.tcl: use staprun -R for reused module
It's been occasionally observed that a single syscall test case can
leave the [nd_]syscall.ko module loaded, which blocks further testing.
staprun -R can rename the .ko, to avoid the chain failure.
runtime rhel6: avoid kernel crash with buildid checks for process(PID#) probes
Crash observed on rhel6 (utrace -> process(NUM).statement(ADDR).absolute probes)
in unprivileged_myproc.exp test case.
* runtime/linux/uprobes-common.c (stap_uprobe_change_plus): Don't try to check
process against _stp_module entry, if we don't even have a process pathname.
* runtime/sym.c (_stp_usermodule_check): WARN_ON incoming null pathname.
Josh Stone [Sat, 26 Apr 2014 00:17:03 +0000 (17:17 -0700)]
tapset: Deal with missing fs in i386/register.stp
Older kernels didn't have fs in pt_regs, so the following _reg_offsets
were incorrect. Make fs conditional on stapconf, and use a counter to
more easily keep track of the differences.
Josh Stone [Sat, 26 Apr 2014 00:12:18 +0000 (17:12 -0700)]
runtime: Fix synthesized regs on ix86
The ix86 register names and offsets in the inline asm of
arch_unw_init_frame_info are now fixed, including stapconf to deal with
fs/xfs/gs changes over time.
x86_64 is updated to match the same style of access.
Josh Stone [Fri, 25 Apr 2014 22:25:10 +0000 (15:25 -0700)]
runtime: Initialize _stp_module_self from THIS_MODULE
By iterating the sections of THIS_MODULE directly, rather than from
STP_RELOCATION messages, we can more safely contain the eh_frame length
determination. As an upper bound, the length can be no more than the
distance to the next section in memory. Then when we walk fde records,
we can sanity check that the offsets make sense.
syscalls tapset: adapt to absence of uselib(2) syscall
LKML commit 69369a70 made it possible to configure a kernel without
uselib(2) support. Mark these tapset aliases optional so syscall.*
type probing works on !CONFIG_USELIB kernels.
PR6961 cont'd: add a terminating 0x00000000 word to module .ko .eh_frame
This is necessary because now we parse our own module's .eh_frame
lightly at startup time, and must reliably find the end of the
entries. (We don't get the crtend.o goodies from userspace.)
We also reject 8-byte extended-length cases, should they ever come up.
* session.* (op_create_auxiliary): Make possible to designate aux files
as trailers (coming in after the main generated .o file) instead of before.
* buildrun.cxx (compile_pass): Add s.auxiliary_output trailers.
* translate.cxx (emit_symbol_data_done): T-800 returns from the future.
* runtime/sym.c (_stp_kmodule_update_address): Reject 8-byte extended-length
fields in .eh_frame.
Jonathan Lebon [Fri, 25 Apr 2014 19:00:07 +0000 (15:00 -0400)]
statement.exp: adapt for RHEL5
In GCC < 4.4, the decl_line is the line holding the opening brace, not the
line with the identifier. Since the decl_line is the basis for relative
line number statement probes, this discrepancy was causing statement.exp
to have some RELATIVE subtest failures.
Add another empty line so that main@statement.c+4 always falls on an
empty line, regardless of which is the decl_line.
Jonathan Lebon [Fri, 25 Apr 2014 16:01:52 +0000 (12:01 -0400)]
testsuite: adapt to RHEL5
- callee.exp: set as untested if GCC or elfutils too old
- dump_functions.exp: RHEL5 exec doesn't support -ignorestderr
- dump_probe_aliases.exp: ditto
Jonathan Lebon [Fri, 25 Apr 2014 15:53:12 +0000 (11:53 -0400)]
lib/systemtap.exp: get better GCC and elfutils version info
Rather than having the global GCC_Version hold the whole
"gcc --version | head -n 1" string, create a new GCC_FullVersion for
that and make GCC_Version only hold the raw version (e.g. "4.1.2").
This will be useful later on for version comparison.
Create new ELF_Version which holds the elfutils library version against
which SystemTap was compiled.
Jonathan Lebon [Wed, 23 Apr 2014 19:48:37 +0000 (15:48 -0400)]
pr16806.exp: new testcase
- pr16806.exp: new testcase to verify proper tracepoint unregistration
and utrace shutdown.
- loop.c: don't call usleep() if NOSLEEP is defined. This is used by
pr16806.exp, which requires it to make conditions more racy.
- unprivileged_myproc.exp: simplify path to C file.
- unprivileged_probes.exp: ditto.
Josh Stone [Tue, 22 Apr 2014 16:07:42 +0000 (09:07 -0700)]
PR16844: Initial adaptation for kernel 3.15 tracepoints
This hides the tracepoint version adaptations in stp_tracepoint.h. For
older kernel versions, that header is sufficient. With 3.15 we have to
do extra bookkeeping ourselves, so it pulls in stp_tracepoints.c, which
is borrowed almost verbatim from lttng. It seems to work well, but we
can still decide if we want to take a different approach.
David Smith [Tue, 22 Apr 2014 15:32:05 +0000 (10:32 -0500)]
PR16716 partial fix: Better types in 'syscall.{access,faccessat}'.
* tapset/linux/syscalls.stp: Fix 'mode' variable type in
'syscall.{access,faccessat}'.
* tapset/linux/aux_syscall.stp: Convert to use _stp_lookup_or_str().
* testsuite/systemtap.syscall/access.c (main): Add tests.
David Smith [Tue, 22 Apr 2014 13:42:59 +0000 (08:42 -0500)]
PR16716 partial fix: Better types in 'syscall.{swapon,syslog}'.
* tapset/linux/syscalls2.stp: Fix types in 'syscall.syslog' and
'syscall.swapon'. In 'syscall.swapon', decode the flags in the new
'swapflags' variable.
* tapset/linux/nd_syscalls2.stp: In 'nd_syscall.swapon', decode the flags
in the new 'swapflags' variable.
* tapset/linux/aux_syscalls.stp (_swapon_flags_str): New function.
* tapset/uconversions.stp (user_string_n2_quoted): If we're in a compat
task, when printing the pointer value as a number, don't expand it to
64-bits.
* testsuite/systemtap.syscall/swap.c: Added more tests.
* testsuite/systemtap.syscall/syslog.c: New test case.
* testsuite/buildok/syscalls2-detailed.stp: Added new 'swapflags' variable.
* testsuite/buildok/nd_syscalls2-detailed.stp: Ditto.
Stan Cox [Tue, 22 Apr 2014 13:37:16 +0000 (09:37 -0400)]
Add python support tapset example.
* systemtap.examples/general/tapset/(python2.stp,python3.stp,python.stpm): Python support tapset
* systemtap.examples/general/(pyexample.meta,pyexample.stp,pyexample.py): Use it.
David Smith [Mon, 21 Apr 2014 18:43:33 +0000 (13:43 -0500)]
PR16716 partial fix: Better types in 'syscall.{getpriority,setpriority}'.
* tapset/linux/syscalls.stp: Fix types in 'syscall.getpriority'.
* tapset/linux/syscalls2.stp: Fix types in 'syscall.setpriority'.
* tapset/linux/aux_syscalls.stp (_priority_which_str): Convert to use
_stp_lookup_str().
* testsuite/systemtap.syscall/getpriority.c: New test case.
* testsuite/systemtap.syscall/setpriority.c: Ditto.
Josh Stone [Fri, 18 Apr 2014 01:14:06 +0000 (18:14 -0700)]
tapset: mark _sched_policy_str() as pure and :string
This was causing issues in any script that pulled in aux_syscalls, but
didn't use _sched_policy_str(). Since it wasn't pure, it couldn't be
elided, and since it wasn't explicitly declared :string, there was no
type deduction to define its STAP_RETVALUE.