]>
sourceware.org Git - lvm2.git/log
Alasdair Kergon [Fri, 27 Jun 2008 15:18:31 +0000 (15:18 +0000)]
Fix up cache for PVs without mdas after consistent VG metadata is processed.
Alasdair Kergon [Thu, 26 Jun 2008 23:05:11 +0000 (23:05 +0000)]
Update validation of safe mirror log type conversions in lvconvert. (brassow)
Alasdair Kergon [Thu, 26 Jun 2008 21:38:58 +0000 (21:38 +0000)]
Fix lvconvert to disallow snapshot and mirror combinations. (mpatocka)
Alasdair Kergon [Wed, 25 Jun 2008 19:52:52 +0000 (19:52 +0000)]
Underline longer report help text headings.
Alasdair Kergon [Wed, 25 Jun 2008 16:52:27 +0000 (16:52 +0000)]
Fix reporting of LV fields alongside unallocated PV segments.
Dave Wysochanski [Wed, 25 Jun 2008 16:51:26 +0000 (16:51 +0000)]
Test script cleanup.
Alasdair Kergon [Wed, 25 Jun 2008 14:44:00 +0000 (14:44 +0000)]
post-release
Alasdair Kergon [Wed, 25 Jun 2008 14:24:17 +0000 (14:24 +0000)]
pre-commit
Alasdair Kergon [Wed, 25 Jun 2008 14:10:33 +0000 (14:10 +0000)]
Align struct memblock in dbg_malloc for sparc.
Alasdair Kergon [Wed, 25 Jun 2008 00:10:36 +0000 (00:10 +0000)]
Cope with missing field values.
Alasdair Kergon [Tue, 24 Jun 2008 22:53:48 +0000 (22:53 +0000)]
Add --rows to dmsetup.
Alasdair Kergon [Tue, 24 Jun 2008 22:48:53 +0000 (22:48 +0000)]
Add --rows to reports.
Alasdair Kergon [Tue, 24 Jun 2008 21:21:04 +0000 (21:21 +0000)]
Add --unquoted to reporting tools.
Alasdair Kergon [Tue, 24 Jun 2008 20:16:47 +0000 (20:16 +0000)]
dmsetup --unquoted
Dave Wysochanski [Tue, 24 Jun 2008 20:10:32 +0000 (20:10 +0000)]
Refactor pv_create() to take cmd_context - no functional change.
Dave Wysochanski [Mon, 23 Jun 2008 19:26:21 +0000 (19:26 +0000)]
Suppress invalid 'sb_offset' compiler warning (FC8) with uninitialized_var().
device/dev-md.c:61: warning: ‘sb_offset’ may be used uninitialized in this function
Dave Wysochanski [Mon, 23 Jun 2008 19:04:34 +0000 (19:04 +0000)]
Add uninitialized_var macro to suppress invalid compiler warnings.
One such warning is seen on fedora9 gcc compiler:
/metadata.c:1923: warning: 'results' may be used uninitialized in this function
Dave Wysochanski [Mon, 23 Jun 2008 14:54:50 +0000 (14:54 +0000)]
Suppress 'sb_offset' compiler warning by using enum for md superblock versions.
The warning is bogus and is only seen on certain versions of gcc.
However using the enum does seem to clarify the intent of the code - only
3 possible md minor superblock versions.
Related compiler warning:
device/dev-md.c:53: warning: 'sb_offset' may be used uninitialized in this function
Jim Meyering [Mon, 23 Jun 2008 09:27:45 +0000 (09:27 +0000)]
lvm2_run: don't return uninitialized for _memlock_inc or _memlock_dec
* tools/lvmcmdlib.c: Initialize "ret". Also avoid useless string
comparison.
Jim Meyering [Mon, 23 Jun 2008 09:25:57 +0000 (09:25 +0000)]
configure: regenerate
Jim Meyering [Mon, 23 Jun 2008 09:25:08 +0000 (09:25 +0000)]
avoid link failure when configuring without --enable-cmdlib
* configure.in (LVM2CMD_LIB): Define if --enable-cmdlib.
* dmeventd/mirror/Makefile.in (CLDFLAGS): Use $(LVM2CMD_LIB) rather
than hard-coding -llvm2cmd.
* dmeventd/snapshot/Makefile.in (CLDFLAGS): Likewise.
Jim Meyering [Mon, 23 Jun 2008 09:23:48 +0000 (09:23 +0000)]
avoid link failure when configuring without --enable-readline
* configure.in: Define READLINE_SUPPORT not when processing
--enable-readline or --disable-readline, but rather only after
determining that readline support is desired and the readline
library is available/usable.
Christine Caulfield [Fri, 20 Jun 2008 12:46:21 +0000 (12:46 +0000)]
Make clvmd return immediately if other nodes are down in an openais cluster.
Christine Caulfield [Fri, 20 Jun 2008 10:58:28 +0000 (10:58 +0000)]
Make clvmd return immediately if other nodes are down in a gulm cluster.
bz#447799
Zdenek Kabelac [Wed, 18 Jun 2008 11:32:14 +0000 (11:32 +0000)]
Improve/Fix read ahead 'auto' calculation for stripe_size
Fix lvchange output for -r auto setting if auto is already set
Add testcase for read ahead
Jim Meyering [Wed, 18 Jun 2008 10:19:25 +0000 (10:19 +0000)]
avoid compiler warning about cast in OFFSET_OF macro
* dmsetup/dmsetup.c (OFFSET_OF): Use an equivalent definition
that does not cast a pointer value to a narrower type.
Dave Wysochanski [Tue, 17 Jun 2008 14:14:00 +0000 (14:14 +0000)]
Fix identifier 'error_message_produced' used ambiguously.
Related compiler warning:
log/log.c:242: warning: declaration of 'error_message_produced' shadows a global declaration
../include/log.h:98: warning: shadowed declaration is here
Dave Wysochanski [Mon, 16 Jun 2008 14:16:02 +0000 (14:16 +0000)]
Trivial fix to lvcreate man page for --mirrorlog option.
Jim Meyering [Fri, 13 Jun 2008 14:37:18 +0000 (14:37 +0000)]
Begin syncing configure.in for merge/unification with device-mapper.
Jim Meyering [Fri, 13 Jun 2008 12:15:55 +0000 (12:15 +0000)]
Don't deref uninitialized log_lv upon failed mirror addition.
* mirror.c (add_mirror_images): Ensure that log_lv is initialized.
Christine Caulfield [Fri, 13 Jun 2008 07:44:14 +0000 (07:44 +0000)]
Don't call openlog for every invocation of debuglog.
Patch from Masatake YAMATO
Alasdair Kergon [Thu, 12 Jun 2008 13:24:02 +0000 (13:24 +0000)]
Add --force to lvextend and lvresize.
Milan Broz [Thu, 12 Jun 2008 11:49:46 +0000 (11:49 +0000)]
Fix vgchange to not activate mirror leg and log volumes directly.
Jim Meyering [Thu, 12 Jun 2008 09:48:45 +0000 (09:48 +0000)]
Makefile.in: correct distclean rule
* Makefile.in (SUBDIRS): Remove long-unused test/* names.
(SUBDIRS) [distclean]: Append "test".
Discovered with Zdeněk Kabeláč.
Jim Meyering [Wed, 11 Jun 2008 15:02:52 +0000 (15:02 +0000)]
break (rather than return) so we have only one point of return
* tools/toollib.c (process_each_segment_in_lv): Upon sigint_caught,
break rather than returning ret_max. No semantic change.
Zdenek Kabelac [Wed, 11 Jun 2008 13:14:41 +0000 (13:14 +0000)]
copy vgid only when volume group is present in import_pool_pv
Alasdair Kergon [Wed, 11 Jun 2008 12:14:41 +0000 (12:14 +0000)]
post-release
Alasdair Kergon [Wed, 11 Jun 2008 12:08:19 +0000 (12:08 +0000)]
pre-release
Alasdair Kergon [Wed, 11 Jun 2008 11:02:05 +0000 (11:02 +0000)]
Fix tracking of validity of PVs with no mdas in lvmcache.
Dave Wysochanski [Tue, 10 Jun 2008 20:07:04 +0000 (20:07 +0000)]
Fix return values for reporting commands when run with no PVs, LVs, or VGs.
The new error checking code caught some commands that were returning '0' as
an exit status for success. This is incorrect and resulted in a benign error
message displayed (see below). As of today, all commands should return a
value defined in lib/commands/errors.h (1-5). This results in an exit code of
0 on success, or > 0 on failure (as stated in the lvm.8 man page).
Before change:
1. Make sure no PVs are on the system
2. Run 'pvs'
Command failed with status code 0.
After change:
<no output>
Dave Wysochanski [Tue, 10 Jun 2008 15:25:38 +0000 (15:25 +0000)]
Add ommitted unlock_vg() call when sigint_caught() during vg processing.
Specific test case:
1. pvcreate /dev/loop1; vgcreate vg1 /dev/loop1; lvcreate -L 64M -n lv1 vg1
2. vgremove vg1 (will prompt user)
3. CTRL-C
Code will exit with:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
Volume group "vg2" not removed
Command failed with status code 5.
Internal error: Volume Group vg2 was not unlocked
Device '/dev/loop1' has been left open.
After change:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
Volume group "vg2" not removed
Command failed with status code 5.
Zdenek Kabelac [Tue, 10 Jun 2008 14:55:14 +0000 (14:55 +0000)]
Fix wrong free_count on imported volume group from pool device
Fix segfault when calling pvcreate on the pool device
Alasdair Kergon [Tue, 10 Jun 2008 11:19:19 +0000 (11:19 +0000)]
Fix inverted no_flush debug message. (mpatocka)
Alasdair Kergon [Mon, 9 Jun 2008 16:22:33 +0000 (16:22 +0000)]
Fix segfault after _free_vginfo by remembering to remove vginfo from list.
Dave Wysochanski [Mon, 9 Jun 2008 15:31:58 +0000 (15:31 +0000)]
Add simple test case to repro pvs segfault with duplicate vgnames.
Alasdair Kergon [Sun, 8 Jun 2008 14:53:51 +0000 (14:53 +0000)]
bring list.h into line with lvm2
Alasdair Kergon [Sun, 8 Jun 2008 14:18:44 +0000 (14:18 +0000)]
Tweak detection of invalid fid after changes to PVs in VG in _vg_read.
Alasdair Kergon [Sun, 8 Jun 2008 11:33:15 +0000 (11:33 +0000)]
Revert assuming precommitted metadata is live when activating (unnecessary).
Alasdair Kergon [Fri, 6 Jun 2008 20:45:41 +0000 (20:45 +0000)]
.
Alasdair Kergon [Fri, 6 Jun 2008 20:44:35 +0000 (20:44 +0000)]
rename some config vars
Alasdair Kergon [Fri, 6 Jun 2008 20:33:13 +0000 (20:33 +0000)]
Bring configure.in into line with the lvm2 version.
Alasdair Kergon [Fri, 6 Jun 2008 19:32:35 +0000 (19:32 +0000)]
Drop cached metadata for disappearing VG in vgmerge.
Alasdair Kergon [Fri, 6 Jun 2008 19:28:35 +0000 (19:28 +0000)]
post-release
Alasdair Kergon [Fri, 6 Jun 2008 19:09:19 +0000 (19:09 +0000)]
pre-release
Alasdair Kergon [Fri, 6 Jun 2008 19:07:47 +0000 (19:07 +0000)]
switch to single quotes rather than double for nameprefixes
Alasdair Kergon [Fri, 6 Jun 2008 18:53:26 +0000 (18:53 +0000)]
nameprefixes
Alasdair Kergon [Fri, 6 Jun 2008 18:53:08 +0000 (18:53 +0000)]
change --prefixes to --nameprefixes
Alasdair Kergon [Fri, 6 Jun 2008 17:36:19 +0000 (17:36 +0000)]
back out unnecessary changes for this release
Alasdair Kergon [Fri, 6 Jun 2008 17:24:28 +0000 (17:24 +0000)]
pre-release
Alasdair Kergon [Fri, 6 Jun 2008 16:37:51 +0000 (16:37 +0000)]
cleaner LCK_LV decoding
Alasdair Kergon [Fri, 6 Jun 2008 16:13:35 +0000 (16:13 +0000)]
cache dropping needs to use old name not new
rename variable to reduce confusion
Jim Meyering [Fri, 6 Jun 2008 13:48:57 +0000 (13:48 +0000)]
* lvm-utils.sh (init_root_dir_): Correct a diagnostic.
Author: Jim Meyering <meyering@redhat.com>
Alasdair Kergon [Fri, 6 Jun 2008 13:04:44 +0000 (13:04 +0000)]
Drop cached metadata when renaming a VG.
Alasdair Kergon [Fri, 6 Jun 2008 12:43:40 +0000 (12:43 +0000)]
fix _free_vginfo not to remove a ref to a *different* vginfo from the vgid cache
Alasdair Kergon [Fri, 6 Jun 2008 11:12:50 +0000 (11:12 +0000)]
cope with volatile vginfo in vg_read
Alasdair Kergon [Fri, 6 Jun 2008 09:48:04 +0000 (09:48 +0000)]
Allow for vginfo changing during _vg_read.
Alasdair Kergon [Thu, 5 Jun 2008 19:10:35 +0000 (19:10 +0000)]
Initialise params buffer to empty string in _emit_segment.
Alasdair Kergon [Thu, 5 Jun 2008 14:24:28 +0000 (14:24 +0000)]
Decode numbers in clvmd debugging output.
Alasdair Kergon [Thu, 5 Jun 2008 13:38:30 +0000 (13:38 +0000)]
Add missing deactivation after activation failure in lvcreate -Zy.
Alasdair Kergon [Thu, 5 Jun 2008 13:06:39 +0000 (13:06 +0000)]
When activating, if precommitted metadata is still cached, assume it's live.
Alasdair Kergon [Thu, 5 Jun 2008 12:45:55 +0000 (12:45 +0000)]
When removing LV symlinks, skip any where the VG name is not determined.
Alasdair Kergon [Tue, 3 Jun 2008 17:56:54 +0000 (17:56 +0000)]
Drop metadata cache if update fails in vg_revert or vg_commit.
Alasdair Kergon [Tue, 3 Jun 2008 17:51:04 +0000 (17:51 +0000)]
Correct config file line numbers in messages when parsing comments. (kabi)
Alasdair Kergon [Tue, 3 Jun 2008 17:48:13 +0000 (17:48 +0000)]
suppress warning on silent failure with ECMD_PROCESSED
Dave Wysochanski [Mon, 2 Jun 2008 15:54:32 +0000 (15:54 +0000)]
Trivial fix to lvchange man pg for consistency.
Alasdair Kergon [Fri, 30 May 2008 15:27:44 +0000 (15:27 +0000)]
In script-processing mode, stop if any command fails.
Warn if command exits with non-zero status code without a prior log_error.
Alasdair Kergon [Wed, 28 May 2008 23:12:45 +0000 (23:12 +0000)]
fix setpriority int error
Alasdair Kergon [Wed, 28 May 2008 22:27:47 +0000 (22:27 +0000)]
Avoid spurious duplicate VG messages referring to VGs that are gone.
(untested)
Alasdair Kergon [Wed, 21 May 2008 16:14:46 +0000 (16:14 +0000)]
Skip add_dev_node when ioctls disabled.
Make dm_hash_iter safe against deletion.
Accept a NULL pointer to dm_free silently.
Alasdair Kergon [Wed, 21 May 2008 14:10:11 +0000 (14:10 +0000)]
Temporarily disable dmeventd mirror monitoring during lvchange --resync.
Alasdair Kergon [Mon, 19 May 2008 20:06:34 +0000 (20:06 +0000)]
revert accidental checkin
Alasdair Kergon [Mon, 19 May 2008 19:49:56 +0000 (19:49 +0000)]
Refactor some vginfo manipulation code.
Alasdair Kergon [Fri, 9 May 2008 19:26:58 +0000 (19:26 +0000)]
more cleanup
Alasdair Kergon [Fri, 9 May 2008 18:45:15 +0000 (18:45 +0000)]
More P_ and V_ lock cleanup.
Alasdair Kergon [Fri, 9 May 2008 15:13:20 +0000 (15:13 +0000)]
Add missing mutex around clvmd lvmcache_drop_metadata library call.
Christine Caulfield [Fri, 9 May 2008 09:59:39 +0000 (09:59 +0000)]
Fix uninitialised mutex in clvmd if all daemons are not running at startup.
Thanks to Mark Hlawatschek for pointing this out.
Christine Caulfield [Fri, 9 May 2008 07:20:04 +0000 (07:20 +0000)]
Make clvmd-cman use a hash rather than an array for node updown info.
This will allow it to cope with very large nodeids such as those
generated by clusters using cman_tool join -X
Alasdair Kergon [Thu, 8 May 2008 18:35:58 +0000 (18:35 +0000)]
Avoid unnecessary unlock attempts with LCK_CACHE pseudo-locks.
Alasdair Kergon [Thu, 8 May 2008 18:28:27 +0000 (18:28 +0000)]
When asked to drop cached committed VG metadata, invalidate cached PV labels.
Alasdair Kergon [Thu, 8 May 2008 18:06:58 +0000 (18:06 +0000)]
Drop metadata cache before writing precommitted metadata instead of after.
Alasdair Kergon [Thu, 8 May 2008 18:00:47 +0000 (18:00 +0000)]
remove unused lvmcache_drop_vg prototype
Alasdair Kergon [Wed, 30 Apr 2008 14:34:02 +0000 (14:34 +0000)]
Don't touch /dev in vgrename if activation is disabled.
Alasdair Kergon [Tue, 29 Apr 2008 16:11:28 +0000 (16:11 +0000)]
post-release - reinstate incomplete enhancements
Alasdair Kergon [Tue, 29 Apr 2008 15:58:25 +0000 (15:58 +0000)]
pre-release (bug fixes only - enhancements excluded)
Zdenek Kabelac [Tue, 29 Apr 2008 15:25:28 +0000 (15:25 +0000)]
fixing fsadm usage with older blockdev,blkid,readline tools
fixing lvresize extension code path where size was not set for fsadm
Christine Caulfield [Tue, 29 Apr 2008 08:55:20 +0000 (08:55 +0000)]
. remove_lock_wait.diff remove the definition of "struct lock_wait",
which is not used since the switch away from async version saLck
. num_nodes should equal to member_list_entries, i.e.
joined_list_entires is 0 when a node leaves the group.
Thanks to Xinwei Hu for the patch.
Christine Caulfield [Mon, 28 Apr 2008 08:57:11 +0000 (08:57 +0000)]
The attached patch is a try to make clvmd work correctly on openais stack.
It does 2 things.
1. The cpg_deliver_callback make a compare between target_nodeid and our_nodeid.
It turns out openais set target_nodeid to 0 sometimes. for broadcasting ? I change the behavior so that lvm will process_remote also on target_nodeid == 0
2. The joined_list passed to cpg_confchg_callback doesn't include the already exist nodes in the group, which leads to an incomplete node_hash. I simply add all other nodes in member_list to node_hash also.
Thanks to Xinwei Hu for this patch.
Alasdair Kergon [Thu, 24 Apr 2008 02:22:07 +0000 (02:22 +0000)]
Exclude VG_GLOBAL from internal concurrent VG lock counter.
(Avoids 'device left open' warning messages from vgscan etc.)
Dave Wysochanski [Wed, 23 Apr 2008 18:27:59 +0000 (18:27 +0000)]
Add test for rhbz440405 - lvconvert -m0 fails incorrectly if all PEs allocated.
Dave Wysochanski [Wed, 23 Apr 2008 14:33:06 +0000 (14:33 +0000)]
Fix vgsplit internal counting of snapshot LVs.
This page took 0.090919 seconds and 5 git commands to generate.