]> sourceware.org Git - lvm2.git/log
lvm2.git
7 years agothin: disallow creation of too big thin pools
Zdenek Kabelac [Thu, 8 Jun 2017 08:46:22 +0000 (10:46 +0200)]
thin: disallow creation of too big thin pools

When a combination of thin-pool chunk size and thin-pool data size
goes beyond addressable limit, such volume creation is directly
prohibited.

Maximum usable thin-pool size is calculated with use of maximal support
metadata size (even when it's created smaller) and given chunk-size.
If the value data size is found to be too big, the command reports
error and operation fails.

Previously thin-pool was created however lots of thin-pool data LV was
not usable and this space in VG has been wasted.

7 years agocleanup: use DM limit define
Zdenek Kabelac [Mon, 5 Jun 2017 09:26:01 +0000 (11:26 +0200)]
cleanup: use DM limit define

For calculation use already defined size in libdm, which give better
estimation of maximal size of thin pool metadata.

7 years agocleanup: rename internal define
Zdenek Kabelac [Fri, 2 Jun 2017 09:18:04 +0000 (11:18 +0200)]
cleanup: rename internal define

More descriptive name of #define.

7 years agolvconvert: reject RAID conversions on inactive LVs
Heinz Mauelshagen [Wed, 7 Jun 2017 16:37:04 +0000 (18:37 +0200)]
lvconvert: reject RAID conversions on inactive LVs

Only support RAID conversions on active LVs.

If we'd accept e.g. upconverting linear -> raid1 on inactive
linear LVs, any LV flags passed to the kernel aren't properly
cleared thus errouneously passing them on every activation.

Add respective check to lv_raid_change_image_count() and
move existing one in lv_raid_convert() for better messages.

7 years agolvmdbusd: Prevent stall when update thread gets exception
Tony Asleson [Fri, 2 Jun 2017 17:29:27 +0000 (12:29 -0500)]
lvmdbusd: Prevent stall when update thread gets exception

If during the process of fetching current lvm state we experience an
exception we fail to call set_result on the queued_requests we were
processing.  When this happens those threads block forever which causes
the service to stall infinitely.  Only clear the queued_requests after
we have called set_result.

7 years agolvmdbusd: Add background command to flight recorder
Tony Asleson [Fri, 2 Jun 2017 17:25:01 +0000 (12:25 -0500)]
lvmdbusd: Add background command to flight recorder

We were not adding background tasks to flight recorder.  Add the meta
data to the flight recorder when we start the command and update the meta
data when the command is finished.  Locking was added to meta data to
prevent concurrent update and returning string representation as these can
happen in two different threads.

7 years agolvmdbusd: cmdhandler.py vg_reduce, remove extranous '--all'
Tony Asleson [Fri, 2 Jun 2017 17:22:24 +0000 (12:22 -0500)]
lvmdbusd: cmdhandler.py vg_reduce, remove extranous '--all'

vgreduce previously allowed --all and --removemissing together even though
it only actual did the remove missing.  The lvm dbus daemon was passing
--all anytime there was no entries in pv_object_paths.  This change supplies
--all if and only if we are not removing missing and the pv_object_paths
is empty.

Vgreduce has and continues to enforce the invalid combination of supplying a
device list when you specify --all or --removemissing so we do not need
to check for that invalid combination explicitly in the lvm dbus service as
it's already covered.

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1455471

7 years agolvconvert: choose direct path to desired raid level
Heinz Mauelshagen [Fri, 2 Jun 2017 12:30:57 +0000 (14:30 +0200)]
lvconvert: choose direct path to desired raid level

Remove superfluous raid5_n interim LV type from raid4 -> raid10 conversion.

Resolves: rhbz1458006

7 years agoprint warning about in-use orphans
David Teigland [Thu, 1 Jun 2017 16:10:09 +0000 (11:10 -0500)]
print warning about in-use orphans

Warn about a PV that has the in-use flag set, but appears in
the orphan VG (no VG was found referencing it.)

There are a number of conditions that could lead to this:

. The PV was created with no mdas and is used in a VG with
  other PVs (with metadata) that have not yet appeared on
  the system.  So, no VG metadata is found by lvm which
  references the in-use PV with no mdas.

. vgremove could have failed after clearing mdas but
  before clearing the in-use flag.  In this case, the
  in-use flag needs to be manually cleared on the PV.

. The PV may have damanged/unrecognized VG metadata
  that lvm could not read.

. The PV may have no mdas, and the PVs with the metadata
  may have damaged/unrecognized metadata.

7 years agodisable repairing in-use flag on orphan PVs
David Teigland [Fri, 26 May 2017 18:26:09 +0000 (13:26 -0500)]
disable repairing in-use flag on orphan PVs

A PV holding VG metadata that lvm can't understand
(e.g. damaged, checksum error, unrecognized flag)
will appear as an in-use orphan, and will be cleared
by this repair code.  Disable this repair until the
code can keep track of these problematic PVs, and
distinguish them from actual in-use orphans.

7 years agotests: longer delay
Zdenek Kabelac [Wed, 31 May 2017 11:58:19 +0000 (13:58 +0200)]
tests: longer delay

Slower sync a bit more and use bigger raid arrays to
be more sure we will catch raid being sychronized.

7 years agotests: add some extra udev waits
Zdenek Kabelac [Wed, 31 May 2017 11:23:34 +0000 (13:23 +0200)]
tests: add some extra udev waits

To get less random results on older systems with systemd (i.e. fc23)
put few extra udev wait operations to avoid any udev event collision.

7 years agotests: skip reshaping raid10
Zdenek Kabelac [Wed, 31 May 2017 10:59:53 +0000 (12:59 +0200)]
tests: skip reshaping raid10

Needs newer target  >= 1.10.1 for reshaping of raid10 LVs.

7 years agolvconvert: reject changing number of stripes on single core
Heinz Mauelshagen [Tue, 30 May 2017 17:14:32 +0000 (19:14 +0200)]
lvconvert: reject changing number of stripes on single core

Reject any stripe adding/removing reshape on raid4/5/6/10 because
of related MD kernel deadlock on single core systems until
we get a proper fix in MD.

Related: rhbz1443999

7 years agotests: missed to export lvm binary for fsadm
Zdenek Kabelac [Tue, 30 May 2017 10:59:21 +0000 (12:59 +0200)]
tests: missed to export lvm binary for fsadm

7 years agotests: drop extra debug vvvv
Zdenek Kabelac [Tue, 30 May 2017 10:58:32 +0000 (12:58 +0200)]
tests: drop extra debug vvvv

Also show output of mount so when it fails we can check the state.

7 years agotests: also check new flag with segtype
Zdenek Kabelac [Tue, 30 May 2017 14:10:22 +0000 (16:10 +0200)]
tests: also check new flag with segtype

Make sure new unknown flag is having same behavior as old unknown segtype.

7 years agoflags: improve unknown flags logic
Zdenek Kabelac [Tue, 30 May 2017 13:59:42 +0000 (15:59 +0200)]
flags: improve unknown flags logic

Use same logic as with unknown segment type - so preserve such
name fully with all flags just with UNKNOWN segment type bits.

7 years agoflags: restore same logic with MISSING
Zdenek Kabelac [Tue, 30 May 2017 14:12:45 +0000 (16:12 +0200)]
flags: restore same logic with MISSING

Since lvmetad is using 'MISSING' in status for 'another' purpose,
we need to support ATM also flag get from this place.

Until fixed better - we accept both flags - alhough lvm2 will
only print in flags.

7 years agoflags: add segtype flag support
Zdenek Kabelac [Mon, 29 May 2017 12:20:38 +0000 (14:20 +0200)]
flags: add segtype flag support

Switch METADATA_FORMAT flag usage to be stored via segtype
instead of 'status' flag which appeared to cause major
incompatibility troubles.

For backward compatiblity segtype flags are still accepted also
via 'status' bits which were used from version 2.02.169 so metadata
saved by this newer lvm2 version should still work nicely, although
new save version will no longer work on this older lvm2 version.

7 years agoflags: add read and print of segtype flag
Zdenek Kabelac [Mon, 29 May 2017 12:20:05 +0000 (14:20 +0200)]
flags: add read and print of segtype flag

Allow storing LV status bits with segment type name field.
Switching to this since this field has better support for compatibility
with older version of lvm2 - since such unknown segtype will not cause
complete invisiblity of metadata from older lvm2 code - just the
particular LV will become unusable with unknown type of segment.

7 years agocleanup: backtrace
Zdenek Kabelac [Mon, 29 May 2017 10:43:07 +0000 (12:43 +0200)]
cleanup: backtrace

Add debug backtrace.

7 years agocleanup: separate type and mask
Zdenek Kabelac [Fri, 26 May 2017 13:47:17 +0000 (15:47 +0200)]
cleanup: separate type and mask

Split misused 'enum' into 2 fields - one for type
of PV, VG, LV and other for mask.

7 years agocleanup: bad flag is internal error here
Zdenek Kabelac [Fri, 26 May 2017 13:45:37 +0000 (15:45 +0200)]
cleanup: bad flag is internal error here

Convert to internal error.

7 years agotests: wait for raid in sync
Zdenek Kabelac [Thu, 25 May 2017 13:06:57 +0000 (15:06 +0200)]
tests: wait for raid in sync

Lvchange needs synchronized raid.

7 years agotest: Fix dbus testing using testsuite
Marian Csontos [Fri, 26 May 2017 13:34:47 +0000 (15:34 +0200)]
test: Fix dbus testing using testsuite

- Must reread all objects as PVs might be removed.
- Never consider testsuite provided PVs nested, or tearDown fails to
  remove any outstanding VGs on them.

7 years agotest: Use _pv suffix for nested devices
Marian Csontos [Fri, 26 May 2017 06:33:39 +0000 (08:33 +0200)]
test: Use _pv suffix for nested devices

Testsuite uses global_filter to accept only test devices with
suffix matching /_pv[0-9_]*$/ set by generate_config in aux.sh.

7 years agospec: Enable notify-dbus in builds with dbus
Marian Csontos [Fri, 26 May 2017 05:40:09 +0000 (07:40 +0200)]
spec: Enable notify-dbus in builds with dbus

7 years agoProper dm_snprintf return checks
Heinz Mauelshagen [Wed, 24 May 2017 12:00:44 +0000 (14:00 +0200)]
Proper dm_snprintf return checks

7 years agoFix typo
Heinz Mauelshagen [Wed, 24 May 2017 11:47:45 +0000 (13:47 +0200)]
Fix typo

7 years agoadd comment about PV in-use repair
David Teigland [Tue, 23 May 2017 21:59:46 +0000 (16:59 -0500)]
add comment about PV in-use repair

copied from commit message for
d97f1c89deb9a75452059cd62ebb20cf7d2d6bfa

7 years agoman lvmsystemid: change some wording
David Teigland [Tue, 23 May 2017 15:50:08 +0000 (10:50 -0500)]
man lvmsystemid: change some wording

Clarify the wording in a couple cases.

7 years agotests: fix test for fsadm
Zdenek Kabelac [Tue, 23 May 2017 11:59:29 +0000 (13:59 +0200)]
tests: fix test for fsadm

Avoid mountinfo
Pass 'y'  - since ATM lvresize cannot pass --yes to fsadm.

7 years agofsadm: avoid hidden --yes
Zdenek Kabelac [Tue, 23 May 2017 11:58:12 +0000 (13:58 +0200)]
fsadm: avoid hidden --yes

When 'fsadm' was running without terminal (i.e. pipe), it's been
automatically working like in '--yes'.

Detect terminal and only accept empty "" input in this mode.

7 years agoraid: Drop unnecessary/incorrect use of dm_pool_free
Alasdair G Kergon [Tue, 23 May 2017 00:51:04 +0000 (01:51 +0100)]
raid: Drop unnecessary/incorrect use of dm_pool_free

7 years agometadata: Unlock VG on more _vg_make_handle error paths
Alasdair G Kergon [Tue, 23 May 2017 00:37:14 +0000 (01:37 +0100)]
metadata: Unlock VG on more _vg_make_handle error paths

Internal error: VG lock vg0 must be requested before vg3, not after.
Internal error: 3 device(s) were left open and have been closed.

7 years agoformat_text: More internal errors if given invalid internal metadata
Alasdair G Kergon [Mon, 22 May 2017 22:30:34 +0000 (23:30 +0100)]
format_text: More internal errors if given invalid internal metadata

Three more messages to ensure each failure in out_areas() results in a
low-level message instead of sometimes just <backtrace>.

7 years agoman lvmraid: add more indirect conversion info
David Teigland [Mon, 22 May 2017 19:28:04 +0000 (14:28 -0500)]
man lvmraid: add more indirect conversion info

7 years agotests: catch some fsadm tricky paths
Zdenek Kabelac [Mon, 22 May 2017 12:43:30 +0000 (14:43 +0200)]
tests: catch some fsadm tricky paths

When user is renaming a device, we are getting into troubles.
We needs to recognize which case is actually supportable by fsadm.

7 years agofsadm: enhance detection of already mounted volumes
Zdenek Kabelac [Wed, 10 May 2017 13:32:48 +0000 (15:32 +0200)]
fsadm: enhance detection of already mounted volumes

Add more validation to catch mainly renamed devices, where
filesystem utils are not able to handle devices properly,
as they are not addressed by major:minor by rather via some
symbolic path names which can change over time via rename operation.

7 years agofsadm: always detect mounted fs with extX
Zdenek Kabelac [Mon, 22 May 2017 12:39:10 +0000 (14:39 +0200)]
fsadm: always detect mounted fs with extX

Since we add more validation to 'detect_mounted' function make sure
we always use it even with 'resize' action, so numerous validations
are not skipped.

7 years agoman lvmraid: indirect conversions
David Teigland [Thu, 18 May 2017 21:47:37 +0000 (16:47 -0500)]
man lvmraid: indirect conversions

Start documenting multi-step conversions.

Don't number examples.

7 years agolvconvert: fix logic in automatic settings of possible (raid) LV types
Heinz Mauelshagen [Thu, 18 May 2017 14:11:52 +0000 (16:11 +0200)]
lvconvert: fix logic in automatic settings of possible (raid) LV types

Commit 5fe07d3574ddce3d194f0fa57af9028348a91008 failed to set raid5 types
properly on conversions from raid6.  It always enforced raid6_ls_6
for types raid6/raid6_zr/raid6_nr/raid6_nc, thus requiring 3 conversions
instead of 2 when asking for raid5_{la,rs,ra,n}.

Related: rhbz1439403

7 years agolvmdbusd: Fix missed rename
Marian Csontos [Thu, 18 May 2017 10:52:46 +0000 (12:52 +0200)]
lvmdbusd: Fix missed rename

Introduced By: e53454d6 (2.02.169)
Related: RHBZ#1348688

7 years agolvconvert: fix indent and typo in last commit
Heinz Mauelshagen [Wed, 17 May 2017 22:43:20 +0000 (00:43 +0200)]
lvconvert: fix indent and typo in last commit

7 years agolvconvert: enhance automatic settings of possible (raid) LV types
Heinz Mauelshagen [Wed, 17 May 2017 22:18:15 +0000 (00:18 +0200)]
lvconvert: enhance automatic settings of possible (raid) LV types

Offer possible interim LV types and display their aliases
(e.g. raid5 and raid5_ls) for all conversions between
striped and any raid LVs in case user requests a type
not suitable to direct conversion.

E.g. running "lvconvert --type raid5 LV" on a striped
LV will replace raid5 aka raid5_ls (rotating parity)
with raid5_n (dedicated parity on last image).
User is asked to repeat the lvconvert command to get to the
requested LV type (raid5 aka raid5_ls in this example)
when such replacement occurs.

Resolves: rhbz1439403

7 years agolvmdbusd: Fix notify_dbus mangling config option
Marian Csontos [Wed, 17 May 2017 13:26:05 +0000 (15:26 +0200)]
lvmdbusd: Fix notify_dbus mangling config option

If config option is passed by caller, dbusd appends to the option not to
the value, and also without using delimiter.

Bug: RHBZ#1451612

7 years agotest: Fix condition
Marian Csontos [Wed, 17 May 2017 09:43:49 +0000 (11:43 +0200)]
test: Fix condition

7 years agotest: Fix skipped cleanup
Marian Csontos [Wed, 17 May 2017 09:37:29 +0000 (11:37 +0200)]
test: Fix skipped cleanup

7 years agotest: add missing yes option to lvconvert stripe removal
Heinz Mauelshagen [Tue, 16 May 2017 15:51:58 +0000 (17:51 +0200)]
test: add missing yes option to lvconvert stripe removal

7 years agotest: Fix previous commit - skip only RAID6 part
Marian Csontos [Tue, 16 May 2017 08:47:53 +0000 (10:47 +0200)]
test: Fix previous commit - skip only RAID6 part

7 years agotest: Update condition for changing RAID regionsize
Marian Csontos [Tue, 16 May 2017 08:43:34 +0000 (10:43 +0200)]
test: Update condition for changing RAID regionsize

The test is failing on F23 and F25 with 1.9.1

7 years agolvchange: allow changing properties on thin pool data lv
David Teigland [Mon, 15 May 2017 15:57:49 +0000 (10:57 -0500)]
lvchange: allow changing properties on thin pool data lv

Add an exception to not allowing lvchange to change properties
on hidden LVs.  When a thin pool data LV is a cache LV, we
need to allow changing cache properties on the tdata sublv of
the thin pool.

7 years agoconfig: keep description lines under 80
David Teigland [Fri, 12 May 2017 14:55:16 +0000 (09:55 -0500)]
config: keep description lines under 80

As far as possible, it's nice to keep the config
description lines from going over 80 columns.

7 years agolvcreate: Fix last commit for virtual sizes.
Alasdair G Kergon [Fri, 12 May 2017 12:16:10 +0000 (13:16 +0100)]
lvcreate: Fix last commit for virtual sizes.

Don't stop when extents is 0 if a virtual size parameter was supplied
instead.

7 years agolvcreate: Fix mirror percentage size calculations.
Alasdair G Kergon [Fri, 12 May 2017 01:04:05 +0000 (02:04 +0100)]
lvcreate: Fix mirror percentage size calculations.

Trap cases where the percentage calculation currently leads to an empty
LV and the message:

  Internal error: Unable to create new logical volume with no extents

Additionally convert the calculated number of extents from physical to
logical when creating a mirror using a percentage that is based on
Physical Extents.  Otherwise a command like 'lvcreate -m3 -l80%FREE'
can never leave any free space.

This brings the behaviour closer to that of lvresize.
(A further patch is needed to cover all the raid types.)

7 years agoman lvmcache: add info about metadata formats
David Teigland [Thu, 11 May 2017 15:52:59 +0000 (10:52 -0500)]
man lvmcache: add info about metadata formats

7 years agometadata: Fix metadata repair when devs still missing.
Alasdair G Kergon [Thu, 11 May 2017 01:04:50 +0000 (02:04 +0100)]
metadata: Fix metadata repair when devs still missing.

_check_reappeared_pv() incorrectly clears the MISSING_PV flags of
PVs with unknown devices.
While one caller avoids passing such PVs into the function, the other
doesn't.  Move the check inside the function so it's not forgotten.

Without this patch, if the normal VG reading code tries to repair
inconsistent metadata while there is an unknown PV, it incorrectly
considers the missing PVs no longer to be missing and produces
incorrect 'pvs' output omitting the missing PV, for example.

Easy reproducer:
Create a VG with 3 PVs pv1, pv2, pv3.
Hide pv2.
Run vgreduce --removemissing.
Reinstate the hidden PV pv2 and at the same time hide a different PV
pv3.
Run 'pvs' - incorrect output.
Run 'pvs' again - correct output.

See https://bugzilla.redhat.com/1434054

7 years agovg_read: check for NULL dev to avoid segfault
David Teigland [Tue, 9 May 2017 20:44:26 +0000 (15:44 -0500)]
vg_read: check for NULL dev to avoid segfault

There are certain situations (not fully understood)
where is_missing_pv() is false, but pv->dev is NULL,
so this adds a check for NULL pv->dev after is_missing_pv()
to avoid a segfault.

7 years agotests: better skip
Zdenek Kabelac [Fri, 21 Apr 2017 10:18:56 +0000 (12:18 +0200)]
tests: better skip

7 years agofsadm: all path define MAJOR MINOR
Zdenek Kabelac [Wed, 10 May 2017 13:23:54 +0000 (15:23 +0200)]
fsadm: all path define MAJOR MINOR

7 years agofsadm: some cleanup
Zdenek Kabelac [Wed, 10 May 2017 13:13:35 +0000 (15:13 +0200)]
fsadm: some cleanup

Put some extra "" around vars.
Indent.
Error messages with dots.

7 years agofsadm: fix test of subshell return value
Zdenek Kabelac [Tue, 9 May 2017 18:52:15 +0000 (20:52 +0200)]
fsadm: fix test of subshell return value

Subshell is not returning error code value upward thus
error results in this case were actually ignored.
Also add dots to moved error messages.

7 years agodmeventd: restore multiple warnings
Zdenek Kabelac [Wed, 19 Apr 2017 17:57:00 +0000 (19:57 +0200)]
dmeventd: restore multiple warnings

With recent updates for thin pool monitoring in version 169
we lost multiple WARNINGs to be printed in syslog, when
pool crossed  80%, 85%, 90%, 95%, 100%.

Restore this logic as we want to keep user informed more
then just once when 80% boundary is passed.

7 years agodmfilemapd: always initialise 'same' local variable (Coverity)
Bryn M. Reeves [Mon, 8 May 2017 16:10:25 +0000 (17:10 +0100)]
dmfilemapd: always initialise 'same' local variable (Coverity)

Fix a regression introduced in 70bb726 that allows a local variable
in the monitored file checking routine to be accessed before its
assignment when the file has already been unlinked.

7 years agoman lvmetad: mention repair as a reason for disabling
David Teigland [Fri, 5 May 2017 15:48:58 +0000 (10:48 -0500)]
man lvmetad: mention repair as a reason for disabling

lvconvert --repair now also disables lvmetad.

7 years agolvmdbusd: Correct PV lookups
Tony Asleson [Wed, 3 May 2017 18:06:10 +0000 (13:06 -0500)]
lvmdbusd: Correct PV lookups

When a user does a Manager.PvCreate they can specify the block device using a
device path that may be different than what lvm reports is the device path.  For
example a user could use:

/dev/disk/by-id/wwn-0x5002538500000000 instead of /dev/sdc

In this case the pvcreate will succeed, but when we query lvm we don't find the
newly created PV. We fail because it's device path is returned as /dev/sdc.  This
change re-uses an internal lookup which can accommodate this and correctly find
the newly created PV.

Corrects https://bugzilla.redhat.com/show_bug.cgi?id=1445654

7 years agolvmdbustest.py: Add PV symlink testing
Tony Asleson [Wed, 3 May 2017 19:07:13 +0000 (14:07 -0500)]
lvmdbustest.py: Add PV symlink testing

We fixed this issue once before and it's back, add a test to make
sure it never comes back again!

https://bugzilla.redhat.com/show_bug.cgi?id=1318754
https://bugzilla.redhat.com/show_bug.cgi?id=1445654

7 years agoWHATS_NEW: cache pool options
David Teigland [Fri, 5 May 2017 15:02:54 +0000 (10:02 -0500)]
WHATS_NEW: cache pool options

7 years agolvcreate: cachemode writeback and cachepolicy cleaner is invalid
David Teigland [Fri, 5 May 2017 14:59:12 +0000 (09:59 -0500)]
lvcreate: cachemode writeback and cachepolicy cleaner is invalid

Return an error if lvconvert is used to create a cache pool
with that combination.

7 years agodmfilemapd: clear filemap_monitor before calling _parse_args()
Bryn M. Reeves [Fri, 5 May 2017 10:48:54 +0000 (11:48 +0100)]
dmfilemapd: clear filemap_monitor before calling _parse_args()

If the wrong number of arguments are given, main() will attempt
to free the uninitialised pointer in fm.path.

7 years agoman lvmconfig: add descriptions for typeconfig and ignorelocal
David Teigland [Thu, 4 May 2017 19:04:10 +0000 (14:04 -0500)]
man lvmconfig: add descriptions for typeconfig and ignorelocal

7 years agoman vgexport: reference to vgimport
David Teigland [Wed, 3 May 2017 21:44:01 +0000 (16:44 -0500)]
man vgexport: reference to vgimport

7 years agoman lvm fullreport and lvpoll references
David Teigland [Wed, 3 May 2017 21:38:19 +0000 (16:38 -0500)]
man lvm fullreport and lvpoll references

Add references to lvm-fullreport(8) and lvm-lvpoll(8).

7 years agoman clvmd: mention lvmlockd is another option
David Teigland [Wed, 3 May 2017 21:26:21 +0000 (16:26 -0500)]
man clvmd: mention lvmlockd is another option

7 years agoman: reference other man pages with bold
David Teigland [Wed, 3 May 2017 21:21:01 +0000 (16:21 -0500)]
man: reference other man pages with bold

There were a handful of references to other man
pages using the standard command(N) form which were
not in bold, so they were not turned into links
in html formats.

7 years agoman lvm.conf: say how to get a description of settings
David Teigland [Wed, 3 May 2017 21:01:19 +0000 (16:01 -0500)]
man lvm.conf: say how to get a description of settings

Many will look in 'man lvm.conf' expecting to find a
description of the lvm.conf fields, which are not there.
State at the beginning how to get this (by running
lvmconfig.)

7 years agopvscan: define command as taking only -aay
David Teigland [Wed, 3 May 2017 20:46:49 +0000 (15:46 -0500)]
pvscan: define command as taking only -aay

The fact that -an and -ay are not accepted can be
stated in the command definition.

7 years agoman pvscan: add description for --activate
David Teigland [Wed, 3 May 2017 20:37:48 +0000 (15:37 -0500)]
man pvscan: add description for --activate

7 years agoman vgimport: add description for --all
David Teigland [Wed, 3 May 2017 20:19:19 +0000 (15:19 -0500)]
man vgimport: add description for --all

7 years agoman pvchange: mention one option is required
David Teigland [Wed, 3 May 2017 20:10:10 +0000 (15:10 -0500)]
man pvchange: mention one option is required

7 years agoman pvchange: add description for --all
David Teigland [Wed, 3 May 2017 20:03:14 +0000 (15:03 -0500)]
man pvchange: add description for --all

7 years agocommands: check for memory failures
David Teigland [Wed, 3 May 2017 19:46:07 +0000 (14:46 -0500)]
commands: check for memory failures

just return for now

7 years agoman lvmlockd: minor wording updates
David Teigland [Wed, 3 May 2017 19:45:33 +0000 (14:45 -0500)]
man lvmlockd: minor wording updates

7 years agopost-release
Alasdair G Kergon [Wed, 3 May 2017 10:26:58 +0000 (11:26 +0100)]
post-release

7 years agopre-release v2_02_171
Alasdair G Kergon [Wed, 3 May 2017 10:23:31 +0000 (11:23 +0100)]
pre-release

7 years agoman: generate
Alasdair G Kergon [Wed, 3 May 2017 10:23:15 +0000 (11:23 +0100)]
man: generate

7 years agocommand: avoid compiler warning
Alasdair G Kergon [Wed, 3 May 2017 10:19:43 +0000 (11:19 +0100)]
command: avoid compiler warning

man-generator.c:3243: warning: declaration of ‘stat’ shadows a global
declaration

7 years agoman: references to lvm entities
David Teigland [Tue, 2 May 2017 21:47:02 +0000 (16:47 -0500)]
man: references to lvm entities

Try to reference lvm(8) at the start of topical
man pages, and spell out acronyms early in the
text, descriptions of which can be found in lvm(8).

7 years agoman lvm: define LVM and its terms
David Teigland [Tue, 2 May 2017 20:47:02 +0000 (15:47 -0500)]
man lvm: define LVM and its terms

The lvm(8) man page never said what LVM is,
it never defined what the acronym LVM stands for,
it never spelled out other common acronyms VG, PV, LV,
and never described what they are.

This adds a very minimal definition which at least defines
the acronyms and entities, but it could obviously be
expanded on, either here or elsewhere.

7 years agoman lvmsystemid: general improvements
David Teigland [Tue, 2 May 2017 19:55:50 +0000 (14:55 -0500)]
man lvmsystemid: general improvements

Mainly improve the readability/wording.
Use "system ID" instead of system_id.
A couple small additions.

7 years agodbus: Add --yes when --setphysicalvolumesize is used
Marian Csontos [Fri, 28 Apr 2017 14:47:58 +0000 (16:47 +0200)]
dbus: Add --yes when --setphysicalvolumesize is used

7 years agocommands: fix memory debug for cmd defs
David Teigland [Fri, 28 Apr 2017 21:27:19 +0000 (16:27 -0500)]
commands: fix memory debug for cmd defs

Clean up the handling of memory used for cmd defs
so it doesn't trip up memory debugging.

Allocate memory for commands[] from libmem.

Free temporary memory used by define_commands()
at the end of the function.

Clear all the command def state in in lvm_fin().

7 years agofix running commands from a script file
David Teigland [Fri, 28 Apr 2017 21:43:42 +0000 (16:43 -0500)]
fix running commands from a script file

Using any arg with a command name in a script file
would cause the command to fail.

The name of the script file being executed was being passed
to lvm_register_commands() and define_commands(), which
prevented command defs from being defined (simple commands
were still being defined only by name which was enough for those
to still work when run trivially with no args).

7 years agoWHATS_NEW: pvcreate prompt
David Teigland [Fri, 28 Apr 2017 14:06:41 +0000 (09:06 -0500)]
WHATS_NEW: pvcreate prompt

7 years agoWHATS_NEW: pvcreate --setphysicalvolumesize
Alasdair G Kergon [Fri, 28 Apr 2017 13:34:26 +0000 (14:34 +0100)]
WHATS_NEW: pvcreate --setphysicalvolumesize

7 years agocommands: improve syntax suggestion when no command is found
David Teigland [Thu, 27 Apr 2017 19:21:01 +0000 (14:21 -0500)]
commands: improve syntax suggestion when no command is found

The logic for suggesting the nearest valid command syntax
was missing the simplest case.  If a command has only one
valid syntax, that is the one we should suggest.  (We were
suggesting nothing in this case.)

7 years agopvcreate: add prompt when setting dev size
David Teigland [Thu, 27 Apr 2017 17:13:09 +0000 (12:13 -0500)]
pvcreate: add prompt when setting dev size

If the device size does not match the size requested
by --setphysicalvolumesize, then prompt the user.

Make the pvcreate checking/prompting code handle
multiple prompts for the same device, since the
new prompt can be in addition to the existing
prompt when the PV is in a VG.

7 years agodbus: log_debug needs qualifier
Marian Csontos [Thu, 27 Apr 2017 16:12:20 +0000 (18:12 +0200)]
dbus: log_debug needs qualifier

Adding qualifier makes the only unqualified log_debug occurence
consistent with other uses in the same file.

Other possible ways to fix this:

- using `from .utils import log_debug`
- moving the line below `from . import utils` line

7 years agopvresize: Missing a message on error path.
Alasdair G Kergon [Thu, 27 Apr 2017 13:59:40 +0000 (14:59 +0100)]
pvresize: Missing a message on error path.

This page took 0.070956 seconds and 5 git commands to generate.