]> sourceware.org Git - systemtap.git/log
systemtap.git
12 years agoMake --with-elfutils work with either a source release or git checkout.
Mark Wielaard [Mon, 31 Oct 2011 13:29:46 +0000 (14:29 +0100)]
Make --with-elfutils work with either a source release or git checkout.

Add configure check to see if this is a source release, or a source
checkout. We need --enable-maintainer-mode if it isn't a source release
to make sure some additional files are generated. This makes working
against non-released elfutils git checkout a lot easier.

12 years agoIntroduce and use STP_ALLOC_SLEEP_FLAGS for use with gfp alloc functions.
Mark Wielaard [Mon, 31 Oct 2011 09:39:10 +0000 (10:39 +0100)]
Introduce and use STP_ALLOC_SLEEP_FLAGS for use with gfp alloc functions.

When in a context where we can wait we like to use normal GFP_KERNEL.
But this might trigger the oom-killer, which might kill out own stapio
process. To suppress this use __GFP_NORETRY. All _stp_[kmz]alloc_gfp
functions that are used in user context should use STP_ALLOC_SLEEP_FLAGS
if appropriate.

Note that the kernel itself may still use GFP_KERNEL. For example
__alloc_percpu() will always use GFP_KERNEL.

12 years agoAdd the pattern for label probes in libraries
Josh Stone [Fri, 28 Oct 2011 22:42:02 +0000 (15:42 -0700)]
Add the pattern for label probes in libraries

* tapsets.cxx (dwarf_derived_probe::register_patterns): Refactor so that
  all process[.library] variants get the same set of suffixes.
  (dwarf_derived_probe::register_function_and_statement_variants): Add
  the label pattern from here, just as .inline is done.

12 years agoRefactor sdt & plt pattern registration
Josh Stone [Fri, 28 Oct 2011 22:11:17 +0000 (15:11 -0700)]
Refactor sdt & plt pattern registration

This factors the sdt and plt suffixes away from the various process and
process.library prefixes.  As a result, we also gain process.plt for
probing -c commands.

* tapsets.cxx (dwarf_derived_probe::register_sdt_variants): New.
  (dwarf_derived_probe::register_plt_variants): New.
  (dwarf_derived_probe::register_patterns): Register sdt and plt for all
  process/library combinations.
* testsuite/semok/plt2.stp: Test that process.plt succeeds with -c
* testsuite/semko/plt2.stp: Test that process.plt fails without -c

12 years agoplt: Throw an appropriate error for missing $var
Josh Stone [Fri, 28 Oct 2011 21:42:23 +0000 (14:42 -0700)]
plt: Throw an appropriate error for missing $var

* tapsets.cxx (plt_expanding_visitor::visit_target_symbol): Throw a
  semantic_error for missing $var, so it may be caught and chained for
  later.  This ensures that the visitor always has a provide() too.
* testsuite/semko/plt1.stp: New, check that missing $var is an error.
* testsuite/semok/plt1.stp: New, check that $$name works, as does
  @defined on a missing $var.

12 years agoMore PR13083 fixes to avoid sleeping in the task_finder.
David Smith [Thu, 27 Oct 2011 15:24:45 +0000 (10:24 -0500)]
More PR13083 fixes to avoid sleeping in the task_finder.

* runtime/task_finder.c (__stp_get_mm_path): Call down_read_trylock()
  instead of down_read() to avoid the possibility of sleeping.
  (stap_start_task_finder): Call task_lock() to make sure a task's mm
  doesn't go away while we're looking at it.

12 years agoPR 13128: Rework of commit f2013cc91ea1dba576661d6b746ee28658c8bc51
Dave Brolley [Tue, 25 Oct 2011 16:22:20 +0000 (12:22 -0400)]
PR 13128: Rework of commit f2013cc91ea1dba576661d6b746ee28658c8bc51

Based on peer feedback:
- Compare privilege credentials as sets, not levels.
- Send privilege credentials as a ctl message at startup.
- Send startup ctl messages (tzinfo, relocations, privilege_credentials)
  on the same control channel. Ensure channel is closed properly on error.

12 years agoMake uprobe_uaddr.exp line matches unique.
Mark Wielaard [Sat, 22 Oct 2011 22:22:02 +0000 (00:22 +0200)]
Make uprobe_uaddr.exp line matches unique.

12 years agoMake sdt_misc.exp test names unique.
Mark Wielaard [Sat, 22 Oct 2011 17:15:57 +0000 (19:15 +0200)]
Make sdt_misc.exp test names unique.

12 years agoMake client.exp test names unique.
Mark Wielaard [Sat, 22 Oct 2011 14:38:39 +0000 (16:38 +0200)]
Make client.exp test names unique.

12 years agoRemove duplicate -D "foo;bar" invalid_options test from client_args.exp.
Mark Wielaard [Sat, 22 Oct 2011 14:36:20 +0000 (16:36 +0200)]
Remove duplicate -D "foo;bar" invalid_options test from client_args.exp.

12 years agoMove duplicated __is_user_regs from [nd_]syscalls.stp to aux_syscalls.stp
Mark Wielaard [Sat, 22 Oct 2011 13:52:18 +0000 (15:52 +0200)]
Move duplicated __is_user_regs from [nd_]syscalls.stp to aux_syscalls.stp

12 years agoMake labels.exp test names unique.
Mark Wielaard [Fri, 21 Oct 2011 22:34:46 +0000 (00:34 +0200)]
Make labels.exp test names unique.

12 years agoMake procfs_maxsize.exp test names unique.
Mark Wielaard [Fri, 21 Oct 2011 22:29:04 +0000 (00:29 +0200)]
Make procfs_maxsize.exp test names unique.

12 years agoMake procfs.exp test names unique.
Mark Wielaard [Fri, 21 Oct 2011 22:19:29 +0000 (00:19 +0200)]
Make procfs.exp test names unique.

12 years agoMake testsuite error_handler "target_compile" pass/fail message unique.
Mark Wielaard [Fri, 21 Oct 2011 22:10:22 +0000 (00:10 +0200)]
Make testsuite error_handler "target_compile" pass/fail message unique.

12 years agoMake uprobe_uaddr.exp testcase names unique.
Mark Wielaard [Fri, 21 Oct 2011 21:50:00 +0000 (23:50 +0200)]
Make uprobe_uaddr.exp testcase names unique.

12 years agoImprove git.library.plt testname.
Stan Cox [Fri, 21 Oct 2011 18:55:39 +0000 (14:55 -0400)]
Improve git.library.plt testname.

plt.exp: Uniquely identify the library test.

12 years agoExtract addr_of for unprivileged_[my]probes.exp once and with optional dot.
Mark Wielaard [Fri, 21 Oct 2011 14:49:02 +0000 (16:49 +0200)]
Extract addr_of for unprivileged_[my]probes.exp once and with optional dot.

Some architectures prefix function symbols with a '.', so accept an
optional dot prefix. Also extract each symbol only once instead of
for each pass over the list.

12 years agoExtend vma_map entry vm_end range when additional segments are mapped.
Mark Wielaard [Fri, 21 Oct 2011 11:34:21 +0000 (13:34 +0200)]
Extend vma_map entry vm_end range when additional segments are mapped.

Once registered, we may want to extend an earlier registered region.
A segment might be mapped with different flags for different offsets.
If so we want to record the extended range so we can address more
precisely to module names and symbols.

* runtime/task_finder_vma.c (__stp_tf_get_vma_map_entry_end_internal):
  New function.
  (stap_extend_vma_map_info): Likewise.
* runtime/vma.c (_stp_vma_mmap_cb): Call stap_extend_vma_map_info().

12 years agoAdd runtime/autoconf-mm-context-vdso-base.c for vma.c vdso catching.
Mark Wielaard [Thu, 20 Oct 2011 18:42:34 +0000 (20:42 +0200)]
Add runtime/autoconf-mm-context-vdso-base.c for vma.c vdso catching.

Some architectures use an unsigned long vdso_base field in mm->context,
instead of a void *vdso field. Detect either in _stp_vma_match_vdso().

12 years agoset test "hash_add_buildid"
Mark Wielaard [Thu, 20 Oct 2011 14:26:01 +0000 (16:26 +0200)]
set test "hash_add_buildid"

12 years agoMake sure sdt includes are setup for cast-scope.exp testcase.
Mark Wielaard [Thu, 20 Oct 2011 13:53:43 +0000 (15:53 +0200)]
Make sure sdt includes are setup for cast-scope.exp testcase.

12 years agotestsuite/systemtap.exelib allow any libc function to occur as start_func.
Mark Wielaard [Thu, 20 Oct 2011 11:44:07 +0000 (13:44 +0200)]
testsuite/systemtap.exelib allow any libc function to occur as start_func.

On some arches some libc startup function don't have a starting _.
e.g. on powerpc there is generic_start_main().

12 years agoDisable uregs recovery through kernel dwarf unwinder for powerpc.
Mark Wielaard [Thu, 20 Oct 2011 11:38:31 +0000 (13:38 +0200)]
Disable uregs recovery through kernel dwarf unwinder for powerpc.

Sadly powerpc does support the dwarf unwinder, but doesn't have enough
CFI in the kernel to recover fully to user space.

12 years agoDon't try to do any lookup when addr is zero in _stp_kallsyms_lookup().
Mark Wielaard [Thu, 20 Oct 2011 11:06:54 +0000 (13:06 +0200)]
Don't try to do any lookup when addr is zero in _stp_kallsyms_lookup().

12 years agoRemove unused runtime/stack-ppc.c.
Mark Wielaard [Thu, 20 Oct 2011 11:00:27 +0000 (13:00 +0200)]
Remove unused runtime/stack-ppc.c.

12 years agoDon't trust dwfl_module_relocations() for ET_EXEC in get_unwind_data.
Mark Wielaard [Wed, 19 Oct 2011 21:39:07 +0000 (23:39 +0200)]
Don't trust dwfl_module_relocations() for ET_EXEC in get_unwind_data.

12 years agoFixed PR13158 by adding a staprun signal handler so modules don't remain.
David Smith [Wed, 19 Oct 2011 15:00:45 +0000 (10:00 -0500)]
Fixed PR13158 by adding a staprun signal handler so modules don't remain.

* runtime/staprun/staprun.c (term_signal_handler): New function.
  (setup_term_signals): Ditto.
  (insert_stap_module): Remembers if insert_module() worked.
  (main): Call setup_term_signals().
* testsuite/systemtap.base/rename_module.exp: Made test case more robust
  by waiting on output from all stap scripts.
* testsuite/systemtap.base/pr13158.exp: New testcase.

12 years agoPR13319: fix _stp_bufsize-related start-time net/ memory report printk
Frank Ch. Eigler [Wed, 19 Oct 2011 02:49:35 +0000 (22:49 -0400)]
PR13319: fix _stp_bufsize-related start-time net/ memory report printk

* transport/relay_v2.c, relayfs.c (_stp_transport_data_fs_init):
  Increment _stp_allocated_[net_]memory with relay buffers.
* transport/ring_buffer.c: Ditto.  Plus fix scaling of the incoming -sNN
  value, so NN represents megabytes consistently.

12 years agorhbz744907: Fix unowned directories
Josh Stone [Tue, 18 Oct 2011 21:33:17 +0000 (14:33 -0700)]
rhbz744907: Fix unowned directories

Most notably, %{_libdir}/systemtap and %{_libexecdir}/systemtap were
note owned by the subpackages which install files there.

12 years agoPR13317: mention parser error handling changes
Frank Ch. Eigler [Tue, 18 Oct 2011 21:21:21 +0000 (17:21 -0400)]
PR13317: mention parser error handling changes

12 years agoPR13317: improve parse error recovery heuristics
Frank Ch. Eigler [Tue, 18 Oct 2011 20:58:15 +0000 (16:58 -0400)]
PR13317: improve parse error recovery heuristics

This change changes the 10 parse errors reported by brendang for iostat-scsi.stp
to just six actually salient ones.

* parse.cxx (parser::parse): Reorder error recovery to skip
  everything until next top-level keyword.  Wrap try {} in
  while {} rather than vice versa.
  (parser::parse_stmt_block): Drop recovery loop.

12 years agotestsuite: add installtest_p protection to systemtap.base/stmt_rel.exp
Frank Ch. Eigler [Tue, 18 Oct 2011 20:10:33 +0000 (16:10 -0400)]
testsuite: add installtest_p protection to systemtap.base/stmt_rel.exp

12 years agotestsuite: add installtest_p assertion to rename_module.exp
Frank Ch. Eigler [Tue, 18 Oct 2011 20:02:55 +0000 (16:02 -0400)]
testsuite: add installtest_p assertion to rename_module.exp

12 years agoDon't crash with -DDEBUG_SYMBOLS in _stp_umod_lookup when vm_start is NULL.
Mark Wielaard [Tue, 18 Oct 2011 20:13:51 +0000 (22:13 +0200)]
Don't crash with -DDEBUG_SYMBOLS in _stp_umod_lookup when vm_start is NULL.

12 years agoFilter out arch-specific and deprecated functions in unprivileged_embedded_C.exp.
Dave Brolley [Tue, 18 Oct 2011 19:09:02 +0000 (15:09 -0400)]
Filter out arch-specific and deprecated functions in unprivileged_embedded_C.exp.

12 years agoPR 13128: Pass user privilege credentials from staprun to the module.
Dave Brolley [Tue, 18 Oct 2011 17:54:20 +0000 (13:54 -0400)]
PR 13128: Pass user privilege credentials from staprun to the module.

- User's privilege credentials are determined by staprun and passed to the module
- Module contains generated code which checks the user's credentials against those
  required to load/run the module (specified at compile time).
  - module aborts if credentials are insufficient.

12 years agoPR13261 Cont'd: Added NEWS, man page and Language Ref entries
Chris Meek [Tue, 18 Oct 2011 14:14:55 +0000 (10:14 -0400)]
PR13261 Cont'd: Added NEWS, man page and Language Ref entries

12 years agoPR13284 Failure to resolve kernel global e.g. jiffies.
Mark Wielaard [Tue, 18 Oct 2011 12:28:59 +0000 (14:28 +0200)]
PR13284 Failure to resolve kernel global e.g. jiffies.

* dwflpp.cxx (vardie_from_symtable): Also accept STT_NOTYPE. Some global
  don't have a type associated with them.
* testsuite/buildok/pr13284.stp: New testcase.

12 years agoPR13283: Use a temporary string for comparisons
Josh Stone [Mon, 17 Oct 2011 22:18:06 +0000 (15:18 -0700)]
PR13283: Use a temporary string for comparisons

The reported issue was trying to directly compare the results of two
different kernel_string() calls, but they were always computed equal
even though they were known to be different.  Inspection of pass-3
showed that both calls led to an expr-stmt ending in ...->__retvalue.
This is just a pointer though, and it happens here that both calls will
point to the same string buffer, so strncmp rightly calls them equal.

To fix this, we must introduce temporary storage for the intermediate
strings.  Now we won't lose either value, and they can be properly
compared for equality.

* translate.cxx (c_tmpcounter::visit_comparison): Declare temporary
  storage for the left operand if it's not a literal.
  (c_unparser::visit_comparison): Use the left temporary.
* testsuite/systemtap.string/strcmp.*: Test string comparisons.

12 years agoFix PR13312 by defining PTRACE_GET_LAST_BREAK for older kernels.
David Smith [Mon, 17 Oct 2011 21:30:34 +0000 (16:30 -0500)]
Fix PR13312 by defining PTRACE_GET_LAST_BREAK for older kernels.

* tapset/s390/aux_syscalls.stp: If PTRACE_GET_LAST_BREAK isn't defined,
  define it.

12 years agoi18n: fix printf formatting typo in commit 984ad50c
Frank Ch. Eigler [Mon, 17 Oct 2011 20:15:47 +0000 (16:15 -0400)]
i18n: fix printf formatting typo in commit 984ad50c

12 years agoi18n: fix gettext markup for "command line argument index" parse error message
Frank Ch. Eigler [Mon, 17 Oct 2011 15:54:38 +0000 (11:54 -0400)]
i18n: fix gettext markup for "command line argument index" parse error message

12 years agoPR13261 Cont'd: Added test cases for map wrapping
Chris Meek [Fri, 14 Oct 2011 15:58:52 +0000 (11:58 -0400)]
PR13261 Cont'd: Added test cases for map wrapping

12 years agoPR13261 cont'd: Added error handling for scalars
Chris Meek [Fri, 14 Oct 2011 14:37:57 +0000 (10:37 -0400)]
PR13261 cont'd: Added error handling for scalars

elaborate.cxx
  Ensured that if the variable is a global scalar and '%' has been
  used for wrapping, an error is thrown.

12 years agoTweak cache logic to group removals by hash value
Josh Stone [Thu, 13 Oct 2011 22:55:24 +0000 (15:55 -0700)]
Tweak cache logic to group removals by hash value

We used to glob the cache for *.ko, *.so, *.h, and *.log, implicitly
assuming that this was all that was cached.  For the .ko case we also
grouped .c and .sgn to be removed all together.  But when any new
extension came along, the cache cleanup ignored it.

Now we glob instead for any file in the cache that looks like is has a
hashed name, and we group removals for all files that appear to have the
same hash value, regardless of prefix or suffix.  This will hopefully
make us more robust against future file-caching changes.

* cache.cxx (cache_ent_info): Becomes a vector of paths, with no
  knowledge needed for modules.  Use better types for size and mtime.
  (clean_cache): Use a new glob that looks for hash-like files, with 32
  hex digits in a row.  Use a regex to find common HASH_LEN substrings
  in all those filenames.  Build the cache_ent_info groups by HASH_LEN,
  and proceed to delete old entries until below quota.

12 years agoHandle PPC64 function symbols by resolving function descriptors.
Mark Wielaard [Thu, 13 Oct 2011 21:19:21 +0000 (23:19 +0200)]
Handle PPC64 function symbols by resolving function descriptors.

* translate.cxx (dump_symbol_table): If the module is EM_PPC64, but not
  ET_REL, then register two address for a STT_FUNC. The function descriptor
  address and the address of the function that the descriptor points to.
  For ET_REL still rely on the .function_name convention.

12 years ago(More PR13289 fixes) Added better %m/%M error handling.
David Smith [Thu, 13 Oct 2011 21:24:43 +0000 (16:24 -0500)]
(More PR13289 fixes) Added better %m/%M error handling.

* runtime/print.c (_stp_unreserve_bytes): New function.
* runtime/print.h: Added _stp_unreserve_bytes() declaration.
* runtime/vsprintf.c (_stp_vsprint_memory): Only change the input pointer
  to "<NULL>" when we're formatting a string (%s), not when we're
  formatting raw memory (%m/%M).  Also, return NULL on errors.
  (_stp_vsprint_memory_size): Only change the input pointer to "<NULL>"
  when we're formatting a string (%s), not when we're formatting raw
  memory (%m/%M).
  (_stp_vsnprintf): If _stp_vsprint_memory() returns NULL, unreserve bytes
  in the print buffer, when necessary.
* translate.cxx (c_unparser::emit_compiled_printfs): If
  _stp_vsprint_memory() returns NULL, unreserve bytes in the print buffer,
  when necessary.  Also improve error message if _stp_vsprint_memory()
  fails by setting 'last_stmt'.
* testsuite/systemtap.stress/conversions.stp: Added tests for '%M' and for
  using sprintf() with '%m' and '%M'.
* testsuite/systemtap.stress/conversions.exp: Updated error count.

12 years agoPR13155: Fix tracepoint argument access
Josh Stone [Thu, 13 Oct 2011 20:22:29 +0000 (13:22 -0700)]
PR13155: Fix tracepoint argument access

The restructured tracepoint build broke the way tracepoint parameters
are passed to the script.  This patch cleans that up, and simplifies a
few other parts of the code generation.

* tapsets.cxx (tracepoint_derived_probe_group::emit_module_decls):
  Define intptr_t for the aux source.  Collect .used entries from
  p->args[] into used_args[] to ease call-list generation. Simplify
  registration by replacing the wrappers with plain declarations.
* buildrun.cxx (compile_pass): We do have everything needed for strict
  prototypes, so don't squash this warning.

12 years agoPR13155: separate compilation for tracepoint-related functions
Frank Ch. Eigler [Thu, 13 Oct 2011 16:33:48 +0000 (12:33 -0400)]
PR13155: separate compilation for tracepoint-related functions

The linux kernel's tracepoint headers are sometimes mutually
conflicting, defining structs etc. differently.  Since we need to use
each header in its natural habitat, we need to separately-compile
those tracepoint-related functions that absolutely need access to
those declarations.  This is quite new to us as so far, the translator
has usually emitted a single translated_source output, plus the
stap-symbols.h file.

* buildrun.cxx (compile_pass): Compile auxiliary sources into main module.
* tapsets.cxx (tracepoint_derived_probe_group::emit_module_decls): Effectively
  rewrite to create per-tracepoint-header auxiliary source files.
* session.cxx (op_create_auxiliary): New function.
* translate.cxx (translator_output): Add filename field.
* session.h, translate.h: Corresponding changes.
* hash.cxx (find_script_hash): Rename primary source file to stap_XXX_src.c.
* main.cxx (passes_0_4): Ditto.

12 years agodocumentation: mention --remote=direct:// and --remote-prefix
Frank Ch. Eigler [Mon, 10 Oct 2011 14:05:21 +0000 (10:05 -0400)]
documentation: mention --remote=direct:// and --remote-prefix

12 years agoPR13155 prep: move kbuild make -j parallelism to general code
Frank Ch. Eigler [Mon, 10 Oct 2011 13:36:48 +0000 (09:36 -0400)]
PR13155 prep: move kbuild make -j parallelism to general code

* buildrun.cxx (run_make_cmd): Do it here, to cover all make invocations,
  (make_tracequeries) ... instead of here.

12 years agoPR13076 tidbit: increase default module cache size to 256MB
Frank Ch. Eigler [Mon, 10 Oct 2011 13:36:27 +0000 (09:36 -0400)]
PR13076 tidbit: increase default module cache size to 256MB

12 years agoFixed PR13083 by no longer calling mmput() when possible.
David Smith [Thu, 13 Oct 2011 17:37:29 +0000 (12:37 -0500)]
Fixed PR13083 by no longer calling mmput() when possible.

* runtime/task_finder.c (__stp_utrace_attach): Don't call
  get_task_mm()/mmput().  Since we're in the context of that task, the mm
  should stick around (and mmput() can sleep).
  (__stp_call_mmap_callbacks_with_addr): Ditto.
  (__stp_utrace_attach_match_tsk): Ditto.
  (__stp_call_mmap_callbacks_for_task): Ditto.

12 years agoPR13261: Added map->wrap mode to script parser
Chris Meek [Thu, 13 Oct 2011 17:04:54 +0000 (13:04 -0400)]
PR13261: Added map->wrap mode to script parser

To activate map->wrap mode, use the '%' symbol after the variable name
in a global declaration, for example:

  global foo%[100]

This will let it automatically replace elements in the map if you
try to place something out of bounds, rather than give an error.
It also works for statistics-valued arrays.

parse.cxx
  Checked for the '%' symbol in parser::parse_global(), and if
  present, sets the vardecl* d->wrap value to true.

staptree.cxx
  Set the default value of the new vardecl->wrap boolean value to false.
  Added the '%' to the hash if it is enabled.

staptree.h
  Added the bool wrap element to struct vardecl

translate.cxx
  Added the bool wrap element to struct mapvar and initialixed it to the
  wrap element of the associated vardecl variable.
  Checked whether the mapvar->wrap has been set (from vardecl->wrap set
  in parser::parse_global()).
  If so, added the apropriate code to set the map->wrap for whether its a
  map or a pmap.

12 years agoPR13241 too much dump-unwindsyms processing for modules even if !need_symbols
Mark Wielaard [Thu, 13 Oct 2011 11:53:08 +0000 (13:53 +0200)]
PR13241 too much dump-unwindsyms processing for modules even if !need_symbols

Introduce dump_section_list() that will pregenerate the section list when
needed. dump_symbol_tables() now does the minimum necessary to extract
the needed symbols, or will not even be called at all when !need_symbols
and the module isn't the "kernel".

12 years agoFixed PR12389 by making %m/%M use kread() to access memory.
David Smith [Wed, 12 Oct 2011 21:52:30 +0000 (16:52 -0500)]
Fixed PR12389 by making %m/%M use kread() to access memory.

* runtime/vsprintf.c (_stp_vsprint_memory): The '%m' and '%M' formatting
  operators use kread() to read memory.
* translate.cxx: Removed all support from the c_unparser class for
  'probe_or_function_needs_deref_fault_handler' processing since it is no
  longer needed.
  (c_unparser::visit_print_format): Removed deref_buffer() call.  Added
  check for c->last_error after print is done.
* runtime/runtime_context.h: New file.
* runtime/vsprintf.h: Ditto.
* runtime/print.c: Removed extra include of vsprintf.c.  Allow use to
  override STP_LOG_BUF_LEN.  Make _stp_print_flush() definitions exactly
  the same between the RELAY_{GUEST,HOST} and normal caes.
* runtime/print.h: Added a few more functions and includes the new
  vsprintf.h file.
* runtime/runtime.h: Includes print.h instead of print.c.  Moved print.c
  and io.c to runtime_context.h.
* runtime/transport/transport.h: Declares '_stp_target'.

12 years agoembeddedc.awk: Fixup too much whitespace for unprivileged_embedded_C.exp.
Mark Wielaard [Wed, 12 Oct 2011 19:50:25 +0000 (21:50 +0200)]
embeddedc.awk: Fixup too much whitespace for unprivileged_embedded_C.exp.

12 years agoSplit translate dump_unwindsyms in separate collection/dump phases.
Mark Wielaard [Wed, 12 Oct 2011 10:53:30 +0000 (12:53 +0200)]
Split translate dump_unwindsyms in separate collection/dump phases.

Untangle separate module data collection. First collect all information,
build-ids, symbols, unwind tables, etc. Put all collected info in the
unwindsym_dump_context. Then dump it all out using the context.

12 years agoPR 13128: Generate section in the module containing privilege level information.
Dave Brolley [Wed, 12 Oct 2011 14:41:22 +0000 (10:41 -0400)]
PR 13128: Generate section in the module containing privilege level information.

- A list of the groups allowed to load/run the module is generated into the
  section .stap_privilege.

12 years agoPR 13128: Modify unprivileged mode infrastructure to support a multi-privilege design
Dave Brolley [Tue, 11 Oct 2011 18:49:07 +0000 (14:49 -0400)]
PR 13128: Modify unprivileged mode infrastructure to support a multi-privilege design

vs the previous boolean privileged/unprivileged design.

- in stap
  - Store the specified privilege level as an enum as opposed to a boolean
  - Test privilege levels against the proper enumerator.
- in the generated code
  - Generate STP_PRIVILEGE macro with the specified privilege level
  - Generated code tests it against the proper privilege level.

12 years agotracepoints: Add support for CONDITION events
Josh Stone [Tue, 11 Oct 2011 23:55:59 +0000 (16:55 -0700)]
tracepoints: Add support for CONDITION events

These are events that check a condition before raising callbacks, but
take no hit for the condition when not tracing.  We don't have to do
anything special in stap except handle the new macro, as the condition
is handled at the trace site.

* tapsets.cxx (tracepoint_builder::get_tracequery_modules): Add a
  definition for DECLARE_TRACE_CONDITION.  Also settle the macro-
  arg wrappers to PARAMS().

12 years agotracepoints: Support reading enum parameters
Josh Stone [Tue, 11 Oct 2011 22:04:13 +0000 (15:04 -0700)]
tracepoints: Support reading enum parameters

* tapsets.cxx (resolve_tracepoint_arg_type): Treat enum like any other
  numeric base type, simply casted to int64_t.
  (tracepoint_derived_probe::build_args): Log parameter availability.

12 years agotracepoints: Skip identical headers from the build and source trees
Josh Stone [Tue, 11 Oct 2011 21:15:27 +0000 (14:15 -0700)]
tracepoints: Skip identical headers from the build and source trees

In preparing the tracequery source, we normalize paths containing
"include/" to just the suffix part, so the header will be found by the
normal -I path.  However, the debuginfo source tree usually contains
at least the same headers found in the build tree.  We were thus
building effectively the same tracequery twice for headers that are
present in both the build and source trees.  Stop that!

* tapsets.cxx (tracepoint_builder::init_dw): Build the header list with
  knowledge of the "include/" normalization to avoid extra work.

12 years agotracepoints: Avoid building tracequery.ko targets
Josh Stone [Tue, 11 Oct 2011 20:42:04 +0000 (13:42 -0700)]
tracepoints: Avoid building tracequery.ko targets

Since we're now only using the tracequery.o intermediates, we can forgo
building the tracequery.ko modules altogether.  This saves about a third
of the processing time on my machine.

* buildrun.cxx (make_any_make_cmd): New, the common make_cmd base.
  (make_make_cmd): The normal case targets "modules".
  (make_make_objs_cmd): New, build only stage-1 objects.
  (make_tracequeries): Call make_make_objs_cmd.

12 years agotracepoints: Work with the tracequery's .o rather than .ko
Josh Stone [Tue, 11 Oct 2011 20:21:34 +0000 (13:21 -0700)]
tracepoints: Work with the tracequery's .o rather than .ko

The intermediate object files are slightly smaller, since they don't
have any of the module boilerplate compiled in yet.  It still has what
we need though, just the basic stapprobe_* function definitions.

* buildrun.cxx (make_tracequeries): Return .o filenames rather than .ko.
* hash.cxx (find_tracequery_hash): Use .o for cached filenames.
* tapsets.cxx (tracepoint_builder::get_tracequery_modules): Update
  comments and variable names to refer to objects instead of kos.

12 years agotracepoints: Cache an empty file for failures
Josh Stone [Tue, 11 Oct 2011 20:13:40 +0000 (13:13 -0700)]
tracepoints: Cache an empty file for failures

When a tracepoint header doesn't compile for any reason, we'd like not
to keep trying on subsequent runs.  This patch restores previous
behavior that would save an empty file in the cache, signaling that
we've tried this header before and can't get anything from it.

* tapsets.cxx (tracepoint_builder::get_tracequery_modules): When reading
  from the cache, note and skip empty files.  When saving to the cache,
  copy /dev/null for those that failed to compile.

12 years agoPR3823: fix accidental whitespace included in type mismatch messages for i18n
Frank Ch. Eigler [Tue, 11 Oct 2011 13:39:56 +0000 (09:39 -0400)]
PR3823: fix accidental whitespace included in type mismatch messages for i18n

* elaborate.cxx (typeresolution_info::mismatch): eliminate excess space.

Reported-by: Petr Muller <pmuller@redhat.com> and the fine fujitsu testsuite
12 years agoPR13155/BZ730884: ext3/jbd tracepoint listings
Han Pingtian [Mon, 10 Oct 2011 10:12:37 +0000 (06:12 -0400)]
PR13155/BZ730884: ext3/jbd tracepoint listings

A few tracepoint-class-specific hacks to make ext3 / jbd / ext4 / jbd2
all show up on appropriate kernels.

* tapsets.cxx (tracepoint_extra_decls): Add extra ext[34] clauses.

12 years agotestsuite: add dummyish test case for tracepoint listing only
Frank Ch. Eigler [Mon, 10 Oct 2011 10:12:19 +0000 (06:12 -0400)]
testsuite: add dummyish test case for tracepoint listing only

12 years agoPR13100: build tracepoint query modules separately, concurrently
Frank Ch. Eigler [Mon, 10 Oct 2011 09:08:22 +0000 (05:08 -0400)]
PR13100: build tracepoint query modules separately, concurrently

* tapsets.cxx (tracepoint_extra_decls): Prepare for PR13155.
  (get_tracepoint_modules): Rewrite former get_tracepoint_module().
  (tracepoint_builder::init_dw): Don't even try to build all tracequery
  modules at once.
* buildrun.cxx (make_tracequeries): Replace make_tracequery().
  Run given compilation jobs in parallel.
* buildrun.h: Corresponding changes.
* hash.cxx (find_tracequery_hash): Clarify signature for single header.
* hash.h: Corresponding changes.

12 years agotestsuite: note number of kernel tracepoints tested in pass result
Frank Ch. Eigler [Mon, 10 Oct 2011 08:48:26 +0000 (04:48 -0400)]
testsuite: note number of kernel tracepoints tested in pass result

12 years agoexamples: add a &para; anchor to the keyword index html too
Frank Ch. Eigler [Fri, 7 Oct 2011 21:33:17 +0000 (17:33 -0400)]
examples: add a &para; anchor to the keyword index html too

12 years agoexamples: tweak keyword selections
Frank Ch. Eigler [Fri, 7 Oct 2011 21:31:07 +0000 (17:31 -0400)]
examples: tweak keyword selections

12 years agoexamples: add a &para; anchor before individual examples in full index
Frank Ch. Eigler [Fri, 7 Oct 2011 21:28:31 +0000 (17:28 -0400)]
examples: add a &para; anchor before individual examples in full index

12 years agoPR3217: Fix systemtap.base/vars.exp
Josh Stone [Fri, 7 Oct 2011 17:13:38 +0000 (10:13 -0700)]
PR3217: Fix systemtap.base/vars.exp

This test has a grep on pass-3 code, which started matching too much
with the new compiled-printf output.  This tightens that grep down a
bit, and adds a comment explaining what the test is trying to do.

12 years agoPR13272: Fix quoted strings in the printf shortcut path
Josh Stone [Fri, 7 Oct 2011 16:48:43 +0000 (09:48 -0700)]
PR13272: Fix quoted strings in the printf shortcut path

For printf strings with no arguments, we usually skip all the printf
path altogether and just use _stp_print.  However, the compiled-printf
changes affected the level of string escaping, which broke for a case
like printf("\"quote\\this\"\n").  We must make sure that this shortcut
path uses an output-quoted string literal.

* translate.cxx (c_unparser::visit_print_format): Generate an output-
  quoted format_string too, for use by the _stp_print shortcut.
  (preprocess_print_format): The "%s\n" case shouldn't alter components.
* testsuite/buildok/printf.stp: Add "%s" and "%s\n" shortcut tests too.

12 years agoMerge branch 'master' of ssh://sourceware.org/git/systemtap
Mark Wielaard [Fri, 7 Oct 2011 11:18:33 +0000 (13:18 +0200)]
Merge branch 'master' of ssh://sourceware.org/git/systemtap

12 years agoEnable dwarf unwinder for ppc64.
Mark Wielaard [Fri, 7 Oct 2011 09:54:39 +0000 (11:54 +0200)]
Enable dwarf unwinder for ppc64.

12 years agoAlways remove prefix '.' when _stp_snprint_addr() human readable symname.
Mark Wielaard [Fri, 7 Oct 2011 09:51:06 +0000 (11:51 +0200)]
Always remove prefix '.' when _stp_snprint_addr() human readable symname.

Some arches prefix some symbol names with '.', to make symbol names as
presented in human readable form consistent across arches always remove
them when printing them with _stp_snprint_addr. Remove special casing
in context-symbols.stp probefunc().

12 years agoPR3217: Add STP_LEGACY_PRINT option to use the old form
Josh Stone [Thu, 6 Oct 2011 20:00:09 +0000 (13:00 -0700)]
PR3217: Add STP_LEGACY_PRINT option to use the old form

* translate.cxx (c_unparser::visit_print_format): Alternate using
  STP_LEGACY_PRINT between the new compiled printfs and the old
  _stp_[s]printf, so we can make sure both still work.
  (c_unparser::emit_compiled_printf_locals): Conditionalize.
  (c_unparser::emit_compiled_printfs): Conditionalize.
* testsuite/lib/stap_run2.exp: Show extra args used in stap_run2.
* testsuite/systemtap.printf/*.exp: Run -DSTP_LEGACY_PRINT too in all
  the tests using stap_run2.  Others will require greater restructuring
  to achieve this...

12 years agoPR3217: Make compiled-printf functions noinline
Josh Stone [Thu, 6 Oct 2011 19:33:59 +0000 (12:33 -0700)]
PR3217: Make compiled-printf functions noinline

When running systemtap.printf/int1.stp, I got:

    ...: In function ‘probe_1997’:
    ...:3885:1: error: the frame size of 772 bytes is larger than 256 bytes [-Werror=frame-larger-than=]

It's not yet clear to me why gcc claims so much stack space here, as
even in the compiled printf functions, most of the local variables have
very limited scope.  For now, marking them noinline solves the issue,
but this deserves closer inspection...

* translate.cxx (c_unparser::emit_compiled_printfs): Mark each generated
  printf function as noinline.

12 years agoPR3217: Merge similar compiled-printfs
Josh Stone [Tue, 27 Sep 2011 22:30:13 +0000 (15:30 -0700)]
PR3217: Merge similar compiled-printfs

It's pretty common for tapset wildcards to expand to lots of probes with
slightly different handlers (e.g. syscall.*), and we'd like for the
newly expanded printf code to not be duplicated so much.

This patch keeps a hash in the translator of visited format strings, so
we can output a compiled version of that only once.  This requires some
new argument space in the context, but we can optimize by realizing that
(1) printfs never nest when arguments are precomputed, (2) string
arguments are immutable and need not be copied, and (3) return strings
for sprintf can write directly to the caller's tmpvar.

* translate.cxx (c_unparser::compiled_printfs): New map for storing
  pair(print_to_stream, format_string) -> compiled printf name.
  (c_unparser::emit_compiled_printfs): New, emit the expanded function
  body for every compiled printf.
  (c_unparser::emit_compiled_printf_locals): New, emit a union-struct of
  context locals for all compiled printfs.
  (c_unparser::emit_common_header): Call emit_compiled_printf*.
  (c_unparser::declare_compiled_printf): New, called to declare that we
  need this printf -- add it to the map if it's not already there.
  (c_tmpcounter::visit_print_format): Declare printfs as we see them.
  (c_unparser::get_compiled_printf): New, get the name for a previously
  declared printf function.
  (c_unparser::visit_print_format): Get the compiled printf function.

12 years agoPR3217: Compiled printf
Josh Stone [Tue, 7 Jun 2011 23:50:20 +0000 (16:50 -0700)]
PR3217: Compiled printf

This translates script-level printf statements into unrolled printing
statements.  The compiled code is faster, but also larger.

* runtime/vsprintf.c (_stp_vsprint_memory): Factored out for %s/%m/%M.
  (_stp_vsprint_memory_size): Factored out for size of %s/%m/%M.
  (_stp_vsprint_memory_size): Factored out for %b.
  (_stp_vsprint_binary_size): Factored out for size of %b.
* staptree.h (print_format::format_flag): Match the same definitions
  used by print_flag in runtime/vsprintf.c.
  (print_format::conversion_type): Collapse numeric types into one.
  (print_format::format_component::base): New field to classify numeric.
  (print_format::set_flag, print_format::test_flag): New, for convenience.
* elaborate.cxx (typeresolution_info::visit_print_format): Handle the
  changes in conversion_type.
* staptree.cxx (print_format::components_to_string): Parse out the new
  and impoved format_component.
  (print_format::string_to_components): Create the new format_component.
* translate.cxx (c_unparser::visit_print_format): Generate unrolled code
  for printf statements.

12 years agoDWARF_REG_MAP reg_value argument of DW_CFA_register in unwinder.
Mark Wielaard [Wed, 5 Oct 2011 21:36:52 +0000 (23:36 +0200)]
DWARF_REG_MAP reg_value argument of DW_CFA_register in unwinder.

12 years agoPR13266 Implement DW_CFA_restore in the dwarf unwinder.
Mark Wielaard [Wed, 5 Oct 2011 20:23:01 +0000 (22:23 +0200)]
PR13266 Implement DW_CFA_restore in the dwarf unwinder.

Store the initial reg state after processing the CIE and restore
on DW_CFA_restore[_extended].

12 years agoAUTHORS: bump
Frank Ch. Eigler [Fri, 30 Sep 2011 01:49:29 +0000 (21:49 -0400)]
AUTHORS: bump

12 years agoExplicitly set UNW_PC in unwinder to retAddrReg value if not yet set.
Mark Wielaard [Wed, 5 Oct 2011 17:49:08 +0000 (19:49 +0200)]
Explicitly set UNW_PC in unwinder to retAddrReg value if not yet set.

This is necessary when the UNW_PC storage is not equal to where retAddrReg
is set.

12 years agoSupport same value rules in unwinder. Don't treat undefined as same value.
Mark Wielaard [Wed, 5 Oct 2011 13:04:17 +0000 (15:04 +0200)]
Support same value rules in unwinder. Don't treat undefined as same value.

The unwinder treated undefined and same value rules the same. This patch
introduces different states for them. All "real" registers are assumed to
be "same value". Their value will be carried over to the next frame unless
overruled. All other "fake" dwarf registers are treated as undefined.
This makes a difference for architectures where for example the dwarf
return register is a real register, where same value means something
different from undefined (e.g. ppc).

12 years agoExtend optionalprobe.exp timeout to 120 seconds.
Mark Wielaard [Wed, 5 Oct 2011 10:01:18 +0000 (12:01 +0200)]
Extend optionalprobe.exp timeout to 120 seconds.

optionalprobe.exp uses tracepoint probes and is the first to do so.
Generating the tracepoint cache can take more than 60 seconds on some setups.

12 years agoDocument process.plt.
Stan Cox [Tue, 4 Oct 2011 15:11:19 +0000 (11:11 -0400)]
Document process.plt.

NEWS: Add process.plt.
stapprobes.3stap:  Likewise.
doc/langref.tex:  Likewise.

12 years agoIntroduce DWARF_MAP_REG for unwind.
Mark Wielaard [Tue, 4 Oct 2011 13:19:52 +0000 (15:19 +0200)]
Introduce DWARF_MAP_REG for unwind.

The reg_info array assumes dwarf register numbers start at zero and
are consecutive.  If that isn't the case for some architecture (e.g. ppc)
then redefine DWARF_MAP_REG to map the given dwarf register number to the
actual reg_info index.

12 years agoAdd process.library.plt
Stan Cox [Mon, 3 Oct 2011 15:14:44 +0000 (11:14 -0400)]
Add process.library.plt

tapsets.cxx (symbol_table::get_first_func):  New.
(dwarf_query::query_module_symtab):    Use it to as a placeholder, which
is replaced by plt entry address.
(symbol_table::*)  Add \n to cerr messages.

plt.exp:  Test process.library.plt

12 years agoRename runtime/stack-x86.c -> runtime/stack-dwarf.c to reuse by other arches.
Mark Wielaard [Mon, 3 Oct 2011 13:08:10 +0000 (15:08 +0200)]
Rename runtime/stack-x86.c -> runtime/stack-dwarf.c to reuse by other arches.

12 years agoCheck module was actually created in tracepoint_builder.
Mark Wielaard [Fri, 30 Sep 2011 13:57:43 +0000 (15:57 +0200)]
Check module was actually created in tracepoint_builder.

Commit e86f32 added -i to the make invocation for tracequery jobs. This
means make would succeed even if there were errors. So it was possible
that tracequery_ko didn't actually exist. Leading to spurious warnings
about copying non-existing files into the cache when used.

12 years agotapset: remove result caching from __find_bdevname
Frank Ch. Eigler [Thu, 29 Sep 2011 21:33:48 +0000 (17:33 -0400)]
tapset: remove result caching from __find_bdevname

This function is indirectly used from many vfs tapset probe points.
Since it sets/gets an internal script global variable, the current
optimizer does not elide this function, thus wasting time, space, and
risks @cast/kread runtime errors.  Let's get rid of the cache, until
the optimizer can do this automagically.

* tapset/vfs.ftp (__find_bdevname): Simplify.

12 years agoRemove unused unwind _stp_put_unaligned definitions.
Mark Wielaard [Thu, 29 Sep 2011 15:04:40 +0000 (17:04 +0200)]
Remove unused unwind _stp_put_unaligned definitions.

12 years agoConvert _stp_ctl_write_cmd->default's message to dbug_trans2
Josh Stone [Wed, 28 Sep 2011 21:07:07 +0000 (14:07 -0700)]
Convert _stp_ctl_write_cmd->default's message to dbug_trans2

12 years agoPR13128: preparing for more privilege levels
Josh Stone [Wed, 28 Sep 2011 20:58:11 +0000 (13:58 -0700)]
PR13128: preparing for more privilege levels

Only staprun (euid==0) sends STP_RELOCATION and STP_TZINFO.

This page took 0.067793 seconds and 5 git commands to generate.