]> sourceware.org Git - systemtap.git/log
systemtap.git
15 years agoUse || and && in preprocessor's conditions in tapsets.
Przemyslaw Pawelczyk [Fri, 28 Aug 2009 00:19:21 +0000 (02:19 +0200)]
Use || and && in preprocessor's conditions in tapsets.

Signed-off-by: Josh Stone <jistone@redhat.com>
15 years agoSupport || and && in preprocessor's conditions.
Przemyslaw Pawelczyk [Fri, 28 Aug 2009 00:11:47 +0000 (02:11 +0200)]
Support || and && in preprocessor's conditions.

* parse.cxx (parser::scan_pp): Add || and &&.
* stap.1.in: Document || and && in PREPROCESSING.
* testsuite/parseok/twenty.stp: Test case.
* testsuite/parseko/preprocess14.stp: Ditto.
* testsuite/parseko/preprocess15.stp: Ditto.

Signed-off-by: Josh Stone <jistone@redhat.com>
15 years agoCross check stap_compile.exp stap run result with error messages seen.
Mark Wielaard [Fri, 28 Aug 2009 11:51:41 +0000 (13:51 +0200)]
Cross check stap_compile.exp stap run result with error messages seen.

15 years agoTighten stap_compile.exp regexp to not accidentially gobble up extra lines.
Mark Wielaard [Fri, 28 Aug 2009 10:35:04 +0000 (12:35 +0200)]
Tighten stap_compile.exp regexp to not accidentially gobble up extra lines.

15 years agoPR10568: Ensure that aliases pull in their tapset
Josh Stone [Thu, 27 Aug 2009 22:43:51 +0000 (15:43 -0700)]
PR10568: Ensure that aliases pull in their tapset

When a probe alias is resolved in a tapset, the contents of that tapset
should be included in the compiled script, just as we do for global
variables and functions.

* elaborate.cxx (alias_expansion_builder::build): When an alias is
  instantiated, add its stapfile to the session files.
* testsuite/systemtap.base/tapset_includes.exp: New test.
* testsuite/systemtap.base/tapset/*.stp: Testing tapsets for above.

15 years agoxfail backtrace.exp as PR6961 backtrace from non-pt_regs probe context
Mark Wielaard [Thu, 27 Aug 2009 21:42:56 +0000 (23:42 +0200)]
xfail backtrace.exp as PR6961 backtrace from non-pt_regs probe context

15 years agoReturn, don't exit postgres.exp when unsupported.
Mark Wielaard [Thu, 27 Aug 2009 21:34:17 +0000 (23:34 +0200)]
Return, don't exit postgres.exp when unsupported.

15 years agoTeach postgres.exp to use a locally built version of postgres.
Stan Cox [Thu, 27 Aug 2009 18:47:08 +0000 (14:47 -0400)]
Teach postgres.exp to use a locally built version of postgres.

* postgres.exp: Grab postgres from upstream then build and test it
with uprobe, utrace, and kprobe.

15 years agoReorganize iterate_over_labels
Josh Stone [Thu, 27 Aug 2009 03:09:48 +0000 (20:09 -0700)]
Reorganize iterate_over_labels

I noticed that iterate_over_labels was using a static variable as a
recursion variable, which isn't a safe thing to do since it will only be
initialized once.  While fixing that, I also reorganized the function
quite a bit.

* dwflpp.cxx (dwflpp::iterate_over_labels): Take the current function as
  a parameter instead of using a static local.  Rewrite some of the code
  as well to try to make it more obvious.
* tapsets.cxx (add_label_name): Remove in favor of query_label.
  (query_label): New, to check decl_file and fix probe listing.
  (query_srcfile_label, query_cu): Adjust to iterate_over_labels change
  and start using query_label as the callback.

15 years agoRemove unnecessary static members
Josh Stone [Thu, 27 Aug 2009 00:35:54 +0000 (17:35 -0700)]
Remove unnecessary static members

When a static class member is only used by a single method, it's more
concise to use a static local variable instead.

* staptree.cxx (probe::probe): Make last_probeidx a static local.
* tapset-perfmon.cxx (perfmon_derived_probe::perfmon_derived_probe):
  Make probes_allocated a static local.

15 years agoCleanup some deref handling in the task tapset
Josh Stone [Thu, 27 Aug 2009 00:05:29 +0000 (17:05 -0700)]
Cleanup some deref handling in the task tapset

Some of this is just cosmetic, but there is one big takeaway: there's a
error-goto between kread calls and the CATCH_DEREF_FAULT.  You must not
allow this to bypass any resource management, like unlocking a resource
that you grabbed!

* tapset/task.stp (pid2task): No derefs, so remove the CATCH.
  (task_gid, task_egid, task_uid, task_euid): Move the CATCH within the
  #ifdef branch that actually needs it.
  (task_open_file_handles, task_max_file_handles): Ensure that we always
  call rcu_read_unlock if we locked it!

15 years agoCorrect a few comments to match the code
Josh Stone [Wed, 26 Aug 2009 23:15:46 +0000 (16:15 -0700)]
Correct a few comments to match the code

* tapset/conversions.stp (kernel_long, kernel_int, kernel_short,
  kernel_char): All are actually using kread(), not deref().
* tapset/i386/registers.stp (_stp_arg): Ditto.
* tapset/x86_64/registers.stp (_stp_arg): Ditto.

15 years agoIncrease avahi-browse timeout to 20 seconds.
Dave Brolley [Wed, 26 Aug 2009 16:36:25 +0000 (12:36 -0400)]
Increase avahi-browse timeout to 20 seconds.

15 years agoAllow 20 seconds for the server to start up.
Dave Brolley [Wed, 26 Aug 2009 14:46:50 +0000 (10:46 -0400)]
Allow 20 seconds for the server to start up.
Use ps -e to check for server and avahi pids.

15 years agoPR4186 cont'd: Squash EM_S390 to s390.
Mark Wielaard [Wed, 26 Aug 2009 11:16:17 +0000 (13:16 +0200)]
PR4186 cont'd: Squash EM_S390 to s390.

* tapsets.cxx (validate_module_elf): Set expect_machine to "s390".

15 years agoCompute cu_name dynamically
Josh Stone [Wed, 26 Aug 2009 01:53:40 +0000 (18:53 -0700)]
Compute cu_name dynamically

We only need cu_name for errors and verbose messages, so it's a waste to
always construct it in focus_on_cu.  It's now built only as-needed.

* dwflpp.cxx (dwflpp::cu_name): Now a method instead of a data member.
  (dwflpp::focus_on_module): No cu_name to clear now.
  (dwflpp::focus_on_cu): No cu_name to set now.
  (dwflpp::declaration_resolve): Adjust to call cu_name() now.
  (dwflpp::iterate_over_functions): Ditto.
* tapsets.cxx (query_cu): Ditto.

15 years agoAvoid needless Dwarf_Die copying
Josh Stone [Wed, 26 Aug 2009 01:20:39 +0000 (18:20 -0700)]
Avoid needless Dwarf_Die copying

* dwflpp.cxx (dwflpp::iterate_over_cus): Use the Dwarf_Die as a
  pointer directly into the vector.
  (dwflpp::iterate_over_inline_instances): Ditto.
  (dwflpp::iterate_over_functions): Ditto in a map.

15 years agoConvert module_cu_cache_t to a stap_map
Josh Stone [Wed, 26 Aug 2009 00:42:55 +0000 (17:42 -0700)]
Convert module_cu_cache_t to a stap_map

* dwflpp.cxx (module_cu_cache_t): Typedef as a stap_map instead.

15 years agoIndex cu_inl_function_cache_t by function->addr
Josh Stone [Wed, 26 Aug 2009 00:23:28 +0000 (17:23 -0700)]
Index cu_inl_function_cache_t by function->addr

Again, avoid needless string construction for map indexing.

* dwflpp.h (cu_inl_function_cache_t): Index by the void* function->addr.
* dwflpp.cxx (dwflpp::iterate_over_inline_instances): Index
  cu_inl_function_cache by function->addr.

15 years agoIndex mod_cu_function_cache_t by cu->addr
Josh Stone [Tue, 25 Aug 2009 23:58:20 +0000 (16:58 -0700)]
Index mod_cu_function_cache_t by cu->addr

Rather than constructing a "module:cu" string all the time, we can just
index the cache by the cu die's addr field.  The addr will never change
as long as the Dwarf object is still alive.

This has a quite noticeable performance impact for scripts that iterate
over lots of cus (like for syscall.*).

* dwflpp.h (stap_map): Allow void* keys too.
  (mod_cu_function_cache_t): Index by the void* cu->addr.
* dwflpp.cxx (dwflpp::iterate_over_functions): Index cu_function_cache
  by addr, and build the verbose strings manually when needed.
  (dwflpp::declaration_resolve): Index global_alias_cache by addr.

15 years agoPR4186 cont'd: clarify ARCH naming in NEWS too
Frank Ch. Eigler [Tue, 25 Aug 2009 16:38:33 +0000 (12:38 -0400)]
PR4186 cont'd: clarify ARCH naming in NEWS too

15 years agoPR4186 cont'd: option #2: standardize on kernel ARCH/SUBARCH throughout
Frank Ch. Eigler [Tue, 25 Aug 2009 15:54:15 +0000 (11:54 -0400)]
PR4186 cont'd: option #2: standardize on kernel ARCH/SUBARCH throughout

* main.cxx (main): Perform equivalent sed by hand on uname()->machine.
* stap.1.in: Clarify -a ARCH slightly.
* tapsets.cxx (validate_module_elf): Accept "arm*"for EM_ARM.
* tapset/**, testsuite/**: Removed/collapsed "i386"/"i686" branches,
  renamed "ppc64"->"powerpc" and "s390x"->"s390".

15 years agoKFAIL cmd_parse15 on kernel < 2.6.29, see commit e0ccd3.
Mark Wielaard [Tue, 25 Aug 2009 15:18:00 +0000 (17:18 +0200)]
KFAIL cmd_parse15 on kernel < 2.6.29, see commit e0ccd3.

* testsuite/systemtap.base/cmd_parse.exp: kfail cmd_parse15 when
  kernel26ver < 29.

15 years agoMake inlinedvars empty asm really empty.
Mark Wielaard [Tue, 25 Aug 2009 12:25:43 +0000 (14:25 +0200)]
Make inlinedvars empty asm really empty.

A debug "nop" was accidentially left in the asm statement that should
have been totally empty.

* testsuite/systemtap.base/inlinedvars.c (m): Really empty asm.

15 years agoPR2475: Filter filenames against the decl_file
Josh Stone [Tue, 25 Aug 2009 00:54:40 +0000 (17:54 -0700)]
PR2475: Filter filenames against the decl_file

We used to only check that a CU contains at least one srcfile matching
the user's file spec.  This patch ensures that the selected function was
actually defined in one of the matching srcfiles.

* tapsets.cxx (struct dwarf_query): Make filtered_srcfiles carry
  strings, so we can easily lookup matches later.
  (query_dwarf_func): Check that the decl_file is in filtered_srcfiles.
  (query_cu): Adjust to using set<string>.
* dwflpp.cxx (dwflpp::collect_srcfiles_matching): Take a set<string>.

15 years agoPR4186 cont'd: uname -m --> uname -i in test cases
Frank Ch. Eigler [Mon, 24 Aug 2009 23:42:28 +0000 (19:42 -0400)]
PR4186 cont'd: uname -m  -->  uname -i in test cases

15 years agoPR4186 cont'd: move tapset/i686 -> tapset/i386
Frank Ch. Eigler [Mon, 24 Aug 2009 23:38:51 +0000 (19:38 -0400)]
PR4186 cont'd: move tapset/i686 -> tapset/i386

15 years agoPR4186 cont'd: tolerate older kbuild Makefile's chattiness
Frank Ch. Eigler [Mon, 24 Aug 2009 17:14:21 +0000 (13:14 -0400)]
PR4186 cont'd: tolerate older kbuild Makefile's chattiness

* buildrun.cxx (run_make_cmd): Add back >/dev/null for older kernels.

15 years agoPR4186 cont'd: fix 32-bit i386 builds
Frank Ch. Eigler [Mon, 24 Aug 2009 16:54:42 +0000 (12:54 -0400)]
PR4186 cont'd: fix 32-bit i386 builds

* main.cxx (main): Initialize s.architecture to value as if
  from `uname -i`.  Specifically, squash i?86 -> i386.

15 years agoRename cache.exp proc stap_compile to cache_compile to not conflict.
Mark Wielaard [Mon, 24 Aug 2009 15:40:12 +0000 (17:40 +0200)]
Rename cache.exp proc stap_compile to cache_compile to not conflict.

* testsuite/systemtap.base/cache.exp: Rename proc stap_compile to
  cache_compile, to prevent conflict with proc stap_compile from
  lib/stap_compile.exp.

15 years agoFix failing uprobes.exp -p5 failures by removing trailing spaces in $$ vars.
Mark Wielaard [Mon, 24 Aug 2009 15:09:29 +0000 (17:09 +0200)]
Fix failing uprobes.exp -p5 failures by removing trailing spaces in $$ vars.

* tapsets.cxx (dwarf_var_expanding_visitor::visit_target_symbol_context):
  Don't add extra space at end of list, only add space between symbols.
* testsuite/systemtap.base/uprobes.exp: Use more specific expect regex.
* testsuite/systemtap.base/vars.exp: Don't just chop off last char of printf
  output string.

15 years agoPR4186: cross-architecture probe building
Frank Ch. Eigler [Mon, 24 Aug 2009 14:34:45 +0000 (10:34 -0400)]
PR4186: cross-architecture probe building

* main.cxx (main): Add 'a:' and 'B:' options.
* session.h (kbuildflags): New place to store -B args.
* testsuite/systemtap.base/cmd_parse.exp: Test them lightly.
* buildrun.cxx (run_make_cmd): Use "--no-print-directory"
  rather than ">/dev/null" in kbuild invocations.  Pass
  '-a' and '-B' flags along.
* hash.cxx (find_script_hash): Add them.
* NEWS, stap.1.in: Mention this.

15 years agoInitialize sdt_types testcase arr_char so that it is always null terminated.
Mark Wielaard [Mon, 24 Aug 2009 13:07:19 +0000 (15:07 +0200)]
Initialize sdt_types testcase arr_char so that it is always null terminated.

* testsuite/systemtap.base/sdt_types.c: Initialize char arr_char [], not
  with (too small) constant length, to make sure the string is always
  null terminated.

15 years agoSimplify mkstemp invocation.
Stan Cox [Mon, 24 Aug 2009 01:51:28 +0000 (21:51 -0400)]
Simplify mkstemp invocation.

*dtrace:  Don't bother with prefix when invoking mkstemp.

15 years agoPR10551: cont'd
Frank Ch. Eigler [Sun, 23 Aug 2009 23:10:36 +0000 (19:10 -0400)]
PR10551: cont'd

* runtime/print.c (_stp_print_kernel_info): Also switch module_core->module_core_rx.

15 years agoPR10551: build compatibility for pax/grsecurity include/linux/module.h
Frank Ch. Eigler [Sun, 23 Aug 2009 22:18:21 +0000 (18:18 -0400)]
PR10551: build compatibility for pax/grsecurity include/linux/module.h

This patch adapts to patches such as:

diff -urNp linux-2.6.29.6/include/linux/module.h linux-2.6.29.6/include/linux/module.h
--- linux-2.6.29.6/include/linux/module.h       2009-07-02 19:41:20.000000000 -0400
+++ linux-2.6.29.6/include/linux/module.h       2009-07-30 17:59:26.175602427 -0400
@@ -278,16 +278,16 @@ struct module
        int (*init)(void);

        /* If this is non-NULL, vfree after init() returns */
-       void *module_init;
+       void *module_init_rx, *module_init_rw;

        /* Here is the actual code + data, vfree'd on unload. */
-       void *module_core;
+       void *module_core_rx, *module_core_rw;

        /* Here are the sizes of the init and core sections */
-       unsigned int init_size, core_size;
+       unsigned int init_size_rw, core_size_rw;

        /* The size of the executable code in each section.  */
-       unsigned int init_text_size, core_text_size;
+       unsigned int init_size_rx, core_size_rx;

* runtime/autoconf-grsecurity.c: New test.
* buildrun.cxx: Try it.
* runtime/print.c: Use it.

15 years agobuild fix: make buildable with elfutils < 0.142
Frank Ch. Eigler [Sun, 23 Aug 2009 22:15:01 +0000 (18:15 -0400)]
build fix: make buildable with elfutils < 0.142

* dwarf_wrappers.h, loc2c.c: Define DW_TAG_rvalue_reference_type=0x42
  for older elfutils.

15 years agoPR10461: Add support for C++ classes and references
Josh Stone [Sat, 22 Aug 2009 02:16:18 +0000 (19:16 -0700)]
PR10461: Add support for C++ classes and references

* dwarf_wrappers.cxx (dwarf_type_name): Name class and reference types.
* dwflpp.cxx (dwflpp::iterate_over_globals): Capture class names.
  (dwflpp::print_members): Permit classes, and dig into inheritance.
  (dwflpp::find_struct_member): Ditto.
  (dwflpp::translate_components): Handle classes and references.
  (dwflpp::translate_final_fetch_or_store): Ditto.
* loc2c.c (c_translate_pointer): Treat references as simple pointers.

15 years agoPR10507: tweak MAXUPROBES calculation to shrink table for small static number of...
Frank Ch. Eigler [Fri, 21 Aug 2009 21:16:13 +0000 (17:16 -0400)]
PR10507: tweak MAXUPROBES calculation to shrink table for small static number of probes

* tapsets.cxx (uprobe_derived_probe_group::emit_module_decls): Use
  geometric mean rather than arithmetic mean.  Add a comment to explain
  relative harmlessness of exceeding the "minimum" or "maximum" values.

15 years agoPR10543: do module cache cleaning before copying new file into the cache
Frank Ch. Eigler [Fri, 21 Aug 2009 20:22:29 +0000 (16:22 -0400)]
PR10543: do module cache cleaning before copying new file into the cache

... otherwise the new stuff can get cleaned before use.

* cache.cxx (add_to_cache): Do clean_cache() first, not last.

15 years agoPR10544: clean up stap child process error handling
Frank Ch. Eigler [Fri, 21 Aug 2009 20:00:27 +0000 (16:00 -0400)]
PR10544: clean up stap child process error handling

* util.cxx (stap_system): Take extra verbosity value.  Standardize
  error handling / tracing.
* util.h: Corresponding changes.
* buildrun.cxx, main.cxx, modsign.cxx: Update callers.

15 years agocleanup: rename task_finder_target->pathname -> procname
Frank Ch. Eigler [Fri, 21 Aug 2009 17:29:50 +0000 (13:29 -0400)]
cleanup: rename task_finder_target->pathname -> procname

The previous name made it easy to misread the purpose of this
field.  It is only for matching executable names, not for
shared libraries.

* runtime/task_finder.c (task_finder_target): Rename field.
  (*): Adjust.
* tapset-itrace.cxx, tapset-utrace.cxx, tapsets.cxx, translate.cxx: Ditto.

15 years agoTwo minor testcase fixes.
David Smith [Thu, 20 Aug 2009 21:54:06 +0000 (16:54 -0500)]
Two minor testcase fixes.
* testsuite/systemtap.base/global_stat.exp: Improved error handling.
* testsuite/systemtap.base/strftime.exp: Ditto.

15 years ago* dtrace.in: Support -C, preprocess with cpp, which upstream postgres
Stan Cox [Thu, 20 Aug 2009 16:51:48 +0000 (12:51 -0400)]
* dtrace.in: Support -C, preprocess with cpp, which upstream postgres
  is now using.

15 years agoPR10537 process().function().label() should select multiple inlined instances.
Mark Wielaard [Thu, 20 Aug 2009 14:31:55 +0000 (16:31 +0200)]
PR10537 process().function().label() should select multiple inlined instances.

This is less useful than one would hope. gcc will often emit a label with
a DW_AT_low_pc that is not really in the neighbourhood of where one would
expect it when the label is inlined and gcc can proof the label isn't really
used in the optimized code. dwflpp::iterate_over_labels will now really
iterate recursively through the die, even for dies without a name (like
lexical blocks). This means we should now always find the concrete inlined
label instances that have a real DW_AT_low_pc and so we don't need the trick
to use the line table to get at the actual address.

* dwflpp.cxx (iterate_over_labels): Accept dies without a name. Don't handle
  labels without a name or without a lowpc attribute.
* testsuite/systemtap.base/inlinedvars.c (m): Trick gcc into thinking label
  is always used.
  (call, call2): Activate.
  (main): Call call and call2.
* testsuite/systemtap.base/inlinedvars.exp: New result_string.
  Test both unoptimized and optimized (inlined) builds.

15 years agoTwo minor testcase fixes.
David Smith [Thu, 20 Aug 2009 13:41:03 +0000 (08:41 -0500)]
Two minor testcase fixes.
* testsuite/systemtap.base/poll_map.exp: Improved error handling.
* testsuite/systemtap.base/postgres.exp: Fixed typo.

15 years agoPR10228: fix non-utrace building regression - cont'd
Wenji Huang [Thu, 20 Aug 2009 04:06:50 +0000 (00:06 -0400)]
PR10228: fix non-utrace building regression - cont'd

* runtime/task_finder.c (non-UTRACE): Return 0 for
  stap_start_task_finder.
* translate.cxx (emit_module_init): Let vma tracker
  specific to utrace.

15 years agoMerge branch 'master' of ssh://sourceware.org/git/systemtap
Josh Stone [Thu, 20 Aug 2009 01:34:18 +0000 (18:34 -0700)]
Merge branch 'master' of ssh://sourceware.org/git/systemtap

15 years agoGive a more exact error for dereferencing void*
Josh Stone [Thu, 20 Aug 2009 01:23:32 +0000 (18:23 -0700)]
Give a more exact error for dereferencing void*

* dwflpp.cxx (dwflpp::translate_components): Check for void* deref.

15 years agoPR10538: Give a file:line hint for anonymous types
Josh Stone [Thu, 20 Aug 2009 01:19:53 +0000 (18:19 -0700)]
PR10538: Give a file:line hint for anonymous types

When we list the possible members for an anonymous struct/union, the
user may want to go look at the source for the type.  That's hard
without a type name, so we now list the decl file:line for them.

* dwflpp.cxx (dwflpp::translate_components): List file:line for anon.

15 years agoCreate a dwarf_attr_die idiom
Josh Stone [Thu, 20 Aug 2009 00:27:18 +0000 (17:27 -0700)]
Create a dwarf_attr_die idiom

We commonly do a dwarf_attr_integrate followed by dwarf_formref_die,
with no care for the Dwarf_Attribute, so I captured that idiom in an
inline function.

* dwarf_wrappers.h (dwarf_attr_die): New.
* dwarf_wrappers.cxx (dwarf_type_name): Call dwarf_attr_die.
* dwflpp.cxx (dwflpp::print_members): Ditto.
  (dwflpp::find_struct_member): Ditto.
* tapsets.cxx (dwarf_derived_probe::saveargs): Ditto.
  (uprobe_derived_probe::saveargs): Ditto.
  (resolve_tracepoint_arg_type): Ditto.
  (tracepoint_derived_probe::build_args): Ditto.

15 years agoUse dwarf_diename instead of a DW_AT_name lookup
Josh Stone [Thu, 20 Aug 2009 00:07:30 +0000 (17:07 -0700)]
Use dwarf_diename instead of a DW_AT_name lookup

We should always use the canonical dwarf_diename.  The code being
replaced here wasn't even using dwarf_attr_integrate, so it may have
been missing the accessibility of some names.

* dwflpp.cxx (dwflpp::iterate_over_labels): Use dwarf_diename.

15 years agoUse dwarf_type_name in more places
Josh Stone [Wed, 19 Aug 2009 23:48:53 +0000 (16:48 -0700)]
Use dwarf_type_name in more places

* dwarf_wrappers.cxx (dwarf_type_name): Moved here from tapsets.cxx, and
  added a variant that returns a string for easier ostreaming.
* dwflpp.cxx (dwflpp::print_members): Use dwarf_type_name for errors.
  (dwflpp::find_struct_member): Ditto.
  (dwflpp::translate_components): Ditto.
  (dwflpp::translate_final_fetch_or_store): Ditto.
  (dwflpp::literal_stmt_for_pointer): Ditto.
* tapsets.cxx (dwarf_derived_probe::saveargs): Pass die to
  dwarf_type_name by pointer instead of reference.
  (uprobe_derived_probe::saveargs): Ditto.
  (resolve_tracepoint_arg_type): Ditto.

15 years agoPR10538: Use {...} for naming anonymous types
Josh Stone [Wed, 19 Aug 2009 21:40:53 +0000 (14:40 -0700)]
PR10538: Use {...} for naming anonymous types

* tapsets.cxx (dwarf_type_name): Handle NULL dwarf_diename.

15 years agoMerge branch 'master' of ssh://sources.redhat.com/git/systemtap
David Smith [Wed, 19 Aug 2009 21:02:26 +0000 (16:02 -0500)]
Merge branch 'master' of ssh://sources.redhat.com/git/systemtap

15 years agoUpdated with latest code.
David Smith [Wed, 19 Aug 2009 21:01:45 +0000 (16:01 -0500)]
Updated with latest code.
* runtime/transport/ring_buffer.c (_stp_ring_buffer_disable_cpu): New
  function.
  (_stp_ring_buffer_enable_cpu): Ditto.
  (_stp_ring_buffer_cpu_disabled): Ditto.
  (_stp_ring_buffer_empty_cpu): Only checks online cpus (instead of all
  possible cpus).
  (_stp_find_next_event): Ditto.
  (_stp_ring_buffer_iterator_increment): Calls
  _stp_ring_buffer_disable_cpu()/_stp_ring_buffer_enable_cpu() around
  ring_buffer_* calls.
  (_stp_ring_buffer_consume): Ditto.
  (_stp_peek_next_event): Ditto.
  (_stp_buffer_iter_finish): New function.
  (_stp_buffer_iter_start): Ditto.
  (_stp_data_read_trace): Uses
  _stp_buffer_iter_start()/_stp_buffer_iter_finish().
  (_stp_data_write_reserve): Checks to see if the cpu is disabled (with
  _stp_ring_buffer_cpu_disabled() before reserving memory.  Uses
  _stp_buffer_iter_start()/_stp_buffer_iter_finish().
  (_stp_transport_data_fs_init): Initializes buffer iterators.

15 years agoPR10538: Improve location lookup for unions
Josh Stone [Wed, 19 Aug 2009 20:30:31 +0000 (13:30 -0700)]
PR10538: Improve location lookup for unions

We had a bug that the starting call to find_struct_member used the same
memory for the parentdie and the resulting member.  If parentdie is a
union, then the first member probably won't have a location, and we
actually assert that it must be a union.  Since we wrote the result in
the same memory, we lost the real info about the parent, and so the
assertion failed.

* dwflpp.cxx (dwflpp::translate_components): Use distinct memory for the
  parent and resulting member in the call to find_struct_member.
  (dwflpp::find_struct_member): Remove the needless parentdie copy.

15 years ago* testsuite/systemtap.base/postgres.exp: New test for checking sdt
Stan Cox [Wed, 19 Aug 2009 20:11:09 +0000 (16:11 -0400)]
* testsuite/systemtap.base/postgres.exp: New test for checking sdt
  marker support as used by postgres.  Currently assumes, and
  verifies, that postgres is installed in /usr/local

15 years agoPR10228: fix non-utrace building regression
Frank Ch. Eigler [Wed, 19 Aug 2009 16:18:48 +0000 (12:18 -0400)]
PR10228: fix non-utrace building regression

* translate.cxx (dump_unwindsyms): Decide based on modname[] not
  mainfile[] to emit a vmcb.
* runtime/task_finder.c (non-UTRACE): Include dummy stap_{start,stop}_*
  functions.

15 years agoImproved testcase error handling.
David Smith [Wed, 19 Aug 2009 16:20:59 +0000 (11:20 -0500)]
Improved testcase error handling.
* testsuite/systemtap.base/arith.exp: Improved error handling.
* testsuite/systemtap.base/cmd_parse.exp: Ditto.

15 years agoImproved systemtap.printf/sharedbuf.exp testcase.
David Smith [Wed, 19 Aug 2009 15:15:21 +0000 (10:15 -0500)]
Improved systemtap.printf/sharedbuf.exp testcase.
* testsuite/systemtap.printf/sharedbuf.exp: Handles failure better and
  possible modpost warnings.

15 years agoFix typo in sdt_types.stp (missing newline).
Mark Wielaard [Wed, 19 Aug 2009 09:58:44 +0000 (11:58 +0200)]
Fix typo in sdt_types.stp (missing newline).

* testsuite/systemtap.base/sdt_types.stp (int_var): Add \n to printf.

15 years agoPR10495: allow multiple probe aliases with same name
Frank Ch. Eigler [Wed, 19 Aug 2009 00:12:57 +0000 (20:12 -0400)]
PR10495: allow multiple probe aliases with same name

* elaborate.cxx (match_node::bind): Change ->end to ->ends[] vector.
  (find_and_build,build_no_more): Iterate over ends[].
* elaborate.h: Corresponding changes.
* testsuite/semok/thirtyfour.stp: New test.
* NEWS, doc/langref.tex: Note this.

15 years agoAUTHORS update
Josh Stone [Tue, 18 Aug 2009 22:59:37 +0000 (15:59 -0700)]
AUTHORS update

15 years agoPR10512 STAP_PROBES don't work in c++ constructors/destructors testcase.
Mark Wielaard [Tue, 18 Aug 2009 21:03:00 +0000 (23:03 +0200)]
PR10512 STAP_PROBES don't work in c++ constructors/destructors testcase.

* testsuite/systemtap.base/cxxclass.exp: New file.
* testsuite/systemtap.base/cxxclass.stp: Likewise.
* testsuite/systemtap.base/cxxclass.cxx: Likewise.

15 years agoPR10512 Referencing computed goto labels in c++ constructors does work.
Mark Wielaard [Tue, 18 Aug 2009 20:08:51 +0000 (22:08 +0200)]
PR10512 Referencing computed goto labels in c++ constructors does work.

PR10533 inlined vars are not always found was fixed which means we
no longer need to prevent inlining of the STAP_PROBE macros.

* includes/sys/sdt.h (STAP_UNINLINE_LABEL): Removed.
  (STAP_PROBE[1-9]_): Remove label: and STAP_UNINLINE_LABEL.

15 years agoAdd testcase for PR10533 (inlined vars) and 10537 (inlined labels - disabled)
Mark Wielaard [Tue, 18 Aug 2009 20:01:53 +0000 (22:01 +0200)]
Add testcase for PR10533 (inlined vars) and 10537 (inlined labels - disabled)

Partial testcase for PR10533 (inlined vars) and 10537 (inlined labels)
currently we cannot use the full testcase since stap doesn't support
probing multiple instances of inlined labels.

* testsuite/systemtap.base/inlinedvars.exp: New file.
* testsuite/systemtap.base/inlinedvars.stp: Likewise.
* testsuite/systemtap.base/inlinedvars.c: Likewise.

15 years agoPR10533 inlined vars are not always found (dwflpp).
Mark Wielaard [Tue, 18 Aug 2009 19:54:54 +0000 (21:54 +0200)]
PR10533 inlined vars are not always found (dwflpp).

dwflpp::find_variable_and_frame_base switched too early to "pyshical view"
of die tree. We need to lookup the var in the "syntactical view" of the die
tree first. Then when we see a DW_TAG_inlined_subroutine while walking the
syntactical die tree as returned by dwarf_getscopes for a given variable
to retrieve the frame base, then we need to switch to walking the physical
die tree where the subroutine is inlined.

* dwflpp.cxx (find_variable_and_frame_base): Don't immediately go to
  die_scopes, but lookup var first based on pc. Then switch "die branches"
  when searching for frame base and a DW_TAG_inlined_subroutine is
  encountered.

15 years agoPR10533 inlined vars are not always found (lo2c-test off-by-one).
Mark Wielaard [Tue, 18 Aug 2009 19:52:59 +0000 (21:52 +0200)]
PR10533 inlined vars are not always found (lo2c-test off-by-one).

* loc2c-test.c (handle_variable): Set inner to zero after
  calling dwarf_getscopes_die(), for loop will increase inner.

15 years agoPR10518: context shrinkage with function recursion analysis feeding MAXNESTING
Frank Ch. Eigler [Tue, 18 Aug 2009 19:52:02 +0000 (15:52 -0400)]
PR10518: context shrinkage with function recursion analysis feeding MAXNESTING

* translate.cxx (emit_common_header, translate_pass): Use new
  recursion_info visitor to calculate appropriate MAXNESTING value for
  scripts with or without recursion.
* tapsets.cxx (common_probe_entryfn_prologue): Initialize c->nesting = -1.
* stap.1.in: Clarify MAXNESTING value.

15 years agoAdapt tracepoints to the new probe_locals union
Josh Stone [Tue, 18 Aug 2009 17:54:11 +0000 (10:54 -0700)]
Adapt tracepoints to the new probe_locals union

* tapsets.cxx (tracepoint_derived_probe_group::emit_module_decls): Use
  probe_locals to set the tracepoint arguments for the probe.
* testsuite/systemtap.base/tracepoints.exp: Include the arguments in the
  pass-4 tracepoint test.

15 years agoPR10516: reduce context size
Frank Ch. Eigler [Tue, 18 Aug 2009 16:26:26 +0000 (12:26 -0400)]
PR10516: reduce context size

* translate.cxx (emit_common_header): Emit probe locals into
  a separate union, not into the locals[] array.
  (emit_probe): Adapt.

15 years agoelfutils build tweak: run nested configure with bash, add -fgnu89-inline
Frank Ch. Eigler [Tue, 18 Aug 2009 15:37:27 +0000 (11:37 -0400)]
elfutils build tweak: run nested configure with bash, add -fgnu89-inline

* configure.ac: Tweak --with-elfutils nested configure invocation.
* rest of auto* files: regenerated with fedora-11 tools

15 years ago* dtrace.in: Honor the dirname for the output file.
Stan Cox [Tue, 18 Aug 2009 14:50:05 +0000 (10:50 -0400)]
* dtrace.in: Honor the dirname for the output file.
* testsuite/systemtap.base/dtrace.exp: New test.

15 years agoPR10533 loc2c doesn't resolve frame base correctly for inlined vars.
Mark Wielaard [Tue, 18 Aug 2009 13:50:40 +0000 (15:50 +0200)]
PR10533 loc2c doesn't resolve frame base correctly for inlined vars.

When we see a DW_TAG_inlined_subroutine while walking the syntactical
die tree as returned by dwarf_getscopes for a given variable to retrieve
the frame base, then we need to switch to walking the physical die tree
where the subroutine is inlined.

* loc2c-test.c (handle_variable): Switch "die branches" when searching
  for frame base and a DW_TAG_inlined_subroutine is encountered.

15 years agoPrint DIE offsets in loc2c-test scope dumps.
Roland McGrath [Tue, 18 Aug 2009 09:27:38 +0000 (02:27 -0700)]
Print DIE offsets in loc2c-test scope dumps.

15 years agoUnlocks global variables, then calls _stp_print_flush().
David Smith [Mon, 17 Aug 2009 17:27:15 +0000 (12:27 -0500)]
Unlocks global variables, then calls _stp_print_flush().
* translate.cxx (c_unparser::emit_probe): Unlocks global variables, then
  calls _stp_print_flush() (instead of the other way around).

15 years agoCache failed tracepoint headers too
Josh Stone [Sat, 15 Aug 2009 00:56:46 +0000 (17:56 -0700)]
Cache failed tracepoint headers too

Rather than re-attempting a tracepoint header that fails to compile, we
now save an empty file into the cache to indicate "nothing to see here."
See also PR10424.

* tapsets.cxx (tracepoint_builder::get_tracequery_module): Use /dev/null
  as the empty result file if make_tracequery fails.
  (tracepoint_builder::init_dw): Ignore empty tracequery modules.

15 years agoPR10228: use task_finder_vma for -d /user/object files.
Frank Ch. Eigler [Fri, 14 Aug 2009 02:53:44 +0000 (22:53 -0400)]
PR10228: use task_finder_vma for -d /user/object files.

* main.cxx (main): For "-d /path" arguments, enable task finder.
* runtime/sym.h (_stp_module): Add *vmcb member.
* task_finder{.cxx,.h} (emit_vma_callback_probe_decl): Zap.
* tapset-itrace.cxx, tapset-utrace.cxx: Use unwindsyms_modules
  instead.
* tapsets.cxx (uprobe::emit_module_decls): Ditto.
* translate.cxx (emit_module_init): Emit task finder registrations
  for vmcb's associated with _stp_modules.
  (dump_unwindsyms): Associate vmcbs with user-space unwindsyms entries.

15 years agousability: don't suppress pass-4 compiler errors
Frank Ch. Eigler [Thu, 13 Aug 2009 20:04:56 +0000 (16:04 -0400)]
usability: don't suppress pass-4 compiler errors

... since a pass-4 compilation error is just as bad as pass-2 error.

* buildrun.cxx (run_make_cmd): Remove "2>&1".

15 years agoAdd missing quote for uname.tcl
Wenji Huang [Fri, 14 Aug 2009 05:51:36 +0000 (01:51 -0400)]
Add missing quote for uname.tcl

* testsuite/systemtap.exelib/uname.tcl: Add '"'.

15 years agoPR10507: tweak heuristics for stap_uprobes[] allocation
Frank Ch. Eigler [Wed, 12 Aug 2009 20:07:08 +0000 (16:07 -0400)]
PR10507: tweak heuristics for stap_uprobes[] allocation

* tapsets.cxx (uprobes::emit_module_decls): Compute MAXUPROBES
  with x-treme kl3v3rn3ss.
* stap.1.in: Clarify MAXUPROBES.

15 years agoPR10461: Probe identical functions only once
Josh Stone [Wed, 12 Aug 2009 00:01:35 +0000 (17:01 -0700)]
PR10461: Probe identical functions only once

In C++ especially, a function definition in a header may be compiled
into multiple CUs, but the linker will merge those into a single output
function.  We don't want to place multiple probes on the same function.

The dupe-detection from the alias code (commit 1c6b77e5) already tracks
identical functions within a CU, so I've just lifted this to instead
track function entrypcs at the module level.

* dwflpp.cxx (dwflpp::iterate_over_functions): Remove dupe checks.
* tapsets.cxx (dwarf_query): Add alias_dupes set to the query.
  (dwarf_query::handle_query_module): Reset the dupes for each module.
  (query_dwarf_func): Check that we only probe each entrypc once.

15 years agoDon't call dwarf_lowpc after dwarf_entrypc fails
Josh Stone [Tue, 11 Aug 2009 21:59:41 +0000 (14:59 -0700)]
Don't call dwarf_lowpc after dwarf_entrypc fails

The implementation of dwarf_entrypc already checks for _lowpc, so it's
redundant for us to attempt a _lowpc call too.

* dwflpp.cxx (dwflpp::function_entrypc): Remove XXX comment.
  (dwflpp::die_entrypc): Don't bother with _lowpc if _entrypc fails

15 years agoImproved context.exp error handling.
David Smith [Tue, 11 Aug 2009 22:08:47 +0000 (17:08 -0500)]
Improved context.exp error handling.
* testsuite/systemtap.context/context.exp: Makes sure errors are output to
  the log file.  Also, a Makefile is copied with 'cp -p' to avoid make
  erroring out if the Makefile's date is in the future (as can be the case
  if running the test over nfs).
* testsuite/systemtap.context/args.tcl: Makes sure 'close' errors are
  ignored.
* testsuite/systemtap.context/backtrace.tcl: Ditto.

15 years agoAdd 'unused' attribute to module_data and module_size arguments of check_permissions.
Dave Brolley [Tue, 11 Aug 2009 15:57:04 +0000 (11:57 -0400)]
Add 'unused' attribute to module_data and module_size arguments of check_permissions.

15 years agoexelib testcase now ensures uprobes.ko is up to date.
David Smith [Tue, 11 Aug 2009 13:40:49 +0000 (08:40 -0500)]
exelib testcase now ensures uprobes.ko is up to date.
* testsuite/systemtap.exelib/cleanup.tcl: Makes sure uprobes.ko is up to
  date.
* testsuite/systemtap.exelib/lib.tcl: Ditto.
* testsuite/systemtap.exelib/mark.tcl: Ditto.
* testsuite/systemtap.exelib/uname.tcl: Ditto.
* testsuite/systemtap.exelib/ustack.tcl: Ditto.

15 years agoRH516691. SSL typo in manpage.
Mark Wielaard [Tue, 11 Aug 2009 07:49:00 +0000 (09:49 +0200)]
RH516691. SSL typo in manpage.

* stap-server.8.in: Fix SLL typo to read SSL.

15 years agoAvoid assertion error for no matched function in statement probe
Wenji Huang [Mon, 10 Aug 2009 23:29:50 +0000 (19:29 -0400)]
Avoid assertion error for no matched function in statement probe

* dwflpp.cxx (iterate_over_functions): Return for NULL pointer.
* testsuite/systemtap.base/statement.exp: Add test case.

15 years agoMerge branch 'master' of ssh://sourceware.org/git/systemtap
Josh Stone [Mon, 10 Aug 2009 22:17:35 +0000 (15:17 -0700)]
Merge branch 'master' of ssh://sourceware.org/git/systemtap

15 years agoPR10499: Integrate attributes in dwarf_decl_file/line
Josh Stone [Mon, 10 Aug 2009 21:48:39 +0000 (14:48 -0700)]
PR10499: Integrate attributes in dwarf_decl_file/line

Elfutils prior to 0.143 didn't use attr_integrate when looking up the
decl_file or decl_line, so the attributes would sometimes be missed.
For those old versions, we define custom implementations to do the
integration.

* dwarf_wrappers.cxx (dwarf_decl_file_integrate): New.
  (dwarf_decl_line_integrate): New.
* dwarf_wrappers.h: Add macros to redirect calls to the above functions.
* dwflpp.cxx (dwflpp::iterate_over_labels): Replace a manual attribute
  lookup that is the same as dwarf_decl_line.

15 years agoSimplify _ELFUTILS_PREREQ checking
Josh Stone [Mon, 10 Aug 2009 20:01:30 +0000 (13:01 -0700)]
Simplify _ELFUTILS_PREREQ checking

We were jumping through a few hoops to deal with elfutils < 0.138 that
did not have the _ELFUTILS_PREREQ macro.  I've added an always-false
dummy macro to take its place when it doesn't exit.  All of the other
"#ifdef _ELFUTILS_PREREQ" ugliness can now go away.

15 years agoMerge branch 'master' of ssh://mark@sourceware.org/git/systemtap
Mark Wielaard [Mon, 10 Aug 2009 16:28:40 +0000 (18:28 +0200)]
Merge branch 'master' of ssh://mark@sourceware.org/git/systemtap

15 years agoPR10506 experiment: use /sbin/insmod for uprobes.ko loading
Frank Ch. Eigler [Mon, 10 Aug 2009 16:13:31 +0000 (12:13 -0400)]
PR10506 experiment: use /sbin/insmod for uprobes.ko loading

* runtime/staprun/staprun.c (enable_uprobes): insmod, not insert_module().

15 years agoOnly add extra error on no probes found if no previous errors already shown.
Mark Wielaard [Mon, 10 Aug 2009 15:44:31 +0000 (17:44 +0200)]
Only add extra error on no probes found if no previous errors already shown.

* elaborate.cxx (semantic_pass): Don't add "no probes found" if session
  already had other errors.

15 years agoIt is not an error or warning if the local database of authorized signing
Dave Brolley [Mon, 10 Aug 2009 15:47:17 +0000 (11:47 -0400)]
It is not an error or warning if the local database of authorized signing
certificates does not exist. It just means that the signed module is untrusted.

15 years agoUse nop instructions without parameters on arm
Eugeniy Meshcheryakov [Sat, 8 Aug 2009 13:51:44 +0000 (15:51 +0200)]
Use nop instructions without parameters on arm

Fixes FTBFS, see
https://buildd.debian.org/fetch.cgi?pkg=systemtap;ver=0.9.9-1;arch=armel;stamp=1249664825

15 years agoZap dwarf_diename_integrate
Josh Stone [Sat, 8 Aug 2009 01:51:19 +0000 (18:51 -0700)]
Zap dwarf_diename_integrate

The dwarf_diename in elfutils learned a long time ago to use
dwarf_attr_integrate when looking up the name.  Our minimum elfutils
0.126 has this, so we don't need to kludge it ourselves.

15 years agoMake files executable
Eugeniy Meshcheryakov [Fri, 7 Aug 2009 14:40:18 +0000 (16:40 +0200)]
Make files executable

15 years agoDo not use plain [] in help string in configure.ac
Eugeniy Meshcheryakov [Fri, 7 Aug 2009 14:31:36 +0000 (16:31 +0200)]
Do not use plain [] in help string in configure.ac

This confuses Debian's automake.

This page took 0.07918 seconds and 5 git commands to generate.