Changed it so we always use session.print_warning() rather than
an explicit call to clog or cerr. (There are a few cases where
the session is not available, so they were left as is, but
marked up with an // XXX needs-session comment.)
Also changed print_warning() to check for suppress_warnings, so
we no longer have to explicitly check for it when calling
print_warning(). There are a few cases where I left in the
explicit check, specifically when there was more code than
just a simple call to print_warning() within it.
Also standardized the use of "WARNING:". All warnings should now
use "WARNING:" rather than "Warning:" or "warning:".
Frank Ch. Eigler [Tue, 20 Dec 2011 20:49:35 +0000 (15:49 -0500)]
PR13489: don't confuse staprun's "is uprobes in the kernel?" logic
After recent commits associated with PR13489, a stap module may
include a few symbols named kallsyms_*, specifically
*unregister_uprobe. This confused staprun's simpleminded grep on
/proc/kallsyms to guess that uprobes per se was in the kernel, even
though it was just some peer stap module. So now grep for a more
picky regexp, including all-important whitespace.
* runtime/staprun/staprun.c (enable_uprobes): Look for
" unregister_uprobe\t" instead of "unregister_uprobe".
William Cohen [Fri, 16 Dec 2011 18:40:01 +0000 (13:40 -0500)]
Add the speculative.stp tapset
The speculative.stp tapset allow one to speculative add things to
output buffers and then later commit or discard the information in the
buffers. Four functions in the tapset:
speculation() - function to give an id for speculative buffer
speculate() - add output to a speculative buffer
discard() - remove output for a speculative buffer
commit() - output data for a speculative buffer
Frank Ch. Eigler [Mon, 19 Dec 2011 14:03:58 +0000 (09:03 -0500)]
PR13489, the neverending kludge story. Resolve RHEL5's old utrace conflicts.
RHEL5's old utrace uses utrace_native_view() instead of
task_user_regset_view(), so we shouldn't be so stuck on trying to find
it. To add insult to injury, any attempt to use kallsyms* to look up
the latter results in an unloadable module since kallsyms* is not
exported in these old kernels.
* transport/transport.c (_stp_transport_init): Only look for
task_user_regset_view for other than old rhel5 utrace.
Frank Ch. Eigler [Sun, 18 Dec 2011 16:50:14 +0000 (11:50 -0500)]
PR13489 finale (?): tolerate non-existent task_user_regset_view
* runtime/loc2c-runtime.h: Tweak task_user_regset_view-substitute macro
to return 0 on failed kallsyms.
* runtime/transport/transport.c: Don't have a cow if task_user_regset_view
is missing, like on older ARM kernels.
David Smith [Fri, 16 Dec 2011 20:32:20 +0000 (14:32 -0600)]
Rename tapset/rpc.stp variable to indicate its internal-only nature.
* tapset/rpc.stp (_sunrpc.clnt.create_client.rpc_new_client_inline):
Rename 'args' to '__args' to indicate that '__args' is an internal-only
variable. Deprecate old name.
* NEWS: Mention 'args' variable deprecation.
* stap.1: Ditto.
Mark Wielaard [Fri, 16 Dec 2011 18:25:32 +0000 (19:25 +0100)]
task_finder_vma.c (__stp_tf_vma_new_entry): No unnecessary atomic allocs.
We can be a little nicer when allocating kernel memory under the
traditional task_finder which uses utrace. See
http://sourceware.org/ml/systemtap/2011-q4/msg00357.html
Mark Wielaard [Fri, 16 Dec 2011 15:59:00 +0000 (16:59 +0100)]
modname/symdata: Try harder to retrieve module name when requested.
When the user really wants a kernel module name with an address and
we are unable to map it to any existing one then fall back on using
__module_text_address() with appropriate locking.
Mark Wielaard [Fri, 16 Dec 2011 15:43:04 +0000 (16:43 +0100)]
_stp_vma_mmap_cb: Also extend mapping that don't overlap but are connected.
If a vma mapping for a module already exist but a new mapping for the module
is added that is connected right at the end of it, then just extend the
existing vma mapping. This fixes the exelib.exp testcase on s390x for PIE
executables.
William Cohen [Thu, 15 Dec 2011 16:27:45 +0000 (11:27 -0500)]
Adjust periodic.stp example to run on kernels without struct delayed_work
RHEL-5 kernels have the timer_expire_entry tracepoint, but do not have
struct delayed_work. Some @defined magic is used to select the
fallback if struct delayed_work is not around.
Dave Brolley [Tue, 13 Dec 2011 21:08:38 +0000 (16:08 -0500)]
PR 13496: stap could show some progress of the communication with the server
- Moved "Using a compile server" message to -v level
- Moved details of automatic server detection to -vv level
- Moved reasons for server acceptance/rejection to -vvv level
- Moved details of clent/server request/response packaging to -vvvv level.
David Smith [Tue, 13 Dec 2011 17:33:38 +0000 (11:33 -0600)]
Add HAVE_TASK_FINDER define to simplify some code.
* runtime/runtime.h: Add HAVE_TASK_FINDER define if we've got any form of
utrace.
* runtime/task_finder.c: Use HAVE_TASK_FINDER to know whether to define
dummy functions.
* runtime/vma.c (_stp_vma_init): Use HAVE_TASK_FINDER define.
Frank Ch. Eigler [Mon, 12 Dec 2011 22:50:59 +0000 (17:50 -0500)]
configury: fix make -j all install
Due to an autoconf weirdness, make -j all install would run make
all-recursive and make install-recursive in parallel, and let the two
builds step on each others' toes.
* Makefile.am (install): Explicitly require all. Recurse by hand.
* Makefile.in: Regenerated.
Mark Wielaard [Mon, 12 Dec 2011 21:52:18 +0000 (22:52 +0100)]
PR13467 Provide alternative testcase for pointer_array.exp.
pointer_array.exp depends on indexing an array from a user pointer in
kernel context. This doesn't work on s390x, which has separate user and
kernel space addresses. kallsyms_expand_symbol.exp decodes the kallsyms
table from kernel space using various array pointer manipulations.
Mark Wielaard [Mon, 12 Dec 2011 14:54:59 +0000 (15:54 +0100)]
Protect just the transport state with _stp_transport_mutex.
_stp_transport_mutex was held over the whole of _stp_handle_start()
and _stp_cleanup_and_exit(). This is unnecessary and dangerous since
some functions that get called could sleep. Add a new state variable
_stp_start_called and protect just that together with _stp_exit_called
to make sure _stp_handle_start() and _stp_cleanup_and_exit() are only
executed once.
Frank Ch. Eigler [Mon, 12 Dec 2011 14:28:23 +0000 (09:28 -0500)]
PR13489: support inode-uprobes without EXPORT_SYMBOL*'s
Until lkml sees fit to EXPORT_SYMBOL* various inode-uprobes related
symbols, we must kludge around this.
* buildrun.cxx (compile_pass): Track export status for
register_uprobe, unregister_uprobe, task_user_regset_view.
* runtime/runtime.h: Declare void* versions if needed.
* runtime/transport/transport.c: kallsyms_lookup_name them if needed.
* runtime/loc2c-runtime.h, runtime/uprobes-inode.c: Use them.
Mark Wielaard [Fri, 9 Dec 2011 14:24:03 +0000 (15:24 +0100)]
Move __stp_tf_vma_map check from commit 972ea1 to stap_find_vma_map_info().
Commit 972ea1 misapplied the check to stap_add_vma_map_info. This can
never be called when the vma tracker hasn't been initialized. But
stap_find_vma_map_info[_user] potentially could be called. And so this
function needs to check that sure__stp_tf_vma_map is initialized.
Mark Wielaard [Fri, 9 Dec 2011 09:46:20 +0000 (10:46 +0100)]
PR11671 Allocate __stp_tf_vma_entry dynamically.
Get rid of TASK_FINDER_VMA_ENTRY_ITEMS and __stp_tf_vma_free_list_items
array list completely. All __stp_tf_vma_entry are allocated dynamically
now. This is possible since stap_add_vma_map_info() is only called
through the task_finder from a user context.
There is no more fixed maximum number of VMA pages that will be tracked
at runtime. This reduces memory use for those scripts that don't need any,
or only limited target process VMA tracking and allows easier system
wide probes inspecting shared library variables and/or user backtraces.
stap will now silently ignore -DTASK_FINDER_VMA_ENTRY_ITEMS.
tracepoints: tolerate kernel event headers without their own #include <linux/tracepoint.h>
include/trace/events/writeback.h lacks this, which means that
systemtap tracepoint _aux.o files fail to build.
* tapsets.cxx (tracepoint_derived_probe_group::emit_module_decls): Generously
offer to emit the possibly missing #include <...> into the FOO_aux_N.c file.
Mark Wielaard [Thu, 8 Dec 2011 16:09:55 +0000 (17:09 +0100)]
Introduce stap_destroy_vma_map and allocate vma free at vma init time.
We don't keep a static __stp_tf_vma_free_list_items anymore, but allocate
the items once in stap_initialize_vma_map(), which can now return failure
when there isn't enough memory. Make sure to call stap_destroy_vma_map()
when the module is unloaded to clean up.
Chris Meek [Thu, 8 Dec 2011 17:41:00 +0000 (12:41 -0500)]
PR13076: Added time interval to cache cleaning
cache.cxx:
Added a new file to the cache - cache_clean_interval_s - to keep
track of the new cache clean time interval. Now the cache will
only be cleaned when the time since the previous clean is longer
than the interval, rather than every time a new entry is added
to the cache. The default interval is 30 sec.
Dave Brolley [Tue, 6 Dec 2011 21:32:26 +0000 (16:32 -0500)]
staprun: User privilege checking in restricted environments.
- Make sure staprun builds with all combinations of HAVE_ELF and
HAVE_ELF_GETSHDRSTRNDX.
- When HAVE_ELF_GETSHDRSTRNDX is not defined, we must assume the
highest required privilege level for signed modules (stapsys).
Josh Stone [Mon, 5 Dec 2011 21:04:19 +0000 (13:04 -0800)]
tapset: Make addr_to_node ignore !NODE_DATA(nid)
In the block added for RHEL4 compatibility, there was even a comment
indicating that we'd like to skip nodes that aren't online. We can't
make that check due to missing an EXPORT for node_online_map, but
checking for a non-NULL pointer for NODE_DATA(nid) gets approximately
the same result.
* session.cxx (parse_cmdline): Parse it.
(usage): Note it.
* session.h (modinfos): Store it.
* hash.cxx (find_script_hash): Mix it.
* translate.cxx (translate_pass): Use it.
* testsuite/systemtap.base/modinfo.exp: Lightly test it.
* NEWS, stap.1: Document it.
Mark Wielaard [Thu, 1 Dec 2011 19:26:19 +0000 (20:26 +0100)]
_stp_get_mm_counter: Fix kernel version check.
The kernel version check was wrong in two ways. First it tested against
kernel_v >= "3.1.0" but linux commit 172703 "mm: delete non-atomic mm
counter implementation" was actually integrated for 3.0. But fedora
names their 3.0 kernels 2.6.40 (and 3.1 kernels 2.6.41, depending on
release). So change the test to kernel_v >= "2.6.40".
The reason this wasn't found earlier was that there is another check
for CONFIG_NR_CPUS >= CONFIG_SPLIT_PTLOCK_CPUS which is almost always
true (but not on arm tegra kernels).
Mark Wielaard [Thu, 1 Dec 2011 19:22:51 +0000 (20:22 +0100)]
systemtap.examples/check.exp: Don't try running tests that failed to build.
Just mark them UNTESTED if the build phase FAILed. This also saves time
since the run phase will try to build the testcase again (and will always
FAIL doing that).
David Smith [Thu, 1 Dec 2011 17:49:41 +0000 (11:49 -0600)]
Fix the dtrace_clone.exp test to properly test with/without semaphores.
* testsuite/systemtap.clone/dtrace_clone.exp: Use the correct #define to
get rid of the semaphores.
* testsuite/systemtap.clone/dtrace_clone.c: Be sure to ifdef out all the
semaphores.
git://sourceware.org / systemtap.git / log