David Smith [Tue, 19 Sep 2017 15:51:54 +0000 (10:51 -0500)]
Fix PR22158 by updating the runtime to handle the removal of spin_unlock_wait.
* runtime/stp_helper_lock.h: Removed stp_spin_unlock_wait(), since the
underlying kernel functionality was removed in kernel commit d3a024abbc43827785.
* runtime/stp_utrace.c (utrace_finish_stop): Instead of calling
stp_spin_unlock_wait(), just try to lock and unlock the spin lock.
William Cohen [Fri, 15 Sep 2017 15:37:36 +0000 (11:37 -0400)]
Avoid pulling in old compatibility RPM 4.4 API
RPM 4.14.0 rc1 removes a number of RPM 4.4 compatibility APIs enabled by
_RPM_4_4_COMPAT define. SystemTap has been updated to the newer API
and keeping this define causes the build to fail on Fedora rawhide.
David Smith [Thu, 14 Sep 2017 21:42:55 +0000 (16:42 -0500)]
Update systemtap.stress/conversions.exp.
* testsuite/systemtap.stress/conversions.exp (run_conv_test): Turn off
overload protection so that we get the right errors ("copy fault") and
not the wrong errors ("probe took too long").
The bpf infrastructure has a complex graph data types, which are
created, mutated, partly deleted, added etc., representing a
worst-case scenario for a statically typed non-GC system like c++.
The following little test case triggers memory corruption
(access-after-free).
./stap --runtime=bpf -p4 -e 'probe kernel.function("sys_open")
{x = 1; if (x) x = 0; else x = 2 } '
This patch disables some of the responsible code - by turning off
program::program destructors' detailed cleanup of the embedded graph
structure. So we leak memory instead. :-(
Another little hunk deals with an un-C++-ish typecasting error that
valgrind also caught (operator new[] vs. free() on same pointer).
David Smith [Tue, 12 Sep 2017 21:15:47 +0000 (16:15 -0500)]
Improve fix for PR22117 by updating the translator.
* dwflpp.cxx (dwflpp::translate_base_ref): Add an even better fix to the
number of bytes comparison to avoid "noncontiguous location for base
fetch" semantic error on 32-bit systems (and not break 64-bit systems).
David Smith [Tue, 12 Sep 2017 18:51:07 +0000 (13:51 -0500)]
Fix PR22124 by properly handling perf counter reads in uretprobes.
* tapsets.cxx (uprobe_derived_probe_group::emit_module_utrace_decls): Be
sure to properly handle perf counter reads in uretprobes.
* testsuite/systemtap.base/perf.exp: If this system doesn't support
hardware perf probes, try with software perf probes.
* testsuite/systemtap.base/perf03sw.stp: New file.
* testsuite/systemtap.base/perf04sw.stp: Ditto.
David Smith [Fri, 8 Sep 2017 19:08:18 +0000 (14:08 -0500)]
Fix PR22110 by updating the translator.
* loc2stap.cxx (location_context::new_symref): Set sym->referent to avoid
"internal error: unresolved symbol 'pointer'" when processing
semok/autocast07.stp.
David Smith [Fri, 8 Sep 2017 19:05:37 +0000 (14:05 -0500)]
Fix PR22117 by updating the translator.
* dwflpp.cxx (dwflpp::translate_base_ref): Fix number of bytes comparison
to avoid "noncontiguous location for base fetch" semantic error on
32-bit systems.
stapregex PR15065 (8/8) :: add back re2c's mini-optimizer
* stapregex-tree.cxx (ins_optimize): New function.
(regexp::compile): Initialize i.marked in newly allocated ins to
stop a harmless but very noisy Valgrind complaint.
* stapregex-tree.h (ins_optimize): New function.
* stapregex-dfa.cxx (stapregex_compile): Invoke ins_optimize.
This is the only part of the TNFA functionality that touches
the kernel, so it is crucially important to review for safety.
* stapregex.cxx (stapdfa::emit_declaration): Set up and clean
up tag state, define additional YY* macros used by TNFA actions.
* stapregex-dfa.cxx (span::emit_jump): Add diagnostic printing,
continue matching even after entering an accepting state.
(span::emit_final): Emit finalizer TNFA action, save final
tags if the finalizer produced a suitable longest-match.
(state::emit): Add diagnostic printing, handle unknown chars.
(dfa::emit): Set up tags, emit initializer TNFA action, emit
finalizer when the regex accepts at the first char.
(dfa::emit_action): New function.
(dfa::emit_tagsave): Vestigial functionality -- just sets ntags.
* stapregex-dfa.h (dfa::emit_action): New function.
* stapregex-dfa.cxx: Implement Laurikari's TNFA algorithm.
(arc_priority::refine_higher, ::refine_lower): Detect overflow.
(arc_compare): Previous implementation was incorrect, fix it.
(dfa::add_map_item): New function.
(te_closure): Properly consider arc_priorities.
(same_ins): New function.
(dfa::find_equivalent): Algorithm to compute reordering actions.
(dfa::compute_action): Algorithm to compute TNFA actions.
(dfa::compute_finalizer): Algorithm to compute finalizers.
(dfa::dfa): Consider arc_priorities and reordering actions.
(operator << for map_item): New function.
(operator << for tdfa_action): Use << for map_item.
(kernel_point::print): New function.
(state::print): Include diagnostic info for TNFA algorithm.
(operator << for state): New function.
(operator << for dfa): New function.
* stapregex-dfa.h (operator << for map_item): New function.
(struct tdfa_insn): Add save_tag option for finalizers.
(kernel_point::print): New function.
(struct span): Add jump_pairs field.
(struct state): Add dfa field to access containing DFA. Also
add accept_kp field to track TNFA actions for accepting states.
(state::state): Add dfa field to constructor.
(state::print): Use ordinary ostream, not translator_output.
(operator << for state): New function.
(struct dfa): Add success_outcome and fail_outcome field to
explicitly track the indices of 'accept' and 'fail' outcomes.
(dfa::dfa): Add an option to set index of 'accept' outcome.
(dfa::add_map_item): New function.
(dfa::compute_action): New function.
(dfa::compute_finalizer): New function.
* stapregex.cxx (regex_to_stapdfa): Add comment -- here is how
you can force TNFA tag operations to be generated even when the
stap script doesn't request any groups.
stapregex PR15065 (4/8) :: switch DFA engine to an unsigned char type
* stapregex-defines.h: New file. The rchar type is an unsigned
char. Within an NFA or DFA, rchar 128 is used to represent
unknown characters (i.e., anything that does not fit within
the ASCII standard encoding). This is placeholder functionality
meant to sanely handle other encodings such as UTF prior to
implementing full support for them.
* stapregex-dfa.h, stapregex-dfa.cxx: Use rchar throughout.
* stapregex-parse.h, stapregex-parse.cxx: Use rchar throughout.
* stapregex-tree.h, stapregex-tree.cxx: Use rchar throughout.
* stapregex.h: Use rchar throughout.
* session.h (systemtap_session):
Replace dfa_maxstate with dfa_maxmap.
* session.cxx (systemtap_session::systemtap_session):
Replace dfa_maxstate with dfa_maxmap.
* translate.cxx (systemtap_session):
Replace dfa_maxstate with dfa_maxmap.
* stapregex-dfa.h (struct dfa): New variable nmapitems.
* stapregex.h (stapdfa::num_map_items): New function.
* stapregex.cxx (regex_to_stapdfa): Set value of dfa_maxmap.
(stapdfa::num_map_items): New function.
* regex.stp: New tapset providing access to TNFA grouping data.
(matched_str): Return last matched str.
(matched): Return n'th subexpression from last match.
(ngroups): Return the number of subexpressions in last match.
David Smith [Tue, 5 Sep 2017 18:30:54 +0000 (13:30 -0500)]
Fix PR22054 by making sure we know whether a pointer is an lvalue or not.
* dwflpp.cxx: Pass around 'lvalue' in several places where needed.
(dwflpp::translate_pointer): Instead of assuming a pointer isn't an
lvalue, use the new parameter.
* dwflpp.h: Update prototypes.
* tapsets.cxx: Pass around 'lvalue' in several places where needed.
David Smith [Thu, 31 Aug 2017 14:38:18 +0000 (09:38 -0500)]
Add a minor update to the strace example and meta file.
* testsuite/systemtap.examples/process/strace.stp (filter_p): Remove
comment about PR6762, which has been fixed.
* testsuite/systemtap.examples/process/strace.meta: Run the script on a
specific process, instead of on the entire system (where we would hit
"probe overhead exceeded threshold").
David Smith [Thu, 31 Aug 2017 14:35:41 +0000 (09:35 -0500)]
Update tapset/python2.stp for RHEL6-era systems.
* tapset/python2.stp (Py2Long_AsLongLongAndOverflow_Small): Don't bother
trying to see if the Py2LongObject is defined, go ahead and use it. The
check to see if it is defined seems to fail.
(Py2Long_AsLongLongAndOverflow_Big): Ditto.
David Smith [Tue, 29 Aug 2017 21:27:23 +0000 (16:27 -0500)]
Fix PR22036 by handling "struct bio" kernel changes.
* buildrun.cxx (compile_pass): Add "autoconf"-style test for bi_opf field
of the "bio" structure.
* runtime/linux/autoconf-bio-bi_opf.c: New file.
* tapset/linux/ioblock.stp (bio_op): Use new STAPCONF_BIO_BI_OPF define.
David Smith [Tue, 29 Aug 2017 16:03:06 +0000 (11:03 -0500)]
Fix PR22012 by updating the way we read user strings.
* runtime/linux/loc2c-runtime.h (_stp_deref_string_nofault): Renamed from
kderef_string_() and modified to be able to read either a kernel or user
string.
(kderef_string): Modified to call the new _stp_deref_string_nofault().
* runtime/linux/copy.c (_stp_strncpy_from_user): Replace all code with a
call to _stp_deref_string_nofault(). This avoids a "scheduling while
atomic" kernel BUG seen when reading strings.
David Smith [Thu, 24 Aug 2017 21:42:51 +0000 (16:42 -0500)]
Tweak more systemtap.examples meta files to improve test passes.
* testsuite/systemtap.examples/general/key.meta: Check that the probed
kernel function exists before trying to compile/run the example.
* testsuite/systemtap.examples/general/keyhack.meta: Ditto.
David Smith [Thu, 24 Aug 2017 16:00:59 +0000 (11:00 -0500)]
Perform process cleanup in testsuite/systemtap.interactive/*.exp.
* testsuite/systemtap.interactive/char_and_line.exp: Be sure to kill
systemtap at the end of the test and wait on it to finish.
* testsuite/systemtap.interactive/input.char.exp: Ditto.
* testsuite/systemtap.interactive/input.line.exp: Ditto.
David Smith [Thu, 24 Aug 2017 15:42:58 +0000 (10:42 -0500)]
Add a fix to the 'container_check' example.
* testsuite/systemtap.examples/profiling/container_check.stp: Handle the
fact that the kernel functions ns_capable() and capable() have different
function signatures. On RHEL6 systems, we were getting bogus output.
David Smith [Thu, 24 Aug 2017 15:34:22 +0000 (10:34 -0500)]
Tweak some systemtap.examples meta files to improve test passes.
* testsuite/systemtap.examples/memory/hugepage_collapse.meta: Check that
the probed kernel function exists before trying to compile/run the
example.
* testsuite/systemtap.examples/memory/hugepage_split.meta: Ditto.
* testsuite/systemtap.examples/general/func_time_stats.meta: Probe
syscall.read instead of syscall.nanosleep, since we're much more likely
to hit that syscall.
Aaron Merey [Wed, 23 Aug 2017 22:54:49 +0000 (18:54 -0400)]
PR21891: perform _stext relocation on kprobes, fix kretprobe registration.
* stapbpf/stapbpf.cxx (maybe_collect_kprobe): read value of _stext from
/proc/kallsyms and add to kprobe symbol offsets.
* tapsets.cxx (dwarf_derived_probe::dwarf_derived_probe): set symbol_name
to funcname for kretprobes.
David Smith [Wed, 23 Aug 2017 21:00:24 +0000 (16:00 -0500)]
Fix PR21998 by updating tapset/linux/ip.stp.
* tapset/linux/ip.stp: Use the new 'iphdr_cast' macro to properly cast a
value to a iphdr struture pointer. For RHEL6, this fixes some "kbuild
exited with status: 2" warnings.
David Smith [Wed, 23 Aug 2017 19:05:21 +0000 (14:05 -0500)]
Add small fixes in tapset/linux/memory.stp.
* tapset/linux/memory.stp: Handle the case where __GFP_MEMALLOC doesn't
exist (like on RHEL6). In __vm.kmalloc_node.kp, add @entry() around
variables in a return probe.
David Smith [Wed, 23 Aug 2017 16:34:56 +0000 (11:34 -0500)]
Fix PR21996 by updating DEREF_FAULT for dyninst.
* runtime/loc2c-runtime.h (DEREF_FAULT): Fix dyninst compile errors on
32-bit systems where 'intptr_t' is an 'int'. Be sure to cast to 'long'
in DEREF_FAULT and STORE_DEREF_FAULT before printing the value with
"%lx".
David Smith [Tue, 22 Aug 2017 19:44:03 +0000 (14:44 -0500)]
Add and use a new macro @inet_sock_cast().
* tapset/linux/inet.stpm: Added new macro file.
* tapset/linux/inet_sock.stp: Use new @inet_sock_cast() macro to
standardize casting a pointer to a "struct inet_sock".
* tapset/linux/ip.stp: Ditto.
* tapset/linux/tcp.stp: Ditto.
David Smith [Tue, 22 Aug 2017 15:15:29 +0000 (10:15 -0500)]
PR21984: Fix "cast to pointer from integer of different size" errors.
* runtime/linux/loc2c-runtime.h: Modify the __Xread() and __Xwrite()
macros for 32-bit systems so that 64-bit values are handled properly.
* tapset/linux/atomic.stp: Make sure all pointer values are cast
properly. Their values must be cast to a 'uintptr_t' value then the
final pointer type value. This is necessary for 32-bit systems (since
systemtap variables are 64-bits). Some pointer casts weren't cast to a
numeric value, some were cast to a signed value, etc. Standardize all of
them.
* tapset/linux/aux_syscalls.stp: Ditto.
* tapset/linux/conversions-guru.stp: Ditto.
* tapset/linux/conversions.stp: Ditto.
* tapset/linux/i386/aux_syscalls.stp: Ditto.
* tapset/linux/ioblock.stp: Ditto.
* tapset/linux/ioscheduler.stp: Ditto.
* tapset/linux/ip.stp: Ditto.
* tapset/linux/ipmib.stp: Ditto.
* tapset/linux/kprocess.stp: Ditto.
* tapset/linux/netfilter.stp: Ditto.
* tapset/linux/nfs.stp: Ditto.
* tapset/linux/nfsd.stp: Ditto.
* tapset/linux/proc_mem.stp: Ditto.
* tapset/linux/rcu.stp: Ditto.
* tapset/linux/s390/aux_syscalls.stp: Ditto.
* tapset/linux/signal.stp: Ditto.
* tapset/linux/socket.stp: Ditto.
* tapset/linux/task.stp: Ditto.
* tapset/linux/tcp.stp: Ditto.
* tapset/linux/tcpmib.stp: Ditto.
* tapset/linux/x86_64/aux_syscalls.stp: Ditto.
* tapset/string.stp: Ditto.
* tapset/uconversions-guru.stp: Ditto.
* tapset/uconversions.stp: Ditto.
Stan Cox [Thu, 17 Aug 2017 18:46:27 +0000 (14:46 -0400)]
Send rpmname and buildid to http server.
* client-http.cxx (get_rpmname): New to get the rpmname of a file.
(process_buildid, get_buildid): New to get the buildid of a file.
(post): Also send rpmname and buildid
* main.cxx (passes_0_4): Invoke http client after elaboration pass.
David Smith [Wed, 16 Aug 2017 15:39:45 +0000 (10:39 -0500)]
Send over the linux distribution info to the http server.
* httpd/backends.cxx (local_backend::local_backend): Get the distro name
and arch.
(local_backend::can_generate_module): Check the distro name and arch.
(docker_backend::docker_backend): Get the list of JSON docker data files.
(docker_backend::can_generate_module): Check the arch and see if we have
a JSON docker data file for that distro.
* httpd/api.cxx (response build_collection_rh::POST): Look for 'distro_name'
and 'distro_version' tags.
* httpd/api.h (client_request_data): Added 'distro_name' and
'distro_version' fields.
* util.cxx (get_distro_info): New function.
* util.h: Add get_distro_info() declaration.
* httpd/client.py: Send over the distro information.
* dtrace.in: When building packages like libvirt on openSUSE that
link a libvirt_probes.o from dtrace, the build results differed
across builds. This is because the source's temporary filename
was in the .o. Make the temporary filename reproducible.
David Smith [Fri, 11 Aug 2017 14:36:51 +0000 (09:36 -0500)]
Fix PR21802 by improving the syscall test cases.
* testsuite/systemtap.syscall/syscall.exp: Add logic to use the
'CHECK_ONLY' environment variable to limit the syscalls tested.
* testsuite/systemtap.syscall/nd_syscall.exp: Ditto.
David Smith [Thu, 3 Aug 2017 19:23:28 +0000 (14:23 -0500)]
Fix deref handling on 32-bit kernels.
* runtime/linux/loc2c-runtime.h (__stp_deref_nocheck_): Fix i386/arm
systems where handling 8-byte values in one operation isn't possible.
(__stp_store_deref_nocheck_): Ditto.
David Smith [Thu, 3 Aug 2017 18:46:31 +0000 (13:46 -0500)]
Fix PR21901 by releasing locks in the correct order in runtime/stp_utrace.c.
* runtime/stp_utrace.c (utrace_reset): Be sure to release the locks in the
order we take them, otherwise we get an "inconsistent lock state" kernel
warning.
* main.cxx: Don't be sensitive to HAVE_LINUX_BPF_H in redundant
decisions.
* stapbpf: Clear bpf_attr's before passing to kernel, else -EINVAL.
Use log_level for verbosity for bpf syscall and elsewhere. Unshare
random text buffers and bpf's designated bpf_log_buf.
* runtime/linux/netfilter.c: To avoid "sleeping function called from
invalid context" kernel bugs, switch from using 'for_each_net_rcu()' to
using 'for_each_net()'. This avoids putting us into atomic context.
David Smith [Thu, 27 Jul 2017 17:32:54 +0000 (12:32 -0500)]
Fix syscall.{preadv,pwritev} 'offset' variable handling.
* tapset/linux/syscalls.stpm (__pos_from_hilo): New macro.
* tapset/linux/sysc_preadv.stp: Uses @__pos_from_hilo() macro to get the
correct 'offset' value.
* tapset/linux/sysc_preadv2.stp: Ditto.
* tapset/linux/sysc_pwritev.stp: Ditto.
* tapset/linux/sysc_pwritev2.stp: Ditto.
* testsuite/systemtap.syscall/preadv.c (__preadv2): Renamed from
'preadv2', since glibc 2.25 has implemented 'preadv2'.
* testsuite/systemtap.syscall/pwritev.c (__pwritev2): Renamed from
'pwritev2', sine glibc 2.25 has implemented 'pwritev2'.
David Smith [Wed, 26 Jul 2017 21:04:24 +0000 (16:04 -0500)]
syscall.execveat probes: provide decoded env_str
* tapset/linux/sysc_execveat.stp: Commit be0c04a changed syscall.execve to
provide decoded environment variables. Make similar changes for
syscall.execveat.
* testsuite/systemtap.syscall/execve.c: Update for output change.
* testsuite/systemtap.syscall/execveat.c: Ditto.
David Smith [Wed, 26 Jul 2017 15:19:36 +0000 (10:19 -0500)]
Fix PR21834 by updating the netfilter probes for new kernels.
* runtime/linux/netfilter.c: New file containing
nf_register_hook/nf_unregister_hook.
* tapset-netfilter.cxx (netfilter_derived_probe_group::emit_module_decls):
Include "linux/netfilter.c".
* buildrun.cxx (compile_pass): Add exportconf test for "nf_register_hook".
David Smith [Tue, 25 Jul 2017 20:07:46 +0000 (15:07 -0500)]
Updated testsuite/buildok/fortytwo.stp for rawhide.
* testsuite/buildok/fortytwo.stp: Updated for rawhide kernels,
4.13.0-0.rc1.git4.1.fc27.x86_64, where the kernel function
'do_readv_writev' no longer exists. Instead, probe
'do_iter_readv_writev'.
autocast support: bring back early manual functionall->synth-decl referent
When synthesizing dwarf-related functions, we can usually rely on
pass-2 symbol resolution to match up the functioncall*s with the
functiondecl*s. But in the case of autocast handling, synth function
generation is for whatever reason delayed past this point in pass-2,
so we have to manually resolve symbols/referents to some extent.
The bpf branch converts this former macro into an inline function,
so stricter type checking applies. This explicit cast makes several
pass-4 errors go poof!