]>
sourceware.org Git - lvm2.git/log
Alasdair Kergon [Mon, 17 Jan 2011 16:46:50 +0000 (16:46 +0000)]
pre-release
Zdenek Kabelac [Mon, 17 Jan 2011 15:18:10 +0000 (15:18 +0000)]
Remove -f from list of targets for cleanup
rm -f is already in used for this cleanup.
Zdenek Kabelac [Mon, 17 Jan 2011 15:16:55 +0000 (15:16 +0000)]
Do not scan devices unnecessarily for reseting error counter
For reseting error counter use directly btree cached elements and do not
create whole dev_iterator.
Zdenek Kabelac [Thu, 13 Jan 2011 15:03:28 +0000 (15:03 +0000)]
Set default value to counter_last
Missed in previous commit and could be using some random stack value.
Zdenek Kabelac [Thu, 13 Jan 2011 15:00:29 +0000 (15:00 +0000)]
Do not log backtrace for correctly processed command
Zdenek Kabelac [Thu, 13 Jan 2011 14:58:59 +0000 (14:58 +0000)]
Include default make.tmpl
Use default clean targets for this Makefile
Use also same build flags for compiling testing tools like harness.
Zdenek Kabelac [Thu, 13 Jan 2011 14:57:18 +0000 (14:57 +0000)]
Enable monitoring for cluster tests
Zdenek Kabelac [Thu, 13 Jan 2011 14:56:17 +0000 (14:56 +0000)]
Skip unnecessary lock_vol() call after volume deactivation
Improve condition within lock_vol so we are not calling extra unlock
if the volume just has been deactivated.
Patch uses lck_type and replaces negative 'and' condition to more
readable 'or' condition.
Few missing strace traces added.
Zdenek Kabelac [Thu, 13 Jan 2011 14:51:32 +0000 (14:51 +0000)]
Add exec_cmd paramater sync_needed
As sync_local_dev_names() cannot be called within activation context,
add new parametr which allows to select if the sync call is needed
before executing new command.
Zdenek Kabelac [Thu, 13 Jan 2011 11:05:27 +0000 (11:05 +0000)]
Check for file with clvmd pid
Instead of checking $LOCAL_CLVMD set during some 'aux' execution which
doesn't seem to be propagated to this shell - check for existance of pid
file of clvmd process - so this test is skipped in singlenode cluster test.
Zdenek Kabelac [Thu, 13 Jan 2011 11:02:55 +0000 (11:02 +0000)]
Hotfix to stop harness busylooping
Harness seems to be able to busyloop in while cycle and not moving forward
for certain buffer - so check whethere there was some progress.
This fix allows to continue after failed cluster test.
Fix gcc warning for hiding global variable 's' -> sig.
Alasdair Kergon [Wed, 12 Jan 2011 20:42:50 +0000 (20:42 +0000)]
Replace fs_unlock by sync_local_dev_names to notify local clvmd. (2.02.80)
Introduce sync_local_dev_names and CLVMD_CMD_SYNC_NAMES to issue fs_unlock.
Petr Rockai [Wed, 12 Jan 2011 16:07:55 +0000 (16:07 +0000)]
Kill clvmd properly after locking_type 3 tests (using clvmd/singlenode).
Alasdair Kergon [Wed, 12 Jan 2011 15:28:33 +0000 (15:28 +0000)]
add fio
Jonathan Earl Brassow [Tue, 11 Jan 2011 17:21:01 +0000 (17:21 +0000)]
s/log_verbose/log_error/ - Increase log level on error message.
Jonathan Earl Brassow [Tue, 11 Jan 2011 17:05:08 +0000 (17:05 +0000)]
Add disk to mirrored log type conversion.
Alasdair Kergon [Mon, 10 Jan 2011 21:12:54 +0000 (21:12 +0000)]
post-release
Alasdair Kergon [Mon, 10 Jan 2011 21:12:18 +0000 (21:12 +0000)]
reissue 2.02.80
Zdenek Kabelac [Mon, 10 Jan 2011 19:49:42 +0000 (19:49 +0000)]
Fix missing declaration for fs_unlock
Zdenek Kabelac [Mon, 10 Jan 2011 19:31:02 +0000 (19:31 +0000)]
Avoid cookie sharing between forked processes
Before fork, ensure cookie is reset so it's not shared between processes.
Alasdair Kergon [Mon, 10 Jan 2011 14:51:33 +0000 (14:51 +0000)]
post-release
Alasdair Kergon [Mon, 10 Jan 2011 14:28:17 +0000 (14:28 +0000)]
pre-release
Zdenek Kabelac [Mon, 10 Jan 2011 14:02:30 +0000 (14:02 +0000)]
Speedup consequent activation calls
Stop calling fs_unlock() from lv_de/activate().
Start using internal lvm fs cookie for dm_tree.
Stop directly calling dm_udev_wait() and
dm_tree_set/get_cookie() from activate code -
it's now called through fs_unlock() function.
Add lvm_do_fs_unlock()
Call fs_unlock() when unlocking vg where implicit unlock solves the
problem also for cluster - thus no extra command for clustering
environment is required - only lvm_do_fs_unlock() function is added
to call lvm's fs_unlock() while holding lvm_lock mutex in clvmd.
Add fs_unlock() also to set_lv() so the command waits until devices
are ready for regular open (i.e. wiping its begining).
Move fs_unlock() prototype to activation.h to keep fs.h private
in lib/activate dir and not expose other functions from this header.
Zdenek Kabelac [Mon, 10 Jan 2011 13:44:39 +0000 (13:44 +0000)]
Add internal fs cookie
Add functions for handling internal lvm cookie used for
all dm_tree operations until fs_unlock is called.
Zdenek Kabelac [Mon, 10 Jan 2011 13:42:31 +0000 (13:42 +0000)]
Define DM_COOKIE_AUTO_CREATE
TODO: Use it also for already written code.
Zdenek Kabelac [Mon, 10 Jan 2011 13:25:22 +0000 (13:25 +0000)]
Use strndup as GNU extension
strndup needs _GNU_SOURCE defined as it's GNU extension.
Remove duplicate string.h header added in previous harness commit.
Zdenek Kabelac [Mon, 10 Jan 2011 13:15:57 +0000 (13:15 +0000)]
Cache config_tree
Start to use config_tree for cache just like vgmetadata.
When vgmetadata are erased destroy its cached config tree.
Zdenek Kabelac [Mon, 10 Jan 2011 13:13:42 +0000 (13:13 +0000)]
Change import_vg_from_buffer to use config_tree
Change function import_vg_from_buffer() to import_vg_from_config_tree().
Instead of creating config tree inside the function allow config tree to
be passed as parameter - usable later for caching.
Zdenek Kabelac [Mon, 10 Jan 2011 13:07:58 +0000 (13:07 +0000)]
Add default error path for get_property
Set invalid property value for error path when NULL handler is passed.
Fixes use of uninitialized prop structure as we return 'v' by value.
---
Zdenek Kabelac [Mon, 10 Jan 2011 13:00:53 +0000 (13:00 +0000)]
Improve OCF dir support
Add --with-ocfdir configurable option.
Fix superfluous /usr in ocf_scriptdir instalation path.
Alasdair Kergon [Fri, 7 Jan 2011 16:27:05 +0000 (16:27 +0000)]
Add aclocal.m4 (for pkgconfig).
Petr Rockai [Fri, 7 Jan 2011 15:04:52 +0000 (15:04 +0000)]
Skip the api/percent test on kernels <= 2.6.32.
Petr Rockai [Fri, 7 Jan 2011 14:56:52 +0000 (14:56 +0000)]
Add a test for the interaction of snapshots of mirrors and lvconvert --repair.
Petr Rockai [Fri, 7 Jan 2011 14:56:10 +0000 (14:56 +0000)]
Add a test for the interaction of transient errors and dmeventd mirror repair.
Petr Rockai [Fri, 7 Jan 2011 14:42:35 +0000 (14:42 +0000)]
Fix a typo in the new relaxed mirror check (test/lib/check.sh).
Alasdair Kergon [Fri, 7 Jan 2011 14:38:34 +0000 (14:38 +0000)]
Using Fedora 14's autoreconf.
Petr Rockai [Fri, 7 Jan 2011 13:07:10 +0000 (13:07 +0000)]
Remove *.t in test/api's make clean target.
Petr Rockai [Fri, 7 Jan 2011 13:04:17 +0000 (13:04 +0000)]
Disable activation/monitoring in testing lvm.conf by default.
Petr Rockai [Fri, 7 Jan 2011 13:03:46 +0000 (13:03 +0000)]
Relax the mirror test in test/lib/check.sh.
Petr Rockai [Fri, 7 Jan 2011 13:03:04 +0000 (13:03 +0000)]
In aux, exit 200 no longer works as skip -- replace with real skip call.
Petr Rockai [Fri, 7 Jan 2011 12:26:02 +0000 (12:26 +0000)]
Fix up the make clean target in test/.
Zdenek Kabelac [Thu, 6 Jan 2011 15:29:24 +0000 (15:29 +0000)]
Fix memory leak in filter creation error path
If some allocation for peristent filter fails its memory reference
was lost, fix it by calling filter's destructor.
Fix log_error messages for failing allocation.
Zdenek Kabelac [Thu, 6 Jan 2011 15:25:07 +0000 (15:25 +0000)]
Intentionaly ignore result from get_config_uint32
Zdenek Kabelac [Thu, 6 Jan 2011 10:45:41 +0000 (10:45 +0000)]
Remove dead assignment of 'ret' value
Variable 'ret' assigned from _do_event() was actually not used and replaced with next
assignment without any read of the returned value.
Code is reformated - so the error path is put in the if() branch and normal
code is put after the 'if' together with FIXME comment.
FIXME lowprio: logging needs to be fixed in this code,
- multiple log_errors are printed, stacks are missing...
Zdenek Kabelac [Thu, 6 Jan 2011 09:45:05 +0000 (09:45 +0000)]
Remove unneeded stack prints after log_error
Jonathan Earl Brassow [Wed, 5 Jan 2011 23:18:46 +0000 (23:18 +0000)]
Reverting recent commit to disallow adding/removing mirror log while
removing/adding mirror images... There was already code in there to
do the job - I just didn't find it in WHATS_NEW (or in the code right
away).
Jonathan Earl Brassow [Wed, 5 Jan 2011 20:02:45 +0000 (20:02 +0000)]
Prevent the user from simultaneously adding a mirror log while removing
a mirror image (or removing a log while adding a mirror). Advise the
user to use two separate commands instead.
This issue become especially problematic when PVs are specified, as they
tend to mean different things when adding vs removing. In a command that
mixes adding and removing, it is impossible to decern exactly what the
user wants.
This change prevents bug 603912.
Zdenek Kabelac [Wed, 5 Jan 2011 15:10:30 +0000 (15:10 +0000)]
Check result of dm_snprintf for error
Zdenek Kabelac [Wed, 5 Jan 2011 15:06:10 +0000 (15:06 +0000)]
Add sys_debug loging for unlink
This unlink intentionally silently ignores any errors.
It's still worth to trace its error status in debug mode.
Zdenek Kabelac [Wed, 5 Jan 2011 15:03:43 +0000 (15:03 +0000)]
Fix gcc warnings for missing headers and prototypes
Add missing header string.h (strcmp, strndup).
Add 'static' to fix missing prototypes gcc warning.
Remove unused variables verbose_off, TESTDIR, PREFIX.
Petr Rockai [Wed, 5 Jan 2011 14:15:26 +0000 (14:15 +0000)]
Remove obsolete bits of support code from test/.
Petr Rockai [Wed, 5 Jan 2011 14:15:01 +0000 (14:15 +0000)]
Re-enable t-lvconvert-repair-transient, avoiding the deadlock by running mkfs
asynchronously.
Zdenek Kabelac [Wed, 5 Jan 2011 14:03:36 +0000 (14:03 +0000)]
Add missing error path tests
Zdenek Kabelac [Wed, 5 Jan 2011 12:59:46 +0000 (12:59 +0000)]
Fail deamonization if lvmcache_init fail
FIXME Add proper cleanup
Zdenek Kabelac [Wed, 5 Jan 2011 12:33:51 +0000 (12:33 +0000)]
Return PERCENT_INVALID for error case
If the percent value could not be determined return PERCENT_INVALID.
Indent function with tabs.
Zdenek Kabelac [Wed, 5 Jan 2011 12:27:56 +0000 (12:27 +0000)]
Remove unused variable mirr_state and its assignment
Zdenek Kabelac [Wed, 5 Jan 2011 12:17:19 +0000 (12:17 +0000)]
Remove dead assignment to thisfd
Value of 'thisfd' is not read again after its assigment
Petr Rockai [Wed, 5 Jan 2011 01:04:47 +0000 (01:04 +0000)]
Fix another bug in t-pvcreate-operation-md (should pass now).
Petr Rockai [Wed, 5 Jan 2011 01:00:34 +0000 (01:00 +0000)]
Add a test for RHBZ 640621 (metadata/dirs + no PV MDAs broken).
Petr Rockai [Wed, 5 Jan 2011 00:38:41 +0000 (00:38 +0000)]
Fix typo in t-pvcreate-operation-md.sh.
Petr Rockai [Wed, 5 Jan 2011 00:26:19 +0000 (00:26 +0000)]
Move the mkdtemp functionality into test/lib/utils.sh.
Petr Rockai [Wed, 5 Jan 2011 00:25:07 +0000 (00:25 +0000)]
Fix a couple of bugs in the new (test/lib/)aux.sh.
Petr Rockai [Wed, 5 Jan 2011 00:16:18 +0000 (00:16 +0000)]
Substantial rework of the functional test support code. Some new features:
- somewhat neater, more consistent and more readable output
- possible to set any lvm.conf value: aux lvmconf "section/key = value"
- LVM_TEST_NODEBUG to suppress the (lengthy) "## DEBUG" output
- back-substitution on test output ($TESTDIR/$PREFIX -> @TESTDIR@/@PREFIX@)
- support code moved from test/ to test/lib/ --> less clutter
Jonathan Earl Brassow [Tue, 4 Jan 2011 21:41:35 +0000 (21:41 +0000)]
Fix bug 635949: lvconvert man page clarification
Jonathan Earl Brassow [Tue, 4 Jan 2011 21:33:06 +0000 (21:33 +0000)]
Change to correct cmirrord return code is user visible - update WHATS_NEW
file.
Jonathan Earl Brassow [Tue, 4 Jan 2011 21:16:54 +0000 (21:16 +0000)]
Fix bug 632681: cmirrord shouldn't fail 'start' if already started
Return 0 from the cmirrord init script if the daemon is already
running.
http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
Peter Rajnoha [Tue, 4 Jan 2011 14:43:53 +0000 (14:43 +0000)]
Export DM_CONTROL_NODE_UMASK and use it while creating /dev/mapper/control.
Petr Rockai [Mon, 3 Jan 2011 15:07:39 +0000 (15:07 +0000)]
Use system assert in test/api/percent.c, for now.
Milan Broz [Thu, 23 Dec 2010 14:23:30 +0000 (14:23 +0000)]
Fix wrongly paired unlocking of global lock in pvchange. (2.02.66)
Zdenek Kabelac [Wed, 22 Dec 2010 15:44:09 +0000 (15:44 +0000)]
Remove check for existance of vg pointer
Checking for vg being != NULL in this place is not needed.
Pointer vg is already dereferced in this function above this code line.
Also this internal function _read_pv is always called with valid 'vg' pointer.
Zdenek Kabelac [Wed, 22 Dec 2010 15:36:41 +0000 (15:36 +0000)]
Add backtraces for backup and backup_remove fail paths
Zdenek Kabelac [Wed, 22 Dec 2010 15:32:15 +0000 (15:32 +0000)]
Hide unused code into if 0
Make it obvious for lcov coverage and static analyzis we
are not interested in this piece of code.
Zdenek Kabelac [Wed, 22 Dec 2010 15:28:44 +0000 (15:28 +0000)]
Detect errors from dm_task_set calls
Check for errors in dm_task_set calls.
Use goto_bad macro with stack trace.
Replace label failed: with bad:.
Zdenek Kabelac [Wed, 22 Dec 2010 14:00:28 +0000 (14:00 +0000)]
Fix last pthread_join fix commit
Call for pthread_join() does not set errno value even though return values
looks like that. For now assign errno from return value and still use
strerror() to print some error message as this seems to be commonly used.
Add also log_sys_error() message for error close of local pipe.
Zdenek Kabelac [Wed, 22 Dec 2010 13:45:33 +0000 (13:45 +0000)]
Add backtraces for archive and backup_locally
If archive or back_locally fails - add stack trace.
Zdenek Kabelac [Wed, 22 Dec 2010 12:14:11 +0000 (12:14 +0000)]
Fix memory leak in debug mode of restart_clvmd() error path
Zdenek Kabelac [Wed, 22 Dec 2010 12:10:56 +0000 (12:10 +0000)]
Log error state from pthread_join operation
Value jstat is unused - so replace it with logging via log_sys_error().
Zdenek Kabelac [Wed, 22 Dec 2010 12:06:54 +0000 (12:06 +0000)]
Remove dead assignment of lv_total and lv_capasity_total
Variables 'lv_total' and 'lv_capasity_total' are unused.
Alasdair Kergon [Tue, 21 Dec 2010 21:08:51 +0000 (21:08 +0000)]
post-release
Alasdair Kergon [Tue, 21 Dec 2010 01:14:34 +0000 (01:14 +0000)]
Copyright notices for new files.
Alasdair Kergon [Tue, 21 Dec 2010 01:08:29 +0000 (01:08 +0000)]
pre-release
Zdenek Kabelac [Mon, 20 Dec 2010 14:38:22 +0000 (14:38 +0000)]
Add missing test for reallocation error.
Zdenek Kabelac [Mon, 20 Dec 2010 14:36:12 +0000 (14:36 +0000)]
Remove dead assignment
Variable 'r' is never read so remove it and just cast result from
_error_device function to (void).
Zdenek Kabelac [Mon, 20 Dec 2010 14:34:49 +0000 (14:34 +0000)]
Verbose log old_umask value
Use old_umask value and print its content through verbose log.
Zdenek Kabelac [Mon, 20 Dec 2010 14:20:52 +0000 (14:20 +0000)]
Add internal error if pointer is uninitialized
Add simple check for existance of 'pl' and printer internal error message
if device is missing instead of plain crash.
Zdenek Kabelac [Mon, 20 Dec 2010 14:08:46 +0000 (14:08 +0000)]
Add check for unlink errors
Zdenek Kabelac [Mon, 20 Dec 2010 14:06:33 +0000 (14:06 +0000)]
Remove unused variable label
Variable 'label' is unused in _format1_pv_write().
Zdenek Kabelac [Mon, 20 Dec 2010 14:05:31 +0000 (14:05 +0000)]
Remove unused variable dev_dir_provided
Zdenek Kabelac [Mon, 20 Dec 2010 14:04:43 +0000 (14:04 +0000)]
Remove dead assignment of segh
Variable 'segh' is never read again after this assignment.
Zdenek Kabelac [Mon, 20 Dec 2010 13:59:52 +0000 (13:59 +0000)]
Remove dead store in lvm_run_command
Variable 'ret' is not read before its next assignment.
Zdenek Kabelac [Mon, 20 Dec 2010 13:58:38 +0000 (13:58 +0000)]
Removed unused pointer
Pointer 'duplicate' is unused.
Zdenek Kabelac [Mon, 20 Dec 2010 13:57:19 +0000 (13:57 +0000)]
Use dm_free for dm_malloc-ed areas in _clog_ctr/_clog_dtr (cmirrord).
Use dm_zalloc to obtain zeroed memory block.
Use dm_free for dm_ allocated memory blocks.
Test close() for error.
Zdenek Kabelac [Mon, 20 Dec 2010 13:53:10 +0000 (13:53 +0000)]
Add checks for allocation errors in config node clonning.
Add checks for clonning allocation a fail-out when something is
not allocated correctly.
Also move var declaration to the begining of the function
and fix log_error messages.
Zdenek Kabelac [Mon, 20 Dec 2010 13:48:28 +0000 (13:48 +0000)]
Replace multiple fprintf calls with one large string parameter
Zdenek Kabelac [Mon, 20 Dec 2010 13:45:39 +0000 (13:45 +0000)]
Fix error path if regex engine cannot be created in _build_matcher().
Fix only 'stack' printing with full function error exit.
Zdenek Kabelac [Mon, 20 Dec 2010 13:40:46 +0000 (13:40 +0000)]
Use const char * for name and old_name in vg
Switch to use const char pointers to avoid changes of these structure
members and having better control over, were these members could
be modified.
Zdenek Kabelac [Mon, 20 Dec 2010 13:39:12 +0000 (13:39 +0000)]
Use const char* for offset calculation
As 'const' types are also passed to macro dm_list_struct_base -
keep offset calculation with const char pointers.
Fixes several gcc constness warnings.
Zdenek Kabelac [Mon, 20 Dec 2010 13:37:26 +0000 (13:37 +0000)]
Switch void* to char* arithmetic
Zdenek Kabelac [Mon, 20 Dec 2010 13:32:49 +0000 (13:32 +0000)]
Remove const usage from destroy callbacks
As const segment_type or const format_type are never released
use their non-const version and remove const downcast from dm_free calls.
This change fixes many gcc warnings we were getting from them.
Zdenek Kabelac [Mon, 20 Dec 2010 13:28:04 +0000 (13:28 +0000)]
Fix wrong cast to char*
As cmd->cmd_line is already const char pointer it's not needed to cast already
const char pointer to char pointer.
This page took 0.070486 seconds and 5 git commands to generate.