From: Jon Turney <jon.turney@dronecode.org.uk>
Date: Mon, 7 Sep 2020 15:24:39 +0000 (+0100)
Subject: Cygwin: ldd: Also look for not found DLLs when exit status is non-zero
X-Git-Tag: newlib-4.0.0~97
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=f4a1b6ae182aaebd5b5a69f3f31ef633bc174464;p=newlib-cygwin.git

Cygwin: ldd: Also look for not found DLLs when exit status is non-zero

If the process exited with e.g. STATUS_DLL_NOT_FOUND, also process the
file to look for not found DLLs.

(We currently only do this when a STATUS_DLL_NOT_FOUND exception occurs,
which I haven't managed to observe)

This still isn't 100% correct, as it only examines the specified file
for missing DLLs, not recursively on the DLLs it depends upon.
---

diff --git a/winsup/utils/ldd.cc b/winsup/utils/ldd.cc
index e1af99e12..1e1863c1c 100644
--- a/winsup/utils/ldd.cc
+++ b/winsup/utils/ldd.cc
@@ -407,6 +407,8 @@ report (const char *in_fn, bool multiple)
 	  }
 	  break;
 	case EXIT_PROCESS_DEBUG_EVENT:
+	  if (ev.u.ExitProcess.dwExitCode != 0)
+	    process_fn = fn_win;
 print_and_exit:
 	  print_dlls (&dll_list, isdll ? fn_win : NULL, process_fn);
 	  exitnow = true;