From: Corinna Vinschen <corinna@vinschen.de>
Date: Tue, 17 Jan 2023 16:43:21 +0000 (+0100)
Subject: Cygwin: disable high-entropy VA for cygcheck and strace
X-Git-Tag: cygwin-3.4.4~2
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=cbc513cf3d32b59aa63bfdd08ae4f121309b78be;p=newlib-cygwin.git

Cygwin: disable high-entropy VA for cygcheck and strace

It's not a good idea to enable high-entropy VA for tools loading the
Cygwin DLL dynamically.  The addresses used by HEVA tend to collide with
fixed address areas managed by Cygwin.

Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
---

diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am
index 255fc4651..edb314d06 100644
--- a/winsup/utils/mingw/Makefile.am
+++ b/winsup/utils/mingw/Makefile.am
@@ -32,6 +32,7 @@ cygcheck_SOURCES = \
 	dump_setup.cc \
 	path.cc
 cygcheck_CPPFLAGS=-I$(srcdir)/.. -idirafter ${top_srcdir}/cygwin/include
+cygcheck_LDFLAGS = -Wl,--disable-high-entropy-va
 cygcheck_LDADD = -lz -lwininet -lpsapi -lntdll
 
 cygwin_console_helper_SOURCES = cygwin-console-helper.cc
@@ -42,6 +43,7 @@ strace_SOURCES = \
 	path.cc \
 	strace.cc
 strace_CPPFLAGS=-I$(srcdir)/.. -idirafter ${top_srcdir}/cygwin/local_includes -idirafter ${top_srcdir}/cygwin/include
+strace_LDFLAGS = -Wl,--disable-high-entropy-va
 strace_LDADD = -lntdll
 
 noinst_PROGRAMS = path-testsuite