From: Zdenek Kabelac Date: Fri, 31 Oct 2014 10:41:49 +0000 (+0100) Subject: pool: validate sizes X-Git-Tag: v2_02_112~77 X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=897b09157922a510d6c9f5556eea4fc243b84702;p=lvm2.git pool: validate sizes 0 size are not supported as well as negative. --- diff --git a/tools/toollib.c b/tools/toollib.c index dd098119b..e87fd30c4 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -975,12 +975,21 @@ int get_pool_params(struct cmd_context *cmd, } } - if (arg_count(cmd, chunksize_ARG)) { - if (arg_sign_value(cmd, chunksize_ARG, SIGN_NONE) == SIGN_MINUS) { - log_error("Negative chunk size is invalid."); - return 0; - } + if (arg_from_list_is_negative(cmd, "may not be negative", + chunksize_ARG, + pooldatasize_ARG, + poolmetadatasize_ARG, + -1)) + return_0; + + if (arg_from_list_is_zero(cmd, "may not be zero", + chunksize_ARG, + pooldatasize_ARG, + poolmetadatasize_ARG, + -1)) + return_0; + if (arg_is_set(cmd, chunksize_ARG)) { *passed_args |= PASS_ARG_CHUNK_SIZE; *chunk_size = arg_uint_value(cmd, chunksize_ARG, 0);