From: Wu Guanghao <wuguanghao3@huawei.com>
Date: Fri, 11 Sep 2020 09:42:16 +0000 (+0800)
Subject: lvconvert: check if LV has snapshot type
X-Git-Tag: v2_03_11~202
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=7db124774a2b79105e7c9c6b42df88219fc070ca;p=lvm2.git

lvconvert: check if LV has snapshot type

Cow may not be a snapshot type, the return value of origin_from_cow(cow) may be NULL

Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---

diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index d420eb52f..6ab8f6d2c 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -1825,6 +1825,11 @@ static int _lvconvert_splitsnapshot(struct cmd_context *cmd, struct logical_volu
 	struct volume_group *vg = cow->vg;
 	const char *cow_name = display_lvname(cow);
 
+	if (!lv_is_snapshot(cow)) {
+		log_error(INTERNAL_ERROR "Cow volume %s is not a snapshot.", cow_name);
+		return 0;
+	}
+
 	if (lv_is_virtual_origin(origin_from_cow(cow))) {
 		log_error("Unable to split off snapshot %s with virtual origin.", cow_name);
 		return 0;