From: Zdenek Kabelac <zkabelac@redhat.com>
Date: Fri, 30 Jun 2017 12:28:44 +0000 (+0200)
Subject: tests: correcting  globbing usage
X-Git-Tag: v2_02_173~151
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=57779e39eccf456344fa4a51ddfc49cee41a40d7;p=lvm2.git

tests: correcting  globbing usage

Ensure globbing uses current dir.
Break loop when no match is found.
Let STACKTRACE finish its output when gdb fails.
---

diff --git a/test/lib/utils.sh b/test/lib/utils.sh
index 4f3e46059..2b5b782e6 100644
--- a/test/lib/utils.sh
+++ b/test/lib/utils.sh
@@ -120,7 +120,7 @@ stacktrace() {
 
 STACKTRACE() {
 	trap - ERR
-	local i=0
+	local i
 
 	stacktrace
 
@@ -134,10 +134,12 @@ STACKTRACE() {
 		echo bt full > gdb_commands.txt
 		echo l >> gdb_commands.txt
 		echo quit >> gdb_commands.txt
-		for core in $(echo core* 2>/dev/null); do
-			bin=$(gdb -batch -c "$core" 2>&1 | grep "generated by" | \
-			sed -e "s,.*generated by \`\([^ ']*\).*,\1,")
-			gdb -batch -c "$core" -x gdb_commands.txt "$(which "$bin")"
+		# TODO: use sysctl to get 'core' position in system
+		for i in core*; do
+			test -f "$i" || break   # empty globbing
+			bin=$(gdb -batch -c "$i" 2>&1 | grep "generated by" | \
+			sed -e "s,.*generated by \`\([^ ']*\).*,\1,") || continue
+			gdb -batch -c "$i" -x gdb_commands.txt "$(which "$bin")" || continue
 		done
 	fi