From: Zdenek Kabelac <zkabelac@redhat.com>
Date: Fri, 16 Sep 2011 12:12:51 +0000 (+0000)
Subject: Remove thin volumes before thin pools
X-Git-Tag: old-v2_02_89~479
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=528c26a1ceac39c14e097b5f83268f34c6e58a19;p=lvm2.git

Remove thin volumes before thin pools

When user wants to remove thin pool - check if there are no thin volumes using it.
If so - query before removal (or -ff for no question) and remove them first.
---

diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index 2e23e5d8c..f2d5f5e77 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -3178,6 +3178,22 @@ int lv_remove_with_dependencies(struct cmd_context *cmd, struct logical_volume *
 		}
 	}
 
+	if (lv_is_thin_pool(lv) && dm_list_size(&lv->segs_using_this_lv)) {
+		/* remove thin LVs first */
+		if ((force == PROMPT) &&
+		    yes_no_prompt("Do you really want to remove all thin volumes when removing "
+				  "pool logical volume %s? [y/n]: ", lv->name) == 'n') {
+			log_error("Logical volume %s not removed", lv->name);
+			return 0;
+		}
+		dm_list_iterate_safe(snh, snht, &lv->segs_using_this_lv) {
+			if (!lv_remove_with_dependencies(cmd,
+							 dm_list_item(snh, struct seg_list)->seg->lv,
+							 force, level + 1))
+				return 0;
+		}
+	}
+
 	return lv_remove_single(cmd, lv, force);
 }