From: Alasdair Kergon Date: Mon, 5 Jul 2010 22:22:43 +0000 (+0000) Subject: Add parentheses to some libdevmapper.h macro arguments. X-Git-Tag: v2_02_91~1726 X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=44cd0f4780470db6417c4325d15762bf102b3e14;p=lvm2.git Add parentheses to some libdevmapper.h macro arguments. --- diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index 7f78128c4..bdedabdab 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,5 +1,6 @@ Version 1.02.52 - ================================ + Add parentheses to some libdevmapper.h macro arguments. Add printf format attributes to dm_{sn,as}printf and fix a caller. Move dmeventd man page from install_lvm2 to install_device-mapper. (1.02.50) diff --git a/libdm/libdevmapper.h b/libdm/libdevmapper.h index 8026c7bfd..fa868b154 100644 --- a/libdm/libdevmapper.h +++ b/libdm/libdevmapper.h @@ -657,22 +657,22 @@ int dm_bit_get_next(dm_bitset_t bs, int last_bit); #define DM_BITS_PER_INT (sizeof(int) * CHAR_BIT) #define dm_bit(bs, i) \ - (bs[(i / DM_BITS_PER_INT) + 1] & (0x1 << (i & (DM_BITS_PER_INT - 1)))) + ((bs)[((i) / DM_BITS_PER_INT) + 1] & (0x1 << ((i) & (DM_BITS_PER_INT - 1)))) #define dm_bit_set(bs, i) \ - (bs[(i / DM_BITS_PER_INT) + 1] |= (0x1 << (i & (DM_BITS_PER_INT - 1)))) + ((bs)[((i) / DM_BITS_PER_INT) + 1] |= (0x1 << ((i) & (DM_BITS_PER_INT - 1)))) #define dm_bit_clear(bs, i) \ - (bs[(i / DM_BITS_PER_INT) + 1] &= ~(0x1 << (i & (DM_BITS_PER_INT - 1)))) + ((bs)[((i) / DM_BITS_PER_INT) + 1] &= ~(0x1 << ((i) & (DM_BITS_PER_INT - 1)))) #define dm_bit_set_all(bs) \ - memset(bs + 1, -1, ((*bs / DM_BITS_PER_INT) + 1) * sizeof(int)) + memset((bs) + 1, -1, ((*(bs) / DM_BITS_PER_INT) + 1) * sizeof(int)) #define dm_bit_clear_all(bs) \ - memset(bs + 1, 0, ((*bs / DM_BITS_PER_INT) + 1) * sizeof(int)) + memset((bs) + 1, 0, ((*(bs) / DM_BITS_PER_INT) + 1) * sizeof(int)) #define dm_bit_copy(bs1, bs2) \ - memcpy(bs1 + 1, bs2 + 1, ((*bs1 / DM_BITS_PER_INT) + 1) * sizeof(int)) + memcpy((bs1) + 1, (bs2) + 1, ((*(bs1) / DM_BITS_PER_INT) + 1) * sizeof(int)) /* Returns number of set bits */ static inline unsigned hweight32(uint32_t i) @@ -716,8 +716,8 @@ struct dm_hash_node *dm_hash_get_first(struct dm_hash_table *t); struct dm_hash_node *dm_hash_get_next(struct dm_hash_table *t, struct dm_hash_node *n); #define dm_hash_iterate(v, h) \ - for (v = dm_hash_get_first(h); v; \ - v = dm_hash_get_next(h, v)) + for (v = dm_hash_get_first((h)); v; \ + v = dm_hash_get_next((h), v)) /**************** * list functions