From: Alasdair Kergon <agk@redhat.com>
Date: Thu, 10 Apr 2008 18:53:36 +0000 (+0000)
Subject: .
X-Git-Tag: v2_02_91~3679
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=3cde54c50e4c76d366ae752b25315c173ac1101f;p=lvm2.git

.
---

diff --git a/WHATS_NEW b/WHATS_NEW
index 4142f81c6..57931ee0d 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.34 - 10th April 2008
 =================================
+  Improve preferred_names lvm.conf example.
   Fix vgdisplay 'Cur LV' field to match lvdisplay output.
   Fix lv_count report field to exclude hidden LVs.
   Add vg_is_clustered() helper function.
diff --git a/doc/example.conf b/doc/example.conf
index 25ce401ed..8eceafe3f 100644
--- a/doc/example.conf
+++ b/doc/example.conf
@@ -25,9 +25,8 @@ devices {
     # list of regular expressions in turn and the first match is used.
     preferred_names = [ ]
 
-    # If device-mapper multipath is used, more descriptive names might
-    # be preferred over the dm-N names:
-    # preferred_names = [ "^/dev/mapper/mpath" ]
+    # Try to avoid using undescriptive /dev/dm-N names, if present.
+    # preferred_names = [ "^/dev/mpath/", "^/dev/mapper/mpath", "^/dev/[hs]d" ]
 
     # A filter that tells LVM2 to only use a restricted set of devices.
     # The filter consists of an array of regular expressions.  These
diff --git a/lib/mirror/mirrored.c b/lib/mirror/mirrored.c
index f837f0b1e..56213fb22 100644
--- a/lib/mirror/mirrored.c
+++ b/lib/mirror/mirrored.c
@@ -373,7 +373,7 @@ static int _mirrored_target_present(const struct lv_segment *seg __attribute((un
 
 	/*
 	 * Check only for modules if atttributes requested and no previous check.
-	 * FIXME: need better check
+	 * FIXME: Fails incorrectly if cmirror was built into kernel.
 	 */
 	if (attributes) {
 		if (!_mirror_attributes && module_present("cmirror"))
diff --git a/man/lvm.conf.5 b/man/lvm.conf.5
index aa92da975..0bb197245 100644
--- a/man/lvm.conf.5
+++ b/man/lvm.conf.5
@@ -84,7 +84,7 @@ Defaults to "/dev".
 \fBpreferred_names\fP \(em List of patterns compared in turn against
 all the pathnames referencing the same device in in the scanned directories.
 The pathname that matches the earliest pattern in the list is the
-one used in any output.  As an example, if device mapper multipathing
+one used in any output.  As an example, if device-mapper multipathing
 is used, the following will select multipath device names:
 .br
 \fBdevices { preferred_names = [ "^/dev/mapper/mpath" ] }\fP