From: Peter Rajnoha Date: Fri, 28 Jan 2011 11:41:51 +0000 (+0000) Subject: Set DM_UDEV_DISABLE_OTHER_RULES_FLAG for suspended DM devices in udev rules. X-Git-Tag: old-v2_02_83~36 X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=2fef22fa85d43296e0701fa362b6edd1a7834510;p=lvm2.git Set DM_UDEV_DISABLE_OTHER_RULES_FLAG for suspended DM devices in udev rules. This is to avoid any scanning and processing of DM devices while they are in suspended state (e.g. a rename while the device is suspended - a CHANGE event is generated!). Otherwise, any scanning in the rules could end up with locking the calling process until the device is resumed and so we don't receive a notification about udev rules completion until then (and that effectively locks out the process awaiting the notification!). However, we still keep 'disk' and any 'subsystem' related udev rules running. We trust these and these should check themselves whether a device is suspended or not, not trying to run any scanning if it is. --- diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index efe51b475..2f24c5ddf 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,5 +1,6 @@ Version 1.02.62 - =================================== + Set DM_UDEV_DISABLE_OTHER_RULES_FLAG for suspended DM devices in udev rules. Initialize pool object for each row in _output_as_rows(). Version 1.02.61 - 10th January 2011 diff --git a/udev/10-dm.rules.in b/udev/10-dm.rules.in index 4d50ed3df..606a13dbb 100644 --- a/udev/10-dm.rules.in +++ b/udev/10-dm.rules.in @@ -119,6 +119,11 @@ ENV{DM_UUID}=="mpath-?*", ENV{DM_ACTION}=="PATH_FAILED", GOTO="dm_disable" ENV{DM_UUID}=="CRYPT-TEMP-?*", GOTO="dm_disable" ENV{DM_UUID}!="?*", ENV{DM_NAME}=="temporary-cryptsetup-?*", GOTO="dm_disable" +# Avoid processing and scanning a DM device in the other (foreign) +# rules if it is in suspended state. However, we still keep 'disk' +# and 'DM subsystem' related rules enabled in this case. +ENV{DM_SUSPENDED}=="1", ENV{DM_UDEV_DISABLE_OTHER_RULES_FLAG}="1" + GOTO="dm_end" LABEL="dm_disable"