From: Joe Landers <jlanders@vmware.com>
Date: Tue, 16 Jun 2009 00:37:40 +0000 (-0700)
Subject: Fix memory leak when batch-reading large NIS password maps.
X-Git-Tag: fedora/glibc-2.10.90-1~6^2~5
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=233a182b9ee2a48eddbb15f70af8bc24add24af3;p=glibc.git

Fix memory leak when batch-reading large NIS password maps.

Not the whole was traversed in the function to free all buffers.
BZ #10203
---

diff --git a/ChangeLog b/ChangeLog
index 402b5cb3e2..2bfa774655 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2009-06-15  Ulrich Drepper  <drepper@redhat.com>
 
+	[BZ #10203]
+	* nis/nss_nis/nis-pwd.c (internal_nis_endpwent): Free all buffers,
+	not just the currently used one and those which follow.
+	Patch by Joe Landers <jlanders@vmware.com>.
+
 	[BZ #10196]
 	* libio/tst-fgetwc.c (do_test): Use de_DE.UTF-8 as locale name.
 	Patch by Bruce Dubbs <bdubbs@linuxfromscratch.org>.
diff --git a/nis/nss_nis/nis-pwd.c b/nis/nss_nis/nis-pwd.c
index 1b5206ad6d..fdc7dc9e1e 100644
--- a/nis/nss_nis/nis-pwd.c
+++ b/nis/nss_nis/nis-pwd.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 1996-1998,2001,2002,2003,2006 Free Software Foundation, Inc.
+/* Copyright (C) 1996-1998,2001-2003,2006,2009 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Thorsten Kukuk <kukuk@vt.uni-paderborn.de>, 1996.
 
@@ -116,7 +116,7 @@ internal_nis_endpwent (void)
       oldkeylen = 0;
     }
 
-  struct response_t *curr = intern.next;
+  struct response_t *curr = intern.start;
 
   while (curr != NULL)
     {