From: Peter Rajnoha <prajnoha@redhat.com>
Date: Tue, 4 Aug 2015 07:51:16 +0000 (+0200)
Subject: coverity: variable init must be done before its use
X-Git-Tag: v2_02_127~21
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=1f3d04cddf5a447de9bfb81ed22d0ccbe58e82fc;p=lvm2.git

coverity: variable init must be done before its use

tools/polldaemon.c:465: uninit_use_in_call: Using uninitialized value "id.vg_name" when calling "print_log".
tools/polldaemon.c:465: uninit_use_in_call: Using uninitialized value "id.lv_name" when calling "print_log".
---

diff --git a/tools/polldaemon.c b/tools/polldaemon.c
index 4527efb97..83928b730 100644
--- a/tools/polldaemon.c
+++ b/tools/polldaemon.c
@@ -461,13 +461,14 @@ static int _lvmpolld_init_poll_vg(struct cmd_context *cmd, const char *vgname,
 		if (!id.display_name && !lpdp->parms->aborting)
 			continue;
 
+		id.vg_name = lv->vg->name;
+		id.lv_name = lv->name;
+
 		if (!*lv->lvid.s) {
 			log_print_unless_silent("Missing LV uuid within: %s/%s", id.vg_name, id.lv_name);
 			continue;
 		}
 
-		id.vg_name = lv->vg->name;
-		id.lv_name = lv->name;
 		id.uuid = lv->lvid.s;
 
 		r = lvmpolld_poll_init(cmd, &id, lpdp->parms);