From: Bryn M. Reeves <bmr@redhat.com>
Date: Thu, 1 Nov 2018 16:47:56 +0000 (+0000)
Subject: libdm-stats: move no regions warning after dm_stats_list()
X-Git-Tag: v2_03_03~393
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=19f2105b87773047854ef172de8fc48da110b2fa;p=lvm2.git

libdm-stats: move no regions warning after dm_stats_list()

It doesn't make sense to test or warn about the region count until
the stats handle has been listed: at this point it may or may not
contain valid information (but is guaranteed to be correct after
the list).
---

diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c
index 014395756..ca46d9a67 100644
--- a/libdm/libdm-stats.c
+++ b/libdm/libdm-stats.c
@@ -2338,11 +2338,6 @@ int dm_stats_populate(struct dm_stats *dms, const char *program_id,
 		return 0;
 	}
 
-	if (!dms->nr_regions) {
-		log_error("No regions registered.");
-		return 0;
-	}
-
 	/* allow zero-length program_id for populate */
 	if (!program_id)
 		program_id = dms->program_id;
@@ -2354,6 +2349,11 @@ int dm_stats_populate(struct dm_stats *dms, const char *program_id,
 		goto_bad;
 	}
 
+	if (!dms->nr_regions) {
+		log_verbose("No stats regions registered: %s", dms->name);
+		return 0;
+	}
+
 	dms->walk_flags = DM_STATS_WALK_REGION;
 	dm_stats_walk_start(dms);
 	do {