From: Josh Stone <jistone@redhat.com>
Date: Tue, 24 Jul 2012 21:07:30 +0000 (-0700)
Subject: Explain add_block_tid and add_call_probe_tid
X-Git-Tag: release-2.0~257
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=1630966a640f190bd8803eb891f8711756d12b45;p=systemtap.git

Explain add_block_tid and add_call_probe_tid

Commit 8cc799a5d mentioned their need, but it should be commented.
---

diff --git a/tapsets.cxx b/tapsets.cxx
index 62b050874..9141ef4a9 100644
--- a/tapsets.cxx
+++ b/tapsets.cxx
@@ -2187,6 +2187,9 @@ struct dwarf_var_expanding_visitor: public var_expanding_visitor
   Dwarf_Addr addr;
   block *add_block;
   block *add_call_probe; // synthesized from .return probes with saved $vars
+  // NB: tids are not always collected in add_block & add_call_probe, because
+  // gen_kretprobe_saved_return doesn't need them.  Thus we need these extra
+  // *_tid bools for gen_mapped_saved_return to tell what's there.
   bool add_block_tid, add_call_probe_tid;
   unsigned saved_longs, saved_strings; // data saved within kretprobes
   map<std::string, expression *> return_ts_map;