From: Corinna Vinschen <corinna@vinschen.de>
Date: Sat, 24 Feb 2024 09:46:54 +0000 (+0100)
Subject: Cygwin: newgrp: fix invalid usage of argv
X-Git-Tag: cygwin-3.5.1~7
X-Git-Url: https://sourceware.org/git/?a=commitdiff_plain;h=08df2e23a75190fced8c1a2446ebaee4f469eb96;p=newlib-cygwin.git

Cygwin: newgrp: fix invalid usage of argv

Fix an error message accessing argv[1] even after it has been
potentially moved.  Print group name from group DB instead.

Fixes: 8bd56ec873453 ("Cygwin: newgrp: first full version")
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
---

diff --git a/winsup/utils/newgrp.c b/winsup/utils/newgrp.c
index 88586352e..e312a3c51 100644
--- a/winsup/utils/newgrp.c
+++ b/winsup/utils/newgrp.c
@@ -160,6 +160,7 @@ main (int argc, const char **argv)
   if (argv[1] == NULL)
     {
       gid = pw->pw_gid;
+      gr = getgrgid (gid);
     }
   else
     {
@@ -179,7 +180,7 @@ main (int argc, const char **argv)
   if (setgid (gid) != 0)
     {
       fprintf (stderr, "%s: can't switch primary group to '%s'\n",
-	       program_invocation_short_name, argv[1]);
+	       program_invocation_short_name, gr->gr_name);
       return 2;
     }