ENOENT if non-existent file got opened for reading only. Explain why.
* path.cc (path_conv::check): Stick to ENOENT if file has been opened
for informational purposes only. Add to comment.
+2012-04-04 Corinna Vinschen <corinna@vinschen.de>
+
+ * fhandler_nodevice.cc (fhandler_nodevice::open): Convert EROFS to
+ ENOENT if non-existent file got opened for reading only. Explain why.
+ * path.cc (path_conv::check): Stick to ENOENT if file has been opened
+ for informational purposes only. Add to comment.
+
2012-04-04 Corinna Vinschen <corinna@vinschen.de>
* path.cc (path_conv::check): Convert device type to FH_FS for
#include "fhandler.h"
int
-fhandler_nodevice::open (int, mode_t)
+fhandler_nodevice::open (int flags, mode_t)
{
if (!pc.error)
set_errno (ENXIO);
+ /* Fixup EROFS error returned from path_conv if /dev is not backed by real
+ directory on disk and the file doesn't exist. */
+ else if (pc.error == EROFS && (flags & O_ACCMODE) == O_RDONLY)
+ set_errno (ENOENT);
return 0;
}
subsequent code handles the file correctly.
Unless /dev itself doesn't exist on disk. In that case /dev
is handled as virtual filesystem, and virtual filesystems are
- read-only. */
- if (sym.error == ENOENT)
+ read-only. The PC_KEEP_HANDLE check allows to check for
+ a call from an informational system call. In that case we
+ just stick to ENOENT, and the device type doesn't matter
+ anyway. */
+ if (sym.error == ENOENT && !(opt & PC_KEEP_HANDLE))
sym.error = EROFS;
else
dev.d.devn = FH_FS;