dm: fix thin-pool targer params order

Wrong thin-pool feature flag ordering in dm table: It will lead to
unnecessary table reload.

Fix it by placeing feature flags in order they are returned from the
kernel so current 'table line diff' code will not see a difference.

diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 2fb1274e2518fd0f75ee81d3d1d48f03a7f98f26..f54868f802777913ee55c41df8d349d2a29909bd 100644 (file)
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,6 @@
 Version 1.02.116 - 
 ====================================
+  Fix thin-pool table parameter feature order to match kernel output.
 
 Version 1.02.115 - 25th January 2016
 ====================================

diff --git a/libdm/libdm-deptree.c b/libdm/libdm-deptree.c
index 1b9d6d385aa039548c7bd2f2c3ee3c019665123c..f8b6d893c77ba8c35764483e2b940390566f59ec 100644 (file)
--- a/libdm/libdm-deptree.c
+++ b/libdm/libdm-deptree.c
@@ -2477,11 +2477,11 @@ static int _thin_pool_emit_segment_line(struct dm_task *dmt,
 
        EMIT_PARAMS(pos, "%s %s %d %" PRIu64 " %d%s%s%s%s%s", metadata, pool,
                    seg->data_block_size, seg->low_water_mark, features,
-                   seg->error_if_no_space ? " error_if_no_space" : "",
-                   seg->read_only ? " read_only" : "",
                    seg->skip_block_zeroing ? " skip_block_zeroing" : "",
                    seg->ignore_discard ? " ignore_discard" : "",
-                   seg->no_discard_passdown ? " no_discard_passdown" : ""
+                   seg->no_discard_passdown ? " no_discard_passdown" : "",
+                   seg->error_if_no_space ? " error_if_no_space" : "",
+                   seg->read_only ? " read_only" : ""
                   );
 
        return 1;