pvck: repair should clear hints

repairing a pv can cause the hint file to become incorrect

diff --git a/test/shell/hints.sh b/test/shell/hints.sh
index f95505a20990006d1c9af2be1d8f919338a68bad..176ee2176ca4298465ecf576def250d6fd7c4532 100644 (file)
--- a/test/shell/hints.sh
+++ b/test/shell/hints.sh
@@ -338,6 +338,21 @@ pvs
 not diff $HINTS $PREV
 
 
+#
+# Test pvck --repair forces refresh
+#
+
+rm $HINTS $PREV
+pvs
+cp $HINTS $PREV
+pvck --repairtype label_header -y "$dev5"
+cat $NEWHINTS
+grep 'Created empty by pvck' $HINTS
+# this next pvs creates new hints
+pvs
+# the only diff will be "Created by..."
+not diff $HINTS $PREV
+
 
 #
 # Test incorrect dev-to-pvid info in hints is detected

diff --git a/tools/pvck.c b/tools/pvck.c
index 302c746216d1b806883c601ffbb2d04d07c23a03..39449af68f237c7e6a8cca74a6d9bad8c4961107 100644 (file)
--- a/tools/pvck.c
+++ b/tools/pvck.c
@@ -3037,6 +3037,8 @@ int pvck(struct cmd_context *cmd, int argc, char **argv)
        if (arg_is_set(cmd, repairtype_ARG) || arg_is_set(cmd, repair_ARG)) {
                pv_name = argv[0];
 
+               clear_hint_file(cmd);
+
                if (!(dev = dev_cache_get(cmd, pv_name, cmd->filter))) {
                        log_error("No device found for %s %s.", pv_name, dev_cache_filtered_reason(pv_name));
                        return ECMD_FAILED;