. update documentation for --poll in the vgchange and lvchange man pages

. add high-level --poll FIXMEs to vgchange.c and lvchange.c

diff --git a/man/lvchange.8.in b/man/lvchange.8.in
index c18aec2ec91e83342ba0b3187ddda2e46068fd7b..08a83c49892f2dac22527702e9e788b334dd096a 100644 (file)
--- a/man/lvchange.8.in
+++ b/man/lvchange.8.in
@@ -64,12 +64,12 @@ the failure is handled according to
 set in \fBlvm.conf\fP.
 .TP
 .I \-\-poll y|n
-Controls whether or not a logical volume's progress is polled.  It may
-not be appropriate to immediately poll the progress of a logical
-volume's transformation when it is activated (for example, when merging
-a snapshot into the root FS).  The progress polling of an incomplete
-pvmove or lvconvert can be deferred using \fB--poll n\fP and restarted
-using \fB--poll y\fP.
+Without polling a logical volume's backgrounded transformation process
+will never complete.  If there is an incomplete pvmove or lvconvert (for
+example, on rebooting after a crash), use \fB--poll y\fP to restart the
+process from its last checkpoint.  However, it may not be appropriate to
+immediately poll a logical volume when it is activated, use \fB--poll
+n\fP to defer and then \fB--poll y\fP to restart the process.
 .TP
 .I \-\-noudevsync
 Disable udev synchronisation. The

diff --git a/man/vgchange.8.in b/man/vgchange.8.in
index ad0982339aea3eead4f3026298cee679c6300ebe..5013c1e884e0a4672de2043d399f029119dbc2f9 100644 (file)
--- a/man/vgchange.8.in
+++ b/man/vgchange.8.in
@@ -89,12 +89,12 @@ set in
 .BR lvm.conf (5).
 .TP
 .BR \-\-poll " " { y | n }
-Controls whether or not a logical volume's progress is polled.  It may
-not be appropriate to immediately poll the progress of a logical
-volume's transformation when it is activated (for example, when merging
-a snapshot into the root FS).  The progress polling of an incomplete
-pvmove or lvconvert can be deferred using \fB--poll n\fP and restarted
-using \fB--poll y\fP.
+Without polling a logical volume's backgrounded transformation process
+will never complete.  If there is an incomplete pvmove or lvconvert (for
+example, on rebooting after a crash), use \fB--poll y\fP to restart the
+process from its last checkpoint.  However, it may not be appropriate to
+immediately poll a logical volume when it is activated, use \fB--poll
+n\fP to defer and then \fB--poll y\fP to restart the process.
 .TP
 .BR \-\-noudevsync
 Disable udev synchronisation. The

diff --git a/tools/lvchange.c b/tools/lvchange.c
index 11e128a564930fe83a6efd04d9d43ba3d073c7d5..5118e51085ac5ca1cea0eff3d4a642ce4638c73d 100644 (file)
--- a/tools/lvchange.c
+++ b/tools/lvchange.c
@@ -596,6 +596,13 @@ static int lvchange_single(struct cmd_context *cmd, struct logical_volume *lv,
                                            (is_static() || arg_count(cmd, ignoremonitoring_ARG)) ?
                                            DMEVENTD_MONITOR_IGNORE : DEFAULT_DMEVENTD_MONITOR));
 
+       /*
+        * FIXME: DEFAULT_BACKGROUND_POLLING should be "unspecified".
+        * If --poll is explicitly provided use it; otherwise polling
+        * should only be started if the LV is not already active. So:
+        * 1) change the activation code to say if the LV was actually activated
+        * 2) make polling of an LV tightly coupled with LV activation
+        */
        init_background_polling(arg_int_value(cmd, poll_ARG,
                                              DEFAULT_BACKGROUND_POLLING));
 

diff --git a/tools/vgchange.c b/tools/vgchange.c
index cd692b34b1523aac6b964990b8a0167f5e29c761..e425f14caad85bb0a58ceddc255714fe0d3663e8 100644 (file)
--- a/tools/vgchange.c
+++ b/tools/vgchange.c
@@ -548,6 +548,13 @@ static int vgchange_single(struct cmd_context *cmd, const char *vg_name,
                                            (is_static() || arg_count(cmd, ignoremonitoring_ARG)) ?
                                            DMEVENTD_MONITOR_IGNORE : DEFAULT_DMEVENTD_MONITOR));
 
+       /*
+        * FIXME: DEFAULT_BACKGROUND_POLLING should be "unspecified".
+        * If --poll is explicitly provided use it; otherwise polling
+        * should only be started if the LV is not already active. So:
+        * 1) change the activation code to say if the LV was actually activated
+        * 2) make polling of an LV tightly coupled with LV activation
+        */
        init_background_polling(arg_int_value(cmd, poll_ARG,
                                              DEFAULT_BACKGROUND_POLLING));