Use unsigned type for bitmask

Using report_type_t for bitmask is not correct, since we have not defined types
for all  bit combinations - so switching to unsigned type, since values of
report_type_t enum are unsigned.

diff --git a/WHATS_NEW b/WHATS_NEW
index 1f2e2b3c7a3bc5fe935946f680b42b63ba379632..bf6a05dbdb90a7c382f398efed1e22887a74ab03 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.94 - 
 ====================================
+  Use unsigned type for bitmask instead of enum type for lvm properties.
   Add missing cleanup of excl_uuid hash on some exit paths of clvmd.
   Check for existance of vg_name in _format1/_pool_vg_read().
   Fix missing break in _format_pvsegs (2.02.92).

diff --git a/lib/report/properties.c b/lib/report/properties.c
index b2f6d7b36604c9ab66596c2cf0cf4092429d48d1..0855f955eb361e5a817e715ff5d38a3982db8c27 100644 (file)
--- a/lib/report/properties.c
+++ b/lib/report/properties.c
@@ -315,7 +315,7 @@ struct lvm_property_type _properties[] = {
 
 
 static int _get_property(const void *obj, struct lvm_property_type *prop,
-                        report_type_t type)
+                        unsigned type)
 {
        struct lvm_property_type *p;
 
@@ -343,7 +343,7 @@ static int _get_property(const void *obj, struct lvm_property_type *prop,
 }
 
 static int _set_property(void *obj, struct lvm_property_type *prop,
-                        report_type_t type)
+                        unsigned type)
 {
        struct lvm_property_type *p;
 

diff --git a/lib/report/properties.h b/lib/report/properties.h
index f363362c7ab81b90cce1028ddcf63f6c5138634e..aefd3f589a49f64d148036b28f2d450b1d88d61b 100644 (file)
--- a/lib/report/properties.h
+++ b/lib/report/properties.h
@@ -20,7 +20,7 @@
 #include "report.h"
 
 struct lvm_property_type {
-       report_type_t type;
+       unsigned type;
        const char *id;
        unsigned is_settable:1;
        unsigned is_string:1;