]> sourceware.org Git - lvm2.git/commitdiff
coverity: make use of defined variable
authorZdenek Kabelac <zkabelac@redhat.com>
Sat, 17 Mar 2018 12:56:44 +0000 (13:56 +0100)
committerZdenek Kabelac <zkabelac@redhat.com>
Sat, 17 Mar 2018 22:33:58 +0000 (23:33 +0100)
Since we declare 'r', let's use the value for something.

lib/device/dev-io.c

index cb3a23415756669ccff30386da0ecb6d3665edd1..1d16a660f31acd5f8ae8e4c1356fbd31ec39def5 100644 (file)
@@ -649,14 +649,10 @@ static int _aligned_io(struct device_area *where, char *write_buffer,
        /* ... then we write */
        devbuf->write = 1;
        if (!(r = _io(devbuf, 0)))
-               goto_bad;
-
-       _release_devbuf(devbuf);
-       return 1;
-
+               stack;
 bad:
        _release_devbuf(devbuf);
-       return 0;
+       return r;
 }
 
 static int _dev_get_size_file(struct device *dev, uint64_t *size)
This page took 0.037975 seconds and 5 git commands to generate.