]> sourceware.org Git - lvm2.git/commitdiff
Simplify iteration
authorZdenek Kabelac <zkabelac@redhat.com>
Tue, 15 Nov 2011 17:21:02 +0000 (17:21 +0000)
committerZdenek Kabelac <zkabelac@redhat.com>
Tue, 15 Nov 2011 17:21:02 +0000 (17:21 +0000)
Since nothing is removed in dm_list snapshot_segs during the loop,
there is no reason to use _safe iteration, so switch to simplier
dm_list_iterate().

lib/activate/dev_manager.c

index 80ae8dd59bedea050f9a7992295284ecd3493f08..b15402e5cea362d9865ac4f07aac748eebb9a96e 100644 (file)
@@ -1118,7 +1118,7 @@ static int _add_lv_to_dtree(struct dev_manager *dm, struct dm_tree *dtree,
 static struct dm_tree *_create_partial_dtree(struct dev_manager *dm, struct logical_volume *lv, int origin_only)
 {
        struct dm_tree *dtree;
-       struct dm_list *snh, *snht;
+       struct dm_list *snh;
        struct lv_segment *seg;
        uint32_t s;
 
@@ -1132,7 +1132,7 @@ static struct dm_tree *_create_partial_dtree(struct dev_manager *dm, struct logi
 
        /* Add any snapshots of this LV */
        if (!origin_only && lv_is_origin(lv))
-               dm_list_iterate_safe(snh, snht, &lv->snapshot_segs)
+               dm_list_iterate(snh, &lv->snapshot_segs)
                        if (!_add_lv_to_dtree(dm, dtree, dm_list_struct_base(snh, struct lv_segment, origin_list)->cow, 0))
                                goto_bad;
 
This page took 0.034904 seconds and 5 git commands to generate.