2003-09-26 Pierre Humblet <pierre.humblet@ieee.org>

	* pinfo.cc (pinfo::init): Do not give FILE_MAP_WRITE access to Everybody.
	* exceptions.cc (sig_handle_tty_stop): Do not create pinfo parent with
	PID_MAP_WRITE.
	* fhandler_process.cc (fhandler_process::fill_filebuf): Ditto for pinfo p.
	* signal.cc (kill_worker): Ditto for pinfo dest.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 485dd7729ef044be372fc112796a28ee42eba965..7159614a4a455e9a0d46840c8b00b70d489caeb1 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,11 @@
+2003-09-26  Pierre Humblet <pierre.humblet@ieee.org>
+
+       * pinfo.cc (pinfo::init): Do not give FILE_MAP_WRITE access to Everybody.
+       * exceptions.cc (sig_handle_tty_stop): Do not create pinfo parent with
+       PID_MAP_WRITE.
+       * fhandler_process.cc (fhandler_process::fill_filebuf): Ditto for pinfo p.
+       * signal.cc (kill_worker): Ditto for pinfo dest.
+
 2003-09-26  Pierre Humblet <pierre.humblet@ieee.org>
 
        * pinfo.h (pinfo::set_acl): Declare.

diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc
index a5b32c3a6ba22429b8a4de47caf58584c4a3df87..24b452be78210760755ae213b9a9d4843427a910 100644 (file)
--- a/winsup/cygwin/exceptions.cc
+++ b/winsup/cygwin/exceptions.cc
@@ -616,7 +616,7 @@ sig_handle_tty_stop (int sig)
      its list of subprocesses.  */
   if (my_parent_is_alive ())
     {
-      pinfo parent (myself->ppid, PID_MAP_RW);
+      pinfo parent (myself->ppid);
       if (ISSTATE (parent, PID_NOCLDSTOP))
        sig_send (parent, SIGCHLD);
     }

diff --git a/winsup/cygwin/fhandler_process.cc b/winsup/cygwin/fhandler_process.cc
index 716a20f00f262564a008bc5e03a205fa53849344..3b61cd918740959cf1f16a86082340f64457506f 100644 (file)
--- a/winsup/cygwin/fhandler_process.cc
+++ b/winsup/cygwin/fhandler_process.cc
@@ -245,8 +245,7 @@ out:
 bool
 fhandler_process::fill_filebuf ()
 {
-  pinfo p (pid, PID_MAP_RW);   // PID_MAP_RW for cmdline since it
-                               // needs to signal the other process
+  pinfo p (pid);
 
   if (!p)
     {

diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc
index 0967215e71316097f87ee933fac779dece49f09f..ce210c3c5ff9c833a6a8ddb71501cfd321283b1b 100644 (file)
--- a/winsup/cygwin/pinfo.cc
+++ b/winsup/cygwin/pinfo.cc
@@ -170,7 +170,7 @@ pinfo::init (pid_t n, DWORD flag, HANDLE in_h)
          char sa_buf[1024];
          PSECURITY_ATTRIBUTES sec_attribs =
            sec_user_nih (sa_buf, cygheap->user.sid(), well_known_world_sid,
-                         FILE_MAP_READ | FILE_MAP_WRITE); /* FIXME */
+                         FILE_MAP_READ);
          h = CreateFileMapping (INVALID_HANDLE_VALUE, sec_attribs,
                                 PAGE_READWRITE, 0, mapsize, mapname);
          created = h && GetLastError () != ERROR_ALREADY_EXISTS;

diff --git a/winsup/cygwin/signal.cc b/winsup/cygwin/signal.cc
index a7e25ea4672e299685dba5999a20e6ca0dd83435..7f6fcbe44018ba1066cd88b57bb8cf189b7df2d5 100644 (file)
--- a/winsup/cygwin/signal.cc
+++ b/winsup/cygwin/signal.cc
@@ -173,7 +173,7 @@ kill_worker (pid_t pid, int sig)
   sig_dispatch_pending ();
 
   int res = 0;
-  pinfo dest (pid, PID_MAP_RW);
+  pinfo dest (pid);
   BOOL sendSIGCONT;
 
   if (!dest)