* spawn.cc (spawn_guts): Fix potential handle leak when failing exec.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 1fd67e5139944fc4383d2b984f6b64dd77799ff4..1cb69b9efbe36fef7158fc5773ed4284c02959d1 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,7 @@
+2006-01-27  Christopher Faylor  <cgf@timesys.com>
+
+       * spawn.cc (spawn_guts): Fix potential handle leak when failing exec.
+
 2006-01-27  Christopher Faylor  <cgf@timesys.com>
 
        * exceptions.cc (inside_kernel): Fix to return true if we can't get the

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 4e5982ce8cd0c57973e27e0eb4f7d6d176f07afd..8edbf55eb473e35fc6840054c8581cc03084906b 100644 (file)
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -731,7 +731,8 @@ spawn_guts (const char * prog_arg, const char *const *argv,
          myself->exec_sendsig = NULL;
        }
       res = -1;
-      CloseHandle (moreinfo->myself_pinfo);
+      if (moreinfo->myself_pinfo)
+       CloseHandle (moreinfo->myself_pinfo);
       goto out;
     }