* path.cc (readlink): 'max' should be a 'min' or we'll suffer buffer overflow.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 2d4429db5ccd82ea2e767dd34d58a772954b647d..e6be90e2043a3849fbf0eeb3af88d599b9018211 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,8 @@
+Tue Sep  5 17:49:34 2000  Christopher Faylor <cgf@cygnus.com>
+
+       * path.cc (readlink): 'max' should be a 'min' or we'll suffer
+       buffer overflow.
+
 Mon Sep  4 22:53:58 2000  Christopher Faylor <cgf@cygnus.com>
 
        * path.cc (cwd_win32): Eliminate.

diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
index 599d00a79b4bb04e52193c8b68ee55af40cf1f3d..2033d257c6c42132e3095fec69eda80aab939cdd 100644 (file)
--- a/winsup/cygwin/path.cc
+++ b/winsup/cygwin/path.cc
@@ -2353,7 +2353,7 @@ readlink (const char *path, char *buf, int buflen)
       return -1;
     }
 
-  int len = max (buflen, (int) strlen (pathbuf.get_win32 ()));
+  int len = min (buflen, (int) strlen (pathbuf.get_win32 ()));
   memcpy (buf, pathbuf.get_win32 (), len);
 
   /* errno set by symlink.check if error */