Move arg_vgnames from local scope

As gcc puts probably all vars on stack this bug was not noticed in runtime.
Patch fixes referencing local scope list variable.

diff --git a/WHATS_NEW b/WHATS_NEW
index 7412efca05a600ea788ae5b7ec5fbada09554e5f..669ebd40bb063bcef3e0871e65849dd5f03c2235 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.78 - 
 ====================================
+  Fix out-of-scope variable usage in process_each_lv().
   Fix dm_task_destroy(NULL) call in _node_clear_table() error path.
   Fix resource leak in _rm_blks().
   Suppress 'No PV label' message when removing several PVs without mdas.

diff --git a/tools/toollib.c b/tools/toollib.c
index 6aa0fbb13a9c5c736e00398a0d65cf7d51f62a64..9af16307022e5e3abc1cf4f607bf6e6406a2727c 100644 (file)
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -198,6 +198,7 @@ int process_each_lv(struct cmd_context *cmd, int argc, char **argv,
        struct dm_list failed_lvnames;
        struct dm_list tags, lvnames;
        struct dm_list arg_lvnames;     /* Cmdline vgname or vgname/lvname */
+       struct dm_list arg_vgnames;
        char *vglv;
        size_t vglv_sz;
 
@@ -208,8 +209,6 @@ int process_each_lv(struct cmd_context *cmd, int argc, char **argv,
        dm_list_init(&failed_lvnames);
 
        if (argc) {
-               struct dm_list arg_vgnames;
-
                log_verbose("Using logical volume(s) on command line");
                dm_list_init(&arg_vgnames);