Don't use as_root() to run stap within tapset_functions.exp

Most of the other as_root() in the testsuite is for stuff that
genuinely has to be root, like loading some test kernel module
that we'll probe.  For running the testsuite under a regular
user, stap{user,sys,dev} group membership mechanism should be
used instead.

diff --git a/testsuite/systemtap.stress/tapset_functions.exp b/testsuite/systemtap.stress/tapset_functions.exp
index 6acb3a1d1e3c26cd5bc9ee38ca3f03b204e082d5..25678fe1ee2c79843fd7be33ff97b2e3553ba501 100644 (file)
--- a/testsuite/systemtap.stress/tapset_functions.exp
+++ b/testsuite/systemtap.stress/tapset_functions.exp
@@ -241,11 +241,12 @@ foreach line [split $outputv "\n"] {
                 close $testscript
                 # Debug-mode test
                 verbose -log "testing ${fname}(${fargs})"
-                set rc [as_root "stap -g $opts testscript.stp 2>@1"]
+                set rc [catch {eval exec "stap -g $opts testscript.stp 2>@1"} msg]
                 if {$rc == 0} {
                     pass "testscript (${fname}(${fargs}))"
                 } else {
                     fail "testscript (${fname}(${fargs}))"
+                    verbose -log "$msg"
                 }
                 dmesg_check
             } else {
@@ -260,11 +261,12 @@ if { !$debugmode } {
     close $testscript
     # Non-debug-mode test
     dmesg_snap
-    set rc [as_root "stap -g $opts testscript.stp 2>@1"]
+    set rc [catch {eval exec "stap -g $opts testscript.stp 2>@1"} msg]
     if {$rc == 0} {
         pass "testscript"
     } else {
         fail "testscript"
+        verbose -log "$msg"
     }
     dmesg_check
 }