Fix some Coverity Scan errors.

diff --git a/newlib/libc/posix/sleep.c b/newlib/libc/posix/sleep.c
index f7c780ef01baf3479a3cb7a1099c6720d43017c2..0d6cd710ded80381001f35a28301e6a0d591885e 100644 (file)
--- a/newlib/libc/posix/sleep.c
+++ b/newlib/libc/posix/sleep.c
@@ -7,6 +7,7 @@
 #include <errno.h>
 #include <time.h>
 #include <unistd.h>
+#include <limits.h>
 
 unsigned sleep(unsigned seconds)
 {
@@ -15,7 +16,7 @@ unsigned sleep(unsigned seconds)
     ts.tv_sec = seconds;
     ts.tv_nsec = 0;
     if (!nanosleep(&ts,&ts)) return 0;
-    if (errno == EINTR) return ts.tv_sec;
+    if (errno == EINTR) return ts.tv_sec & UINT_MAX;
     return -1;
 }
 

diff --git a/newlib/libc/posix/usleep.c b/newlib/libc/posix/usleep.c
index 9322b6551efdbe216ad9c1f9a2acce831bf26578..cc1b3140860b64fe611ff86e138b32ac350c18d8 100644 (file)
--- a/newlib/libc/posix/usleep.c
+++ b/newlib/libc/posix/usleep.c
@@ -15,7 +15,6 @@ int usleep(useconds_t useconds)
     ts.tv_sec = (long int)useconds / 1000000;
     ts.tv_nsec = ((long int)useconds % 1000000) * 1000;
     if (!nanosleep(&ts,&ts)) return 0;
-    if (errno == EINTR) return ts.tv_sec;
     return -1;
 }
 

diff --git a/newlib/libc/stdio/swscanf.c b/newlib/libc/stdio/swscanf.c
index 5514e68c05fe95252abb241e230352bd74bcf863..578ac3c93f7608968524644ebea4c1ff335195f0 100644 (file)
--- a/newlib/libc/stdio/swscanf.c
+++ b/newlib/libc/stdio/swscanf.c
@@ -427,6 +427,8 @@ swscanf (const wchar_t *__restrict str, const wchar_t *__restrict fmt, ...)
   f._read = __seofread;
   f._ub._base = NULL;
   f._lb._base = NULL;
+  f._flags2 = 0;
+  f._ur = 0;
   f._file = -1;  /* No file. */
   va_start (ap, fmt);
   ret = __ssvfwscanf_r (_REENT, &f, fmt, ap);

diff --git a/newlib/libc/stdio/vswscanf.c b/newlib/libc/stdio/vswscanf.c
index 13b61f4a39264f462111c2bf8e6ca27a58103133..415c98b0f0ff0c54d8a7acd032f0b371051c9ded 100644 (file)
--- a/newlib/libc/stdio/vswscanf.c
+++ b/newlib/libc/stdio/vswscanf.c
@@ -53,6 +53,8 @@ _vswscanf_r (struct _reent *ptr, const wchar_t *str, const wchar_t *fmt,
   f._read = __seofread;
   f._ub._base = NULL;
   f._lb._base = NULL;
+  f._flags2 = 0;
+  f._ur = 0;
   f._file = -1;  /* No file. */
   return __ssvfwscanf_r (ptr, &f, fmt, ap);
 }

diff --git a/newlib/libc/stdlib/arc4random.c b/newlib/libc/stdlib/arc4random.c
index 5860d644a3db35c127ecc8a64ddd29b58599aa61..7bd9e7c5ef993a719d80748ddb85b69065d38103 100644 (file)
--- a/newlib/libc/stdlib/arc4random.c
+++ b/newlib/libc/stdlib/arc4random.c
@@ -86,6 +86,8 @@ _rs_stir(void)
 {
        u_char rnd[KEYSZ + IVSZ];
 
+       memset(rnd, 0, (KEYSZ + IVSZ) * sizeof(u_char));
+
        if (getentropy(rnd, sizeof rnd) == -1)
                _getentropy_fail();
 

diff --git a/newlib/libc/time/time.c b/newlib/libc/time/time.c
index 93e061b8314040ada130cd388f15517b64d2f724..b431f7ae5609eb88ee482b32ce194e8f328ca0f0 100644 (file)
--- a/newlib/libc/time/time.c
+++ b/newlib/libc/time/time.c
@@ -37,6 +37,8 @@ time (time_t * t)
 {
   struct timeval now;
 
+  now.tv_sec = (time_t) -1;
+
   if (_gettimeofday_r (_REENT, &now, NULL) < 0)
     now.tv_sec = (time_t) -1;