* pinfo.cc (pinfo::pinfo): Set procinfo to NULL to avoid potential cleanup of

uninitialized garbage.  (Suggested by Ryan Johnson)

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index b348b12c894d425c1d3fc9608796a1e40a58ba18..da31c62247adcfc284502a55db02125b7ac115d1 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,8 @@
+2011-05-04  Christopher Faylor  <me.cygwin2011@cgf.cx>
+
+       * pinfo.cc (pinfo::pinfo): Set procinfo to NULL to avoid potential
+       cleanup of uninitialized garbage.  (Suggested by Ryan Johnson)
+
 2011-05-03  Corinna Vinschen  <corinna@vinschen.de>
 
        * select.cc (cygwin_select): Make degenerate case cancelable.

diff --git a/winsup/cygwin/pinfo.h b/winsup/cygwin/pinfo.h
index be6a0b6610a49a7ef89f89ec8a1851137c441d1f..b47b59f7f4581e94063a1d2b992b61f43867c985 100644 (file)
--- a/winsup/cygwin/pinfo.h
+++ b/winsup/cygwin/pinfo.h
@@ -142,7 +142,7 @@ public:
   bool waiter_ready;
   class cygthread *wait_thread;
   void init (pid_t, DWORD, HANDLE) __attribute__ ((regparm(3)));
-  pinfo () {}
+  pinfo (): procinfo (NULL) {}
   pinfo (_pinfo *x): procinfo (x), hProcess (NULL) {}
   pinfo (pid_t n) : rd_proc_pipe (NULL), hProcess (NULL) {init (n, 0, NULL);}
   pinfo (pid_t n, DWORD flag) : rd_proc_pipe (NULL), hProcess (NULL), waiter_ready (0), wait_thread (NULL) {init (n, flag, NULL);}