PR 4179.
Based on patch from Vasily Averin <vvs@sw.ru>:
* time.c (_stp_init_time): Recover from partial failures.
2007-03-12 Frank Ch. Eigler <fche@redhat.com>
PR 4179.
Based on patch from Vasily Averin <vvs@sw.ru>:
* procfs.c (_stp_register_procfs): Recover from partial failures.
* transport.c (_stp_transport_open): Ditto.
+2007-03-12 Frank Ch. Eigler <fche@redhat.com>
+
+ PR 4179.
+ Based on patch from Vasily Averin <vvs@sw.ru>:
+ * time.c (_stp_init_time): Recover from partial failures.
+
2007-03-01 David Wilder <dwilder@us.ibm.com>
* loc2c-runtime.h: rewrote s390x version of __stp_put_asm
}
}
#endif
-
+ if (ret)
+ _stp_kill_time();
return ret;
}
+2007-03-12 Frank Ch. Eigler <fche@redhat.com>
+
+ PR 4179.
+ Based on patch from Vasily Averin <vvs@sw.ru>:
+ * procfs.c (_stp_register_procfs): Recover from partial failures.
+ * transport.c (_stp_transport_open): Ditto.
+
2007-01-30 Martin Hunt <hunt@redhat.com>
* symbols.c: Comment out many debug lines.
/* -*- linux-c -*-
*
* /proc transport and control
- * Copyright (C) 2005, 2006, 2007 Red Hat Inc.
+ * Copyright (C) 2005-2007 Red Hat Inc.
*
* This file is part of systemtap, and is free software. You can
* redistribute it and/or modify it under the terms of the GNU General
p = (struct list_head *)kmalloc(sizeof(struct _stp_buffer),STP_ALLOC_FLAGS);
// printk("allocated buffer at %lx\n", (long)p);
if (!p)
- goto err2;
+ goto err0;
_stp_allocated_net_memory += sizeof(struct _stp_buffer);
list_add (p, &_stp_pool_q);
}
de->proc_fops = &_stp_proc_fops_cmd;
return 0;
-err2:
- list_for_each_safe(p, tmp, &_stp_pool_q) {
- list_del(p);
- kfree(p);
- }
-
err1:
#ifdef STP_RELAYFS
for (de = _stp_proc_mod->subdir; de; de = de->next)
#endif
remove_proc_entry (THIS_MODULE->name, _stp_proc_root);
err0:
+ list_for_each_safe(p, tmp, &_stp_pool_q) {
+ list_del(p);
+ kfree(p);
+ }
+
printk (KERN_ERR "Error creating systemtap /proc entries.\n");
return -1;
}
}
#endif
remove_proc_entry ("cmd", _stp_proc_mod);
- remove_proc_entry (THIS_MODULE->name, _stp_proc_root);
+ remove_proc_entry (THIS_MODULE->name, _stp_proc_root); /* XXX: race condition */
/* free memory pools */
list_for_each_safe(p, tmp, &_stp_pool_q) {
* transport.c - stp transport functions
*
* Copyright (C) IBM Corporation, 2005
- * Copyright (C) Red Hat Inc, 2005, 2006
+ * Copyright (C) Red Hat Inc, 2005-2007
* Copyright (C) Intel Corporation, 2006
*
* This file is part of systemtap, and is free software. You can
*/
int _stp_transport_init(void)
{
+ int ret;
+
kbug("transport_init from %ld %ld\n", (long)_stp_pid, (long)current->pid);
/* create print buffers */
- if (_stp_print_init() < 0)
- return -1;
+ ret = _stp_print_init();
+ if (ret < 0)
+ goto out;
/* initialize timer code */
- if (_stp_init_time())
- return -1;
+ ret =_stp_init_time();
+ if (ret)
+ goto print_cleanup;
/* set up procfs communications */
- if (_stp_register_procfs() < 0)
- return -1;
+ ret = _stp_register_procfs();
+ if (ret < 0)
+ goto kill_time;
/* create workqueue of kernel threads */
_stp_wq = create_workqueue("systemtap");
+ if (!_stp_wq)
+ goto proc_cleanup;
queue_delayed_work(_stp_wq, &_stp_work, STP_WORK_TIMER);
+out:
+ return ret;
- return 0;
+proc_cleanup:
+ ret = -1;
+ _stp_unregister_procfs();
+kill_time:
+ _stp_kill_time();
+print_cleanup:
+ _stp_print_cleanup(); /* free print buffers */
+ goto out;
}