Fix potential memory leak in argz_replace

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

diff --git a/newlib/ChangeLog b/newlib/ChangeLog
index a70fefea9988b8d61220583c2906114eadc1d3ac..d1b0afec863867c5620c43564213aa9162b50fc1 100644 (file)
--- a/newlib/ChangeLog
+++ b/newlib/ChangeLog
@@ -1,3 +1,7 @@
+2015-05-27  David Stacey  <drstacey@tiscali.co.uk>
+
+       * libc/argz/argz_replace.c: Fix potential memory leak.
+
 2015-05-26  DJ Delorie  <dj@redhat.com>
 
        * libm/math/e_sqrt.c (__ieee754_sqrt): Don't truncate constant to

diff --git a/newlib/libc/argz/argz_replace.c b/newlib/libc/argz/argz_replace.c
index cb01eaef5218a26d985ff941aee62af7a1b349a4..6bfd04b8a41f673d428fcf1e3ab455b5478d5f1f 100644 (file)
--- a/newlib/libc/argz/argz_replace.c
+++ b/newlib/libc/argz/argz_replace.c
@@ -71,7 +71,10 @@ _DEFUN (argz_replace, (argz, argz_len, str, with, replace_count),
 
       /* reallocate argz, and copy over the new value. */
       if(!(*argz = (char *)realloc(*argz, new_argz_len)))
-        return ENOMEM;
+        {
+          free(new_argz);
+          return ENOMEM;
+        }
 
       memcpy(*argz, new_argz, new_argz_len);
       *argz_len = new_argz_len;