]> sourceware.org Git - valgrind.git/commitdiff
Do not try to record fd name for io_uring_setup
authorMark Wielaard <mark@klomp.org>
Wed, 9 Feb 2022 22:37:53 +0000 (23:37 +0100)
committerMark Wielaard <mark@klomp.org>
Wed, 9 Feb 2022 22:37:53 +0000 (23:37 +0100)
In POST(sys_io_uring_setup) we tried to use record_fd_open_with_given_name
with ARG1 as name. But ARG1 isn't a char pointer. So this might crash with
--track-fds=yes. Since no (file) name is associated with the fd returned by
io_uring_setup use record_fd_open_nameless instead.

https://bugs.kde.org/show_bug.cgi?id=449838

NEWS
coregrind/m_syswrap/syswrap-linux.c

diff --git a/NEWS b/NEWS
index 718b8aef0aade57e138797a3a003dbfe57b54693..a60a07c91522fed1bd5e5164b5e5a607c670e6c4 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -65,6 +65,7 @@ are not entered into bugzilla tend to get forgotten about or ignored.
 449483  Powerpc: vcmpgtsq., vcmpgtuq,, vcmpequq. instructions not setting the
         condition code correctly.
 449672  ppc64 --track-origins=yes failures because of bad cmov addHRegUse
+449838  sigsegv liburing the 'impossible' happened for io_uring_setup
 
 To see details of a given bug, visit
   https://bugs.kde.org/show_bug.cgi?id=XXXXXX
index ac2a9f0c36a2c4196892b23e35e8755ae3871074..792589766bb9a2e68fbfd108c802b8428d9eae4a 100644 (file)
@@ -13206,7 +13206,7 @@ POST(sys_io_uring_setup)
       SET_STATUS_Failure( VKI_EMFILE );
    } else {
       if (VG_(clo_track_fds))
-         ML_(record_fd_open_with_given_name)(tid, RES, (HChar*)(Addr)ARG1);
+         ML_(record_fd_open_nameless)(tid, RES);
       POST_MEM_WRITE(ARG2 + offsetof(struct vki_io_uring_params, sq_off),
                      sizeof(struct vki_io_sqring_offsets) +
                      sizeof(struct vki_io_cqring_offsets));
This page took 1.804635 seconds and 5 git commands to generate.