Avoid cookie sharing between forked processes

Before fork, ensure cookie is reset so it's not shared between processes.

diff --git a/WHATS_NEW b/WHATS_NEW
index 1e66f42c56fc7b46a83250bc17d92c3e2616bcb4..4a5382325d467ded7d0b241652e8a44abfd2764c 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.81 - 
 ===================================
+  Fix cookie sharing between forked lvm processes (2.02.80).
 
 Version 2.02.80 - 10th January 2011
 ===================================

diff --git a/lib/misc/lvm-exec.c b/lib/misc/lvm-exec.c
index 5cad79eb2996d8c51e717a279bf13230b12f667d..6dde265c6ffef30eb2c61e53d03c03d70f291006 100644 (file)
--- a/lib/misc/lvm-exec.c
+++ b/lib/misc/lvm-exec.c
@@ -54,6 +54,8 @@ int exec_cmd(struct cmd_context *cmd, const char *const argv[], int *rstatus)
 
        log_verbose("Executing: %s", _verbose_args(argv, buf, sizeof(buf)));
 
+       fs_unlock(); /* Flush oops and ensure cookie is not shared */
+
        if ((pid = fork()) == -1) {
                log_error("fork failed: %s", strerror(errno));
                return 0;

diff --git a/tools/polldaemon.c b/tools/polldaemon.c
index 4da27fed701b2d9d68070a3d7c5c5549c22c6bfb..0ee7a8c596425d8320e601931edf92881697201f 100644 (file)
--- a/tools/polldaemon.c
+++ b/tools/polldaemon.c
@@ -42,6 +42,8 @@ static int _become_daemon(struct cmd_context *cmd)
 
        sigaction(SIGCHLD, &act, NULL);
 
+       fs_unlock(); /* Flush oops and ensure cookie is not shared */
+
        if ((pid = fork()) == -1) {
                log_error("fork failed: %s", strerror(errno));
                return -1;