]> sourceware.org Git - libabigail.git/commitdiff
Fix a thinko in removed variables detection
authorDodji Seketeli <dodji@redhat.com>
Fri, 24 Jul 2015 09:23:56 +0000 (11:23 +0200)
committerDodji Seketeli <dodji@redhat.com>
Fri, 24 Jul 2015 09:23:56 +0000 (11:23 +0200)
It appears the comparison engine was counting more deleted variables
than necessary, due to a thinko.  Fixed thus.

* src/abg-comparison.cc
(corpus_diff::priv::ensure_lookup_tables_populated): Once we have
computed a set of potentially deleted variables that turned out to
contain variables that were actually *NOT* deleted, really take
these into account by removing these false positives from the set
of deleted *variables*.  We were trying to delete these from the
set deleted *functions*; woops, I guess this was a copy & paste
error.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
src/abg-comparison.cc

index 4776806ef6ac4c5fbf317c0152b76fee4a4cb373..47557c378f17ab029ed0fc2d89bf6ae7f365f6c6 100644 (file)
@@ -12877,7 +12877,7 @@ corpus_diff::priv::ensure_lookup_tables_populated()
     for (vector<string>::const_iterator i = to_delete.begin();
         i != to_delete.end();
         ++i)
-      deleted_fns_.erase(*i);
+      deleted_vars_.erase(*i);
 
     // Do something similar for added variables.
 
This page took 0.047239 seconds and 5 git commands to generate.