cov: check label_read_pvid return value

Command can early exit when function returns 0.

diff --git a/tools/lvmdevices.c b/tools/lvmdevices.c
index b67db7464e37eb1dc114fc8c6b7eaba8054f6f70..c6cb1fcffa8b1a82cdf7a1ad3c893c00adeec9aa 100644 (file)
--- a/tools/lvmdevices.c
+++ b/tools/lvmdevices.c
@@ -181,7 +181,8 @@ int lvmdevices(struct cmd_context *cmd, int argc, char **argv)
                                continue;
                        dev = du->dev;
 
-                       label_read_pvid(dev);
+                       if (!label_read_pvid(dev))
+                               continue;
 
                        /*
                         * label_read_pvid has read the first 4K of the device
@@ -283,7 +284,8 @@ int lvmdevices(struct cmd_context *cmd, int argc, char **argv)
                 * (it's ok if the device is not a PV and has no PVID)
                 */
                label_scan_setup_bcache();
-               label_read_pvid(dev);
+               if (!label_read_pvid(dev))
+                       goto_bad;
 
                /*
                 * Allow filtered devices to be added to devices_file, but