Fix 2 signess warnings reported by gcc

Replace int with unsigned counter.
Replace snprintf with dm_snprintf.

diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 0f0880661481a50e6d9ee202bfb8af1fad23446e..59f544d61dd53ef0357ba20d52b1e1b576dd3eb0 100644 (file)
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,7 @@
 Version 1.02.64 - 
 ===================================
+  Use dm_snprintf() to fix signess warning in dm_set_dev_dir().
+  Use unsigned loop counter to fix signess warning in _other_node_ops().
   Fix const cast in dmsetup calls of dm_report_field_string().
   Streamline /dev/mapper/control node code for common cases.
   Use hard-coded dm control node device number for 2.6.36 kernels and above.

diff --git a/libdm/libdm-common.c b/libdm/libdm-common.c
index 7cce3a7a9a30d44c7a8469de93209a2d756aa21b..1ae1027c8574bc033f964fd0de0c13d32707133c 100644 (file)
--- a/libdm/libdm-common.c
+++ b/libdm/libdm-common.c
@@ -794,7 +794,7 @@ static void _del_node_op(struct node_op_parms *nop)
 /* Check if there is other the type of node operation stacked */
 static int _other_node_ops(node_op_t type)
 {
-       int i;
+       unsigned i;
 
        for (i = 0; i < NUM_NODES; i++)
                if (type != i && _count_node_ops[i])
@@ -958,8 +958,7 @@ int dm_set_dev_dir(const char *dev_dir)
        len = strlen(dev_dir);
        slash = dev_dir[len-1] == '/' ? "" : "/";
 
-       if (snprintf(_dm_dir, sizeof _dm_dir, "%s%s%s", dev_dir, slash, DM_DIR)
-           >= sizeof _dm_dir) {
+       if (dm_snprintf(_dm_dir, sizeof _dm_dir, "%s%s%s", dev_dir, slash, DM_DIR) < 0) {
                log_debug("Invalid dev_dir value, %s: name too long.", dev_dir);
                return 0;
        }