thin: fix percentage compare

Since plugin's percentage compare has been fixed,
it's now revealed wrong compare here.

The logic for threshold is - to allow to go as high
as given value e.g. 80% - so if pool is exactlu 80%
full it's still allowed to use it (dmeventd will not
resize it).

diff --git a/WHATS_NEW b/WHATS_NEW
index 5911c644337bda29056252b661f67d2e16855126..0495e4683fc3c43df86f034ab62ba24db1c07346 100644 (file)
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.133 - 
 ======================================
+  Correct percentage evaluation when checking thin-pool over threshold.
   Fix lvmcache to move PV from VG to orphans if VG is removed and lvmetad used.
   Fix lvmcache to not cache even invalid info about PV which got removed.
   Support checking of memlock daemon counter.

diff --git a/lib/metadata/thin_manip.c b/lib/metadata/thin_manip.c
index 37bf4cbea03ad80c7b85e2d49fa04ac2459afc56..6b22ce5db630920a14997857a2b0eaee91342537 100644 (file)
--- a/lib/metadata/thin_manip.c
+++ b/lib/metadata/thin_manip.c
@@ -224,7 +224,7 @@ int pool_below_threshold(const struct lv_segment *pool_seg)
        if (!lv_thin_pool_percent(pool_seg->lv, 0, &percent))
                return_0;
 
-       if (percent >= threshold) {
+       if (percent > threshold) {
                log_debug("Threshold configured for free data space in "
                          "thin pool %s has been reached (%.2f%% >= %.2f%%).",
                          display_lvname(pool_seg->lv),
@@ -237,7 +237,7 @@ int pool_below_threshold(const struct lv_segment *pool_seg)
        if (!lv_thin_pool_percent(pool_seg->lv, 1, &percent))
                return_0;
 
-       if (percent >= threshold) {
+       if (percent > threshold) {
                log_debug("Threshold configured for free metadata space in "
                          "thin pool %s has been reached (%.2f%% > %.2f%%).",
                          display_lvname(pool_seg->lv),