lvm1: Fail vg_write graciously when devices are missing.

diff --git a/lib/format1/disk-rep.c b/lib/format1/disk-rep.c
index f42d344cfeed4556591565e62bf1e7364e8fcb27..32e9f5e28c1e041ba61be922c7a22f3001d85d4f 100644 (file)
--- a/lib/format1/disk-rep.c
+++ b/lib/format1/disk-rep.c
@@ -727,6 +727,9 @@ static int _write_all_pvd(const struct format_type *fmt, struct disk_list *data,
 {
        int r;
 
+       if (!data->dev)
+               return_0;
+
        if (!dev_open(data->dev))
                return_0;
 

diff --git a/test/shell/lvmetad-lvm1.sh b/test/shell/lvmetad-lvm1.sh
index 814134c811110eab4f6a8a3cf7de38476ac5b2cf..d41e0784a2962c3d8d40cbd13a34462d9e2281cd 100644 (file)
--- a/test/shell/lvmetad-lvm1.sh
+++ b/test/shell/lvmetad-lvm1.sh
@@ -20,3 +20,12 @@ vgcreate --metadatatype 1 $vg1 "$dev1"
 should vgscan --cache
 vgs | should grep $vg1
 pvs | should grep "$dev1"
+
+# check for RHBZ 1080189 -- SEGV in lvremove/vgremove
+pvcreate -ff -y --metadatatype 1 "$dev1" "$dev2"
+vgcreate --metadatatype 1 $vg1 "$dev1" "$dev2"
+lvcreate -l1 $vg1
+pvremove -ff -y $dev2
+vgchange -an $vg1
+not lvremove $vg1
+not vgremove $vg1