]> sourceware.org Git - glibc.git/commitdiff
elf: Remove redundant add_to_global_resize_failure call from dl_open_args
authorFlorian Weimer <fweimer@redhat.com>
Tue, 12 May 2020 17:06:18 +0000 (19:06 +0200)
committerFlorian Weimer <fweimer@redhat.com>
Tue, 12 May 2020 17:06:18 +0000 (19:06 +0200)
The second call does not do anything because the data structures have
already been resized by the call that comes before the demarcation
point.  Fixes commit a509eb117fac1d764b15eba64993f4bdb63d7f3c
("Avoid late dlopen failure due to scope, TLS slotinfo updates
[BZ #25112]").

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
elf/dl-open.c

index ddcb8b53fc706828332298ab6db4e7ce5a3afdf9..8769e4705157bb7732441541242b5bd9e4558bdc 100644 (file)
@@ -769,11 +769,6 @@ dl_open_worker (void *a)
   DL_STATIC_INIT (new);
 #endif
 
-  /* Perform the necessary allocations for adding new global objects
-     to the global scope below, via add_to_global_update.  */
-  if (mode & RTLD_GLOBAL)
-    add_to_global_resize (new);
-
   /* Run the initializer functions of new objects.  Temporarily
      disable the exception handler, so that lazy binding failures are
      fatal.  */
This page took 0.048983 seconds and 5 git commands to generate.