]> sourceware.org Git - lvm2.git/commitdiff
tests: aux.sh fix double quote
authorZdenek Kabelac <zkabelac@redhat.com>
Fri, 14 Jul 2017 18:16:54 +0000 (20:16 +0200)
committerZdenek Kabelac <zkabelac@redhat.com>
Fri, 14 Jul 2017 18:29:38 +0000 (20:29 +0200)
Patch 72a58ce4b0f68f6e45ae30606fe5af21caa42b43 was wronly placing
double quotes around this variable which we want to pass expanded,
as it's just set of 'space' device args ATM.

TODO consider using array[@] to make this cleaner.
Add shellcheck directive to skip warning here

test/lib/aux.sh

index a0e05ffbf37732eb0368a133e6f5487ca7c2e8d7..9a4868958e8747510f2088e26688dcbcb2f54414 100644 (file)
@@ -224,8 +224,9 @@ prepare_lvmetad() {
        # Default debug is "-l all" and could be override
        # by setting LVM_TEST_LVMETAD_DEBUG_OPTS before calling inittest.
        echo -n "## preparing lvmetad..."
+       # shellcheck disable=SC2086
        $run_valgrind lvmetad -f "$@" -s "$TESTDIR/lvmetad.socket" \
-               "${LVM_TEST_LVMETAD_DEBUG_OPTS--l all}" &
+               ${LVM_TEST_LVMETAD_DEBUG_OPTS--l all} &
        echo $! > LOCAL_LVMETAD
        for i in {1..100} ; do
                test "$i" -eq 100 && die "Startup of lvmetad is too slow."
This page took 0.037517 seconds and 5 git commands to generate.